Modify ↓

Opened 6 years ago

Closed 5 years ago

#19087 closed defect (fixed)

Jenkins JOSM-Plugins fails on plugin wikipedia target test-init

Reported by: GerdP Owned by: team
Priority: normal Milestone:
Component: Unit tests Version:
Keywords: Cc: simon04, floscher

Description

Seems the wikipedia plugin causes a problem:
https://josm.openstreetmap.de/jenkins/job/JOSM-Plugins/jdk=JDK8/1839/console

ant clean dist takes very long (Total time: 3 minutes 50 seconds) but works on my machine.

Attachments (0)

Change History (12)

comment:1 by simon04, 5 years ago

Is this now being discussed in ticket:18053#comment:26 ff.?

comment:2 by GerdP, 5 years ago

Yes, but it should be discussed here. Sorry.

comment:3 by GerdP, 5 years ago

Cc: simon04 added

Any idea what happens with the wikipedia plugin in the test phase?
See end of https://josm.openstreetmap.de/jenkins/job/JOSM-Plugins/jdk=JDK8/1855/console
I see the same on my machine. Is it even intended that the unit tests are executed in batch?

comment:4 by GerdP, 5 years ago

Shouldn't we fix the problems in the plugins before we continue changing JOSM core? We have lots of problems with the JOSM-Integration job as well and I wonder if anybody cares?
I tried to understand what's wrong but failed so far.

comment:5 by simon04, 5 years ago

Cc: floscher added
Summary: Jenkins: Projekt JOSM-Plugins fails → Jenkins JOSM-Plugins fails on plugin wikipedia target test-init

comment:6 by simon04, 5 years ago

[o35463] together with ​https://gitlab.com/JOSM/plugin/wikipedia/-/merge_requests/1 should fix this issue.

comment:7 by GerdP, 5 years ago

jdk8 seems to be fine :)
jdk11 still fails, but for the MicrosoftStreetside plugin:
https://josm.openstreetmap.de/jenkins/job/JOSM-Plugins/jdk=JDK11/1858/consoleText

comment:8 by simon04, 5 years ago

MicrosoftStreetside: I expected that, see ticket:19208#comment:18

comment:9 by GerdP, 5 years ago

wikipedia plugin fails again, the file ivy_settings.xml is missing. I assume it should have the same content as
josm\core\ivysettings.xml ?
Note the extra underscore in the name used in josm\plugins\build-common.xml
Is that intended? Should every plugin use its own file?

in reply to:  9 comment:10 by simon04, 5 years ago

Sorry, I forgot to git add
Done via ​https://gitlab.com/JOSM/plugin/wikipedia/-/commit/46a3d84e2d5a2c42ff829980ea650c6578b2e632

Is that intended? Should every plugin use its own file?

It is how it currently works. Not my preferred solution…

comment:11 by GerdP, 5 years ago

Component: Core → Unit tests

comment:12 by GerdP, 5 years ago

Resolution: → fixed
Status: new → closed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.