Modify

Opened 8 years ago

Closed 6 years ago

Last modified 6 years ago

#14433 closed enhancement (fixed)

[PATCH] Just like wikipedia, wikimedia_commons tag should open Commons

Reported by: nyurik Owned by: Don-vip
Priority: normal Milestone:
Component: Core tag2link Version:
Keywords: Cc:

Description

Please add support for wikimedia_commons tag to open corresponding Commons's page (encoding identical to that of wikipedia tag)

Attachments (1)

tag2link_commons.diff (861 bytes ) - added by tordanik 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by Klumbumbus, 8 years ago

Component: CorePlugin wikipedia
Owner: changed from team to simon04

comment:2 by simon04, 8 years ago

Component: Plugin wikipediaPlugin tag2link
Owner: changed from simon04 to Don-vip

The taginfo stats show only 3k usages vs. 78k usages for `image`.

Opening links is provided by the tag2link plugin.

by tordanik, 7 years ago

Attachment: tag2link_commons.diff added

comment:3 by tordanik, 7 years ago

Summary: Just like wikipedia, wikimedia_commons tag should open Commons[PATCH] Just like wikipedia, wikimedia_commons tag should open Commons

comment:4 by simon04, 6 years ago

Resolution: fixed
Status: newclosed

Thank you! [o34810]

comment:5 by Klumbumbus, 6 years ago

           <condition k="wikimedia_commons" v="File:.*"/> 
           <link name="View Commons image" href="https://commons.wikimedia.org/wiki/%v%" /> 

I would rather label it "View Commons file" as it is not restricted to images. A video, audio, pdf or whatever could be linked too.

comment:6 by tordanik, 6 years ago

When I wrote the patch, the wiki documentation for the wikimedia_commons key only mentioned images or categories as possible link targets. Hence the label.

The page has since been edited to mention 3d models as another possible link target. I'm not too fond of that (especially given that this wiki edit was apparently undiscussed and no reason was given for it), but feel free to change the label if you'd like to.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.