Exception in AlignWays after merging affected nodes

[kempelen]

What steps will reproduce the problem?

• align ways that are continuous like, align way "a" to direction of way "b" in this drawing:

*
| a
*
|
| b
|
*

(So that 'b' is green, 'a' is yellow)

When you are ready, move the node between 'a' and 'b' lines into position of the end of the way and merge the nodes (so that segment 'a' becomes absent).

What is the expected result?

JOSM runs into the exceptions below, and impossible to get out from the loop of exceptions.

What happens instead?

Don't crash ;-)

Note that the other bug #12132 may fix this issue too, because that would deactivate AligWays form the affected ways and nodes.

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-08-11 21:54:24 +0200 (Thu, 11 Aug 2016)
Build-Date:2016-08-11 22:36:05
Revision:10786
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10786 hu) Windows 10 64-Bit
Memory Usage: 105 MB / 247 MB (6 MB allocated, but free)
Java version: 1.8.0_101-b13, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\Desktop\josm.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=13468, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Dataset consistency test: No problems found

Plugins:
+ AddrInterpolation (32699)
+ OpeningHoursEditor (32699)
+ alignways (32796)
+ buildings_tools (32796)
+ download_along (32730)
+ editgpx (32699)
+ measurement (32732)
+ merge-overlap (32699)
+ reverter (32796)
+ turnlanes (32796)
+ turnrestrictions (32796)
+ utilsplugin2 (32815)

Tagging presets:
+ D:\Pictures\osm\sidewalks_kerbs.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Crafts&preset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&preset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Quick-stops&zip=1
+ https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Turistautkapcsolat&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1

Last errors/warnings:
- E: Id 'Bing' is not unique - used by 'Bing műholdkép' and 'Bing műholdkép'!
- E: java.io.FileNotFoundException: D:\Pictures\osm\sidewalks_kerbs.xml (The system cannot find the path specified)
- E: D:\Pictures\osm\sidewalks_kerbs.xml
- E: A kép nem található 'presets/landuse/farmland.svg'
- W:  Landuse: Could not get presets icon presets/landuse/farmland.svg
- E: A kép nem található 'presets/leisure/horse_riding.svg'
- W:  Trail Riding Station: Could not get presets icon presets/leisure/horse_riding.svg
- E: A kép nem található 'presets/misc/entrance_main.svg'
- W:  Entrance Details: Could not get presets icon presets/misc/entrance_main.svg
- E: org.openstreetmap.josm.tools.bugreport.ReportedException: java.lang.ArrayIndexOutOfBoundsException: 4. Indok: java.lang.ArrayIndexOutOfBoundsException: 4


=== REPORTED CRASH DATA ===
MapView#paint:
 - mvp: com.tilusnet.josm.plugins.alignways.AlignWaysAlgnSegment@b1d97e60

BugReportExceptionHandler$BugReporterThread#askForBugReport:
No data collected.

=== STACK TRACE ===
Thread: AWT-EventQueue-2 (53) of javawsApplicationThreadGroup
java.lang.ArrayIndexOutOfBoundsException: 4
	at org.openstreetmap.josm.data.osm.Way.getNode(Way.java:130)
	at com.tilusnet.josm.plugins.alignways.AlignWaysSegment.drawSegment(AlignWaysSegment.java:103)
	at com.tilusnet.josm.plugins.alignways.AlignWaysSegment.highlightSegment(AlignWaysSegment.java:98)
	at com.tilusnet.josm.plugins.alignways.AlignWaysSegment.paint(AlignWaysSegment.java:88)
	at com.tilusnet.josm.plugins.alignways.AlignWaysAlgnSegment.paint(AlignWaysAlgnSegment.java:224)
	at org.openstreetmap.josm.gui.MapView.paint(MapView.java:920)
	at javax.swing.JComponent.paintChildren(Unknown Source)
	at javax.swing.JComponent.paint(Unknown Source)
	at javax.swing.JComponent.paintToOffscreen(Unknown Source)
	at javax.swing.RepaintManager$PaintManager.paintDoubleBuffered(Unknown Source)
	at javax.swing.RepaintManager$PaintManager.paint(Unknown Source)
	at javax.swing.RepaintManager.paint(Unknown Source)
	at javax.swing.JComponent._paintImmediately(Unknown Source)
	at javax.swing.JComponent.paintImmediately(Unknown Source)
	at javax.swing.RepaintManager$4.run(Unknown Source)
	at javax.swing.RepaintManager$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
	at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
	at javax.swing.RepaintManager.prePaintDirtyRegions(Unknown Source)
	at javax.swing.RepaintManager.access$1200(Unknown Source)
	at javax.swing.RepaintManager$ProcessingRunnable.run(Unknown Source)
	at java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

[Don-vip]

Should be fixed in [o32921:32922]. Please reopen the ticket if not.