Changeset 9539 in josm for trunk/src

Timestamp:

2016-01-19T13:28:25+01:00 (8 years ago)

Author:

simon04

Message:

fix #10290 - Improve ReverseWayNoTagCorrector

It evaluates its own directional tags together with those defined at
OsmPrimitive#directionKeys minus the ones that can be corrected using
ReverseWayTagCorrector.

Location:

trunk/src/org/openstreetmap/josm

Files:

• corrector/ReverseWayNoTagCorrector.java (modified) (6 diffs)
• corrector/ReverseWayTagCorrector.java (modified) (4 diffs)
• data/osm/OsmPrimitive.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/corrector/ReverseWayNoTagCorrector.java

@@ -6 +6 @@
 
 import java.util.Arrays;
+import java.util.Map;
 
 import javax.swing.JOptionPane;
 
 import org.openstreetmap.josm.Main;
+import org.openstreetmap.josm.data.osm.OsmPrimitive;
 import org.openstreetmap.josm.data.osm.Tag;
 import org.openstreetmap.josm.data.osm.TagCollection;
+import org.openstreetmap.josm.data.osm.Tagged;
 import org.openstreetmap.josm.data.osm.Way;
 import org.openstreetmap.josm.gui.ConditionalOptionPaneUtil;
@@ -34 +37 @@
      * Tags that imply a semantic meaning from the way direction and cannot be changed.
      */
-    public static final TagCollection directionalTags = new TagCollection(Arrays.asList(new Tag[]{
+    private static final TagCollection directionalTags = new TagCollection(Arrays.asList(new Tag[]{
             new Tag("natural", "coastline"),
             new Tag("natural", "cliff"),
@@ -41 +44 @@
             new Tag("barrier", "retaining_wall"),
             new Tag("man_made", "embankment"),
-            new Tag("waterway", "stream"),
-            new Tag("waterway", "river"),
-            new Tag("waterway", "ditch"),
-            new Tag("waterway", "drain"),
-            new Tag("waterway", "canal")
     }));
 
@@ -53 +51 @@
      * @return tags that imply a semantic meaning from <code>way</code> direction and cannot be changed
      */
-    public static TagCollection getDirectionalTags(Way way) {
-        return directionalTags.intersect(TagCollection.from(way));
+    public static TagCollection getDirectionalTags(Tagged way) {
+        final TagCollection collection = new TagCollection();
+        for (Map.Entry<String, String> entry : way.getKeys().entrySet()) {
+            final Tag tag = new Tag(entry.getKey(), entry.getValue());
+            final boolean isDirectional = directionalTags.contains(tag) || OsmPrimitive.directionalKeyPredicate.evaluate(tag);
+            if (isDirectional) {
+                final boolean cannotBeCorrected = ReverseWayTagCorrector.getTagCorrections(tag).isEmpty();
+                if (cannotBeCorrected) {
+                    collection.add(tag);
+                }
+            }
+        }
+        return collection;
     }
 
@@ -63 +72 @@
      * @return false if the semantic meaning change if the way is reversed, true otherwise.
      */
-    public static boolean isReversible(Way way) {
+    public static boolean isReversible(Tagged way) {
         return getDirectionalTags(way).isEmpty();
-    }
-
-    protected static String getHTML(TagCollection tags) {
-        if (tags.size() == 1) {
-            return tags.iterator().next().toString();
-        } else if (tags.size() > 1) {
-            return Utils.joinAsHtmlUnorderedList(tags);
-        } else {
-            return "";
-        }
     }
 
@@ -89 +88 @@
                 tags.size(),
                 way.getDisplayName(DefaultNameFormatter.getInstance()),
-                getHTML(tags)
+                Utils.joinAsHtmlUnorderedList(tags)
             );
         int ret = ConditionalOptionPaneUtil.showOptionDialog(

trunk/src/org/openstreetmap/josm/corrector/ReverseWayTagCorrector.java

@@ -20 +20 @@
 import org.openstreetmap.josm.data.osm.Tag;
 import org.openstreetmap.josm.data.osm.TagCollection;
+import org.openstreetmap.josm.data.osm.Tagged;
 import org.openstreetmap.josm.data.osm.Way;
 import org.openstreetmap.josm.tools.UserCancelException;
@@ -202 +203 @@
     }
 
-    @Override
-    public Collection<Command> execute(Way oldway, Way way) throws UserCancelException {
-        Map<OsmPrimitive, List<TagCorrection>> tagCorrectionsMap = new HashMap<>();
-
+    static List<TagCorrection> getTagCorrections(Tagged way) {
         List<TagCorrection> tagCorrections = new ArrayList<>();
         for (String key : way.keySet()) {
@@ -225 +223 @@
             }
         }
-        if (!tagCorrections.isEmpty()) {
-            tagCorrectionsMap.put(way, tagCorrections);
-        }
-
-        Map<OsmPrimitive, List<RoleCorrection>> roleCorrectionMap = new HashMap<>();
+        return tagCorrections;
+    }
+
+    static List<RoleCorrection> getRoleCorrections(Way oldway) {
         List<RoleCorrection> roleCorrections = new ArrayList<>();
 
@@ -263 +260 @@
             }
         }
+        return roleCorrections;
+    }
+
+    @Override
+    public Collection<Command> execute(Way oldway, Way way) throws UserCancelException {
+        Map<OsmPrimitive, List<TagCorrection>> tagCorrectionsMap = new HashMap<>();
+        List<TagCorrection> tagCorrections = getTagCorrections(way);
+        if (!tagCorrections.isEmpty()) {
+            tagCorrectionsMap.put(way, tagCorrections);
+        }
+
+        Map<OsmPrimitive, List<RoleCorrection>> roleCorrectionMap = new HashMap<>();
+        List<RoleCorrection> roleCorrections = getRoleCorrections(oldway);
         if (!roleCorrections.isEmpty()) {
             roleCorrectionMap.put(way, roleCorrections);

trunk/src/org/openstreetmap/josm/data/osm/OsmPrimitive.java

@@ -238 +238 @@
         @Override public boolean evaluate(OsmPrimitive primitive) {
             return true;
+        }
+    };
+
+    public static final Predicate<Tag> directionalKeyPredicate = new Predicate<Tag>() {
+        @Override
+        public boolean evaluate(Tag tag) {
+            return directionKeys.match(tag);
         }
     };
@@ -803 +810 @@
         String reversedDirectionDefault = "oneway=\"-1\"";
 
-        String directionDefault = "oneway? | (aerialway=* aerialway!=station) | "+
+        String directionDefault = "oneway? | (aerialway=* -aerialway=station) | "+
                 "waterway=stream | waterway=river | waterway=ditch | waterway=wadi | waterway=drain | "+
                 "\"piste:type\"=downhill | \"piste:type\"=sled | man_made=\"piste:halfpipe\" | "+