Changeset 9500 in josm

Timestamp:

2016-01-17T14:24:16+01:00 (9 years ago)

Author:

Klumbumbus

Message:

see #12386 - remove support of power=transformer on ways and add validator warning. add validator info for some power features without voltage, adjust presets, integrate separate power.mapcss in combinations.mapcss

Location:

trunk

Files:

• data/defaultpresets.xml (modified) (3 diffs)
• data/validator/combinations.mapcss (modified) (2 diffs)
• data/validator/geometry.mapcss (modified) (1 diff)
• data/validator/power.mapcss (deleted)
• styles/standard/elemstyles.mapcss (modified) (1 diff)

trunk/data/defaultpresets.xml

@@ -308 +308 @@
             <combo key="generator:output:vacuum" text="vacuum" values="yes,2 W,3 kW,5 MW,7 GW" />
             <space />
-            <combo key="frequency" text="Frequency in Hertz (Hz)" values="0,16.67,16.7,50,60" length="5" />
+            <reference ref="voltage_frequency" />
         </optional>
     </chunk>
@@ -6162 +6162 @@
                 <combo key="plant:output:vacuum" text="vacuum" values="yes,2 W,3 kW,5 MW,7 GW" />
                 <space />
-                <combo key="frequency" text="Frequency in Hertz (Hz)" values="0,16.67,16.7,50,60" length="5" />
+                <reference ref="voltage_frequency" />
             </optional>
         </item> <!-- Power Plant -->
@@ -6341 +6341 @@
             </optional>
         </item> <!-- Power Substation -->
-        <item name="Power Transformer" icon="styles/standard/power/transformer.svg" type="node,closedway" preset_name_label="true">
+        <item name="Power Transformer" icon="styles/standard/power/transformer.svg" type="node" preset_name_label="true">
             <link href="http://wiki.openstreetmap.org/wiki/Tag:power=transformer"
                   de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:power=transformer"

trunk/data/validator/combinations.mapcss

@@ -93 +93 @@
 
 /* {0.key} without {1.tag} */
+*[substation                   ][power!=substation],
+*[transformer                  ][!power],
 *[fence_type                   ][barrier!=fence],
 *[recycling_type               ][amenity!=recycling],
@@ -121 +123 @@
 /* {0.tag} without {1.key} (info level) */
 way[power=cable                ][!location],
+node[power=transformer         ][!voltage],
+way[power=line                 ][!voltage],
+way[power=minor_line           ][!voltage],
+way[power=cable                ][!voltage],
+*[power=generator              ][!voltage][generator:output:electricity],
+*[power=plant                  ][!voltage][plant:output:electricity],
+*[power=substation             ][!substation],
+*[power=transformer            ][!transformer],
 *[amenity=parking              ][!parking],
 *[amenity=parking_entrance     ][!parking] {
   throwOther: tr("{0} without {1}", "{0.tag}", "{1.key}");
+  assertMatch: "way power=line";
+  assertNoMatch: "way power=line voltage=1";
+  assertNoMatch: "way power=switch";
+  assertMatch: "way power=substation";
+  assertMatch: "way power=substation transformer=foobar";
+  assertNoMatch: "way power=substation substation=foobar";
+  assertMatch: "way power=generator generator:output:electricity=yes";
+  assertNoMatch: "way power=generator";
+  assertNoMatch: "way power=generator generator:output:electricity=yes voltage=1";
 }
 

trunk/data/validator/geometry.mapcss

@@ -82 +82 @@
 way[entrance],
 way[man_made=survey_point],
+way[power=transformer],
 way[power=pole],
 way[power=tower]!:closed,

trunk/styles/standard/elemstyles.mapcss

@@ -1181 +1181 @@
 area[power=plant],
 area[power=substation],
-area[power=transformer],
 area[power=compensator],
 area[power=converter],