1 | /* Rules partially derived from Taginfo statistics - see ticket #5017 |
---|
2 | * Taginfo query: select keypairs.key1, keypairs.key2, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key1='waterway' and keys.key=keypairs.key2 and (key1<>'highway' or keypairs.count_all>12000) and (key1<>'railway' or keypairs.count_all>3000) and (key1<>'waterway' or keypairs.count_all>800) and key2 not like '%:%' and from_fraction_all>0.97 and 1 union select keypairs.key2, keypairs.key1, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key2='waterway' and keys.key=keypairs.key1 and (key2<>'highway' or keypairs.count_all>12000) and (key2<>'railway' or keypairs.count_all>3000) and (key2<>'waterway' or keypairs.count_all>800) and key1 not like '%:%' and from_fraction_all>0.97 and 1 order by keypairs.count_all desc limit 1000; |
---|
3 | */ |
---|
4 | |
---|
5 | /* {0.key} without {1.key} (warning level) */ |
---|
6 | way[junction ][!highway][junction!=yes], |
---|
7 | *[lanes ][!highway], |
---|
8 | *[lcn ][!highway], |
---|
9 | *[living_street ][!highway], |
---|
10 | *[maintenance ][!highway], |
---|
11 | *[median ][!highway], |
---|
12 | *[motorroad ][!highway], |
---|
13 | *[ntd_id ][!highway], |
---|
14 | *[sac_scale ][!highway], |
---|
15 | *[sidewalk ][!highway], |
---|
16 | *[step_count ][!highway], |
---|
17 | *[tracktype ][!highway], |
---|
18 | *[trail_visibility ][!highway], |
---|
19 | *[trolley_wire ][!highway], |
---|
20 | *[zip_left ][!highway], |
---|
21 | *[zip_right ][!highway], |
---|
22 | *[detail ][!railway][route!=railway], |
---|
23 | *[eddy_current_brake ][!railway][route!=railway], |
---|
24 | *[electrified ][!railway][route!=railway], |
---|
25 | *[etcs ][!railway][route!=railway], |
---|
26 | *[gauge ][!railway][route!=railway], |
---|
27 | *[grade_of_track ][!railway][route!=railway], |
---|
28 | *[kursbuchstrecke ][!railway][route!=railway], |
---|
29 | *[lzb ][!railway][route!=railway], |
---|
30 | *[old_railway_operator ][!railway][route!=railway], |
---|
31 | *[operating_procedure ][!railway][route!=railway], |
---|
32 | *[pzb ][!railway][route!=railway], |
---|
33 | *[radio ][!railway][route!=railway], |
---|
34 | *[structure_gauge ][!railway][route!=railway], |
---|
35 | *[tilting_technology ][!railway][route!=railway], |
---|
36 | *[track_class ][!railway][route!=railway], |
---|
37 | *[tracks ][!railway][route!=railway], |
---|
38 | *[traffic_mode ][!railway][route!=railway], |
---|
39 | *[usage ][!railway][route!=railway], |
---|
40 | *[workrules ][!railway][route!=railway], |
---|
41 | *[stream ][!waterway], |
---|
42 | *[length_unit ][!waterway], |
---|
43 | *[llid ][!waterway], |
---|
44 | *[canal ][!waterway], |
---|
45 | *[have_riverbank ][!waterway], |
---|
46 | *[border_type ][!boundary], |
---|
47 | *[bridge:structure ][!bridge], |
---|
48 | *[piste:difficulty ][!piste:type], |
---|
49 | *[source:date ][!source], |
---|
50 | *[source:name ][!name], |
---|
51 | *[source:maxspeed:forward ][!maxspeed:forward], |
---|
52 | *[source:maxspeed:backward ][!maxspeed:backward], |
---|
53 | *[source:maxspeed:forward ][!source:maxspeed:backward], |
---|
54 | *[source:maxspeed:backward ][!source:maxspeed:forward], |
---|
55 | *[source:building ][!building], |
---|
56 | *[source:ref ][!ref], |
---|
57 | *[source:population ][!population], |
---|
58 | *[source:postal_code ][!postal_code], |
---|
59 | *[source:ele ][!ele], |
---|
60 | *[source:ref:INSEE ][!ref:INSEE], |
---|
61 | *[source:lit ][!lit], |
---|
62 | *[source:hgv ][!hgv], |
---|
63 | *[source:highway ][!highway], |
---|
64 | *[source:maxaxleload ][!maxaxleload], |
---|
65 | *[source:surface ][!surface], |
---|
66 | *[source:bridge ][!bridge], |
---|
67 | *[source:old_name ][!old_name], |
---|
68 | *[source:bicycle ][!bicycle], |
---|
69 | *[source:designation ][!designation], |
---|
70 | *[source:height ][!height], |
---|
71 | *[source:lanes ][!lanes], |
---|
72 | *[source:postcode ][!addr:postcode], |
---|
73 | *[source:housenumber ][!addr:housenumber], |
---|
74 | *[source:addr:postcode ][!addr:postcode], |
---|
75 | *[source:addr:housenumber ][!addr:housenumber], |
---|
76 | *[source:addr ][!/^addr:/], |
---|
77 | *[source:maxspeed ][!/^maxspeed:?/] { |
---|
78 | throwWarning: tr("{0} without {1}", "{0.key}", "{1.key}"); |
---|
79 | assertMatch: "way lanes=42"; |
---|
80 | assertNoMatch: "way lanes=42 highway=unclassified"; |
---|
81 | assertMatch: "node source:addr:postcode=postman"; |
---|
82 | assertMatch: "node source:addr=postman"; |
---|
83 | assertNoMatch: "node source:addr=postman addr:housenumber=42"; |
---|
84 | } |
---|
85 | |
---|
86 | /* {0.key} without {1.key} (info level) */ |
---|
87 | *[lanes:forward][!lanes:backward][oneway!=yes][oneway!=-1], |
---|
88 | *[lanes:backward][!lanes:forward][oneway!=yes][oneway!=-1], |
---|
89 | *[leaf_type ][!leaf_cycle], |
---|
90 | *[leaf_cycle][!leaf_type] { |
---|
91 | throwOther: tr("{0} without {1}", "{0.key}", "{1.key}"); |
---|
92 | } |
---|
93 | |
---|
94 | /* {0.key} without {1.tag} */ |
---|
95 | *[fence_type ][barrier!=fence], |
---|
96 | *[recycling_type ][amenity!=recycling], |
---|
97 | *[information ][tourism!=information], |
---|
98 | *[board_type ][information!=board], |
---|
99 | *[shelter_type ][amenity!=shelter], |
---|
100 | *[lamp_type ][highway!=street_lamp], |
---|
101 | *[map_type ][information!=map], |
---|
102 | *[site_type ][historic!=archaeological_site], |
---|
103 | *[artwork_type ][tourism!=artwork], |
---|
104 | *[castle_type ][historic!=castle], |
---|
105 | *[reservoir_type ][landuse!=reservoir][water!=reservoir], |
---|
106 | *[bridge:movable ][bridge!=movable], |
---|
107 | *[parking ][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking)$/], |
---|
108 | *[cutline ][man_made!=cutline], |
---|
109 | *[bunker_type ][military!=bunker] { |
---|
110 | throwWarning: tr("{0} without {1}", "{0.key}", "{1.tag}"); |
---|
111 | } |
---|
112 | |
---|
113 | /* {0.tag} without {1.key} (warning level) */ |
---|
114 | *[tourism=information][!information], |
---|
115 | *[aeroway=terminal][!building], |
---|
116 | *[power=generator][!generator:source], |
---|
117 | *[amenity=place_of_worship][!religion] { |
---|
118 | throwWarning: tr("{0} without {1}", "{0.tag}", "{1.key}"); |
---|
119 | } |
---|
120 | |
---|
121 | /* {0.tag} without {1.key} (info level) */ |
---|
122 | way[power=cable ][!location], |
---|
123 | *[amenity=parking ][!parking], |
---|
124 | *[amenity=parking_entrance ][!parking] { |
---|
125 | throwOther: tr("{0} without {1}", "{0.tag}", "{1.key}"); |
---|
126 | } |
---|
127 | |
---|
128 | /* {0.key} without {1.key} or {2.key} */ |
---|
129 | *[incline ][!highway][!railway], |
---|
130 | *[oneway ][!highway][!railway] { |
---|
131 | throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}"); |
---|
132 | } |
---|
133 | |
---|
134 | /* {0.key} without {1.key} or {2.tag} */ |
---|
135 | *[smoothness ][!highway][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking)$/], |
---|
136 | *[segregated ][!highway][railway!=crossing] { |
---|
137 | throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.tag}"); |
---|
138 | } |
---|
139 | |
---|
140 | /* {0.tag} without {1.tag} (info level) see #11600 #11393 #11850 */ |
---|
141 | *[highway=motorway][!oneway][junction!=roundabout], |
---|
142 | *[highway=motorway_link][!oneway][junction!=roundabout] { |
---|
143 | throwOther: tr("{0} without {1}", "{0.tag}", "{1.tag}"); |
---|
144 | } |
---|
145 | |
---|
146 | /* {0.tag} without {1.tag} or {2.tag} */ |
---|
147 | *[amenity=recycling][recycling_type!=container][recycling_type!=centre] { |
---|
148 | throwWarning: tr("{0} without {1} or {2}", "{0.tag}", "{1.tag}", "{2.tag}"); |
---|
149 | } |
---|
150 | |
---|
151 | /* {0.key} without {1.key}, {2.tag} or {3.tag} */ |
---|
152 | *[intermittent ][!waterway][natural!~/^(water|spring)$/][ford!=yes], |
---|
153 | *[boat ][!waterway][natural!=water][landuse!=basin] { |
---|
154 | throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.tag}", "{3.tag}"); |
---|
155 | } |
---|
156 | |
---|
157 | /* {0.key} without {1.key}, {2.key} or {3.key} */ |
---|
158 | *[snowplowing ][!highway][!amenity][!leisure] { |
---|
159 | throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.key}"); |
---|
160 | } |
---|
161 | |
---|
162 | /* {0.key} without {1.key}, {2.key} or {3.tag} */ |
---|
163 | *[toll ][!highway][!barrier][route!~/^(ferry|road)$/] { |
---|
164 | throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.tag}"); |
---|
165 | } |
---|
166 | |
---|
167 | /* {0.tag} together with {1.key}, see #10837 */ |
---|
168 | *[noname?][name] { |
---|
169 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.key}"); |
---|
170 | } |
---|
171 | |
---|
172 | /* {0.tag} together with {1.key}, see #9389, #11977 */ |
---|
173 | *[oneway=yes][/:backward/][!"traffic_sign:backward"], |
---|
174 | *[oneway=yes][/:forward/][!"traffic_sign:forward"], |
---|
175 | *[oneway=-1 ][/:backward/][!"traffic_sign:backward"], |
---|
176 | *[oneway=-1 ][/:forward/][!"traffic_sign:forward"] { |
---|
177 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.key}"); |
---|
178 | } |
---|
179 | |
---|
180 | /* {0.tag} together with {1.tag} (info level), see #9696 */ |
---|
181 | *[highway=footway][oneway=no] { |
---|
182 | throwOther: tr("{0} together with {1}", "{0.tag}", "{1.tag}"); |
---|
183 | } |
---|
184 | |
---|
185 | /* {0.tag} together with {1.tag}, see #10186 */ |
---|
186 | *[highway=footway][bicycle=designated] { |
---|
187 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}"); |
---|
188 | } |
---|
189 | |
---|
190 | /*see #11127*/ |
---|
191 | way[waterway][bridge=yes] { |
---|
192 | throwWarning: tr("{0} together with {1}", "{0.key}", "{1.tag}"); |
---|
193 | suggestAlternative: "bridge=aqueduct"; |
---|
194 | fixAdd: "bridge=aqueduct"; |
---|
195 | } |
---|
196 | |
---|
197 | /* only {0.key}, see #11104 */ |
---|
198 | *[area][eval(number_of_tags()) = 1], |
---|
199 | *[name][eval(number_of_tags()) = 1], |
---|
200 | *[ref][eval(number_of_tags()) = 1] { |
---|
201 | throwWarning: tr("incomplete object: only {0}", "{0.key}"); |
---|
202 | } |
---|
203 | /* only {0.key} and {1.key}, see #11104 */ |
---|
204 | *[name][area][eval(number_of_tags()) = 2], |
---|
205 | *[name][ref][eval(number_of_tags()) = 2] { |
---|
206 | throwWarning: tr("incomplete object: only {0} and {1}", "{0.key}", "{1.key}"); |
---|
207 | } |
---|
208 | |
---|
209 | /* see #9811, #11491 */ |
---|
210 | *[place][place!=farm][/^addr:/], |
---|
211 | *[boundary][/^addr:/], |
---|
212 | *[highway][/^addr:/][highway!=services][highway!=rest_area][!"addr:postcode"] { |
---|
213 | throwWarning: tr("{0} together with addr:*", "{0.key}"); |
---|
214 | } |
---|
215 | *[!highway][postal_code]["addr:postcode"][postal_code=*"addr:postcode"] { |
---|
216 | throwWarning: tr("{0} together with {1}", "{1.key}", "{2.key}"); |
---|
217 | } |
---|
218 | *[!highway][postal_code]["addr:postcode"][postal_code!=*"addr:postcode"] { |
---|
219 | throwWarning: tr("{0} together with {1} and conflicting values", "{1.key}", "{2.key}"); |
---|
220 | } |
---|
221 | way[highway][postal_code]["addr:postcode"][postal_code=*"addr:postcode"] { |
---|
222 | throwWarning: tr("{0} together with {1}", "{1.key}", "{2.key}"); |
---|
223 | fixRemove: "addr:postcode"; |
---|
224 | } |
---|
225 | way[highway][postal_code]["addr:postcode"][postal_code!=*"addr:postcode"] { |
---|
226 | throwWarning: tr("{0} together with {1} and conflicting values", "{1.key}", "{2.key}"); |
---|
227 | } |
---|
228 | way[highway][!postal_code]["addr:postcode"] { |
---|
229 | throwWarning: tr("{0} together with {1}", "{0.key}", "{2.key}"); |
---|
230 | suggestAlternative: "postal_code"; |
---|
231 | fixChangeKey: "addr:postcode=>postal_code"; |
---|
232 | } |
---|
233 | |
---|
234 | /* see #9195 */ |
---|
235 | *[highway=footway][cycleway=lane] { |
---|
236 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}"); |
---|
237 | suggestAlternative: "highway=path + foot=designated + bicycle=designated + segregated=yes"; |
---|
238 | } |
---|
239 | |
---|
240 | /* {0} on suspicious object */ |
---|
241 | *[tunnel ][!highway][!railway][!waterway][public_transport != platform][man_made != pipeline], |
---|
242 | *[bridge ][!highway][!railway][!waterway][!piste:type][public_transport != platform][man_made !~ /^(bridge|pipeline)$/][building != bridge], |
---|
243 | *[psv ][!highway][!railway][!waterway][amenity !~ /^parking.*/], |
---|
244 | *[width ][!highway][!railway][!waterway][!aeroway][!cycleway][!footway][!barrier][!man_made][!entrance], |
---|
245 | *[maxspeed][!highway][!railway][traffic_sign !~ /^((.*;)?maxspeed(;.*)?|[A-Z][A-Z]:.+)$/][type != enforcement][waterway !~ /^(river|canal|lock)$/][!traffic_calming], |
---|
246 | *[lit ][!highway][!railway][!piste:type][!amenity][public_transport!=platform][advertising!=billboard][!leisure][!tourism] { |
---|
247 | throwWarning: tr("{0} on suspicious object", "{0.key}"); |
---|
248 | } |
---|
249 | |
---|
250 | node[amenity =~ /^(restaurant|cafe|fast_food)$/][!name][noname!=yes] { |
---|
251 | throwOther: tr("restaurant without name"); |
---|
252 | assertMatch: "node amenity=restaurant"; |
---|
253 | assertNoMatch: "node amenity=restaurant noname=yes"; |
---|
254 | assertNoMatch: "node amenity=restaurant name=Foobar"; |
---|
255 | } |
---|
256 | |
---|
257 | way[highway][barrier], |
---|
258 | *[highway][waterway][waterway!=dam][waterway!=weir], |
---|
259 | way[highway][natural], |
---|
260 | *[landuse][building] { |
---|
261 | throwWarning: tr("{0} used with {1}", "{0.key}", "{1.key}"); |
---|
262 | assertNoMatch: "node highway=street_lamp natural=birds_nest note=josm#10193"; |
---|
263 | } |
---|
264 | |
---|
265 | *[natural=water][leisure=swimming_pool], |
---|
266 | *[natural=water][amenity=swimming_pool] { |
---|
267 | /* see #6932 */ |
---|
268 | throwWarning: tr("natural water used for swimming pool"); |
---|
269 | fixRemove: "natural"; |
---|
270 | } |
---|
271 | |
---|
272 | /* see #9593, #11183 */ |
---|
273 | *[sport][!building][!club][tourism != hotel][highway != raceway][leisure !~ /^(sports_centre|stadium|track|pitch|golf_course|water_park|swimming_pool|recreation_ground|ice_rink)$/][natural !~ /^(beach|bare_rock|peak|water)$/][amenity !~ /^(pub|restaurant|swimming_pool)$/][landuse !~ /^(recreation_ground|piste|farm|farmland)$/][barrier !~ /^(wall|retaining_wall)$/][!"piste:type"] { |
---|
274 | throwWarning: tr("sport without physical feature"); |
---|
275 | assertMatch: "node sport=tennis"; |
---|
276 | assertNoMatch: "node sport=tennis leisure=pitch"; |
---|
277 | assertNoMatch: "node sport=beachvolleyball natural=beach"; |
---|
278 | assertNoMatch: "node sport=skiiing landuse=piste"; |
---|
279 | assertNoMatch: "node sport=swimming tourism=hotel"; |
---|
280 | assertNoMatch: "node sport=10pin amenity=restaurant"; |
---|
281 | } |
---|
282 | |
---|
283 | /* see #10140 */ |
---|
284 | *[building:levels][!building][!building:part] { |
---|
285 | throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}"); |
---|
286 | } |
---|
287 | |
---|
288 | /* see #10471 */ |
---|
289 | way[waterway] > node[ford?] { set ford_on_waterway; } |
---|
290 | way[highway] > node[ford?] { set ford_on_highway; } |
---|
291 | node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway { |
---|
292 | throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway"); |
---|
293 | } |
---|
294 | |
---|
295 | /* any other *_name tag (with some exceptions) but not a name , see #10837 #11297 #11539 */ |
---|
296 | *[/_name$/][!name][!old_name][!loc_name][!uic_name][!artist_name][!"osak:municipality_name"][!"osak:street_name"][noname!=yes] { |
---|
297 | throwWarning: tr("alternative name without {0}", "{1.key}"); |
---|
298 | } |
---|
299 | |
---|
300 | /* see #10837 */ |
---|
301 | way[destination][!oneway?][junction!=roundabout][highway] { |
---|
302 | throwWarning: tr("incomplete usage of {0} on a way without {1}", "{0.key}", "{1.key}"); |
---|
303 | suggestAlternative: "destination:forward"; |
---|
304 | suggestAlternative: "destination:backward"; |
---|
305 | } |
---|
306 | |
---|
307 | /* see #11389 */ |
---|
308 | way["maxspeed:forward"=*"maxspeed:backward"][!maxspeed] { |
---|
309 | throwWarning: tr("Same value of {0} and {1}", "{0.key}", "{1.key}"); |
---|
310 | suggestAlternative: "maxspeed"; |
---|
311 | fixChangeKey: "maxspeed:forward=>maxspeed"; |
---|
312 | fixRemove: "maxspeed:backward"; |
---|
313 | } |
---|
314 | way["maxspeed:forward"=*maxspeed]["maxspeed:backward"=*maxspeed][maxspeed] { |
---|
315 | throwWarning: tr("Same value of {0}, {1} and {2}", "{0.key}", "{1.key}", "{2.key}"); |
---|
316 | set AllSameMaxspeed; |
---|
317 | suggestAlternative: "maxspeed"; |
---|
318 | fixRemove: "maxspeed:forward"; |
---|
319 | fixRemove: "maxspeed:backward"; |
---|
320 | } |
---|
321 | way["maxspeed:forward"]["maxspeed:backward"][maxspeed]!.AllSameMaxspeed { |
---|
322 | throwWarning: tr("{0} and {1} together with {2} and conflicting values", "{0.key}", "{1.key}", "{2.key}"); |
---|
323 | } |
---|
324 | way["maxspeed:forward"][maxspeed][!"maxspeed:backward"], |
---|
325 | way["maxspeed:backward"][maxspeed][!"maxspeed:forward"] { |
---|
326 | throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}"); |
---|
327 | } |
---|
328 | |
---|
329 | /* see #11837 */ |
---|
330 | way[layer][layer<0][bridge][bridge!=no][location!=underground][indoor!=yes][!tunnel], |
---|
331 | way[layer][layer>0][tunnel][tunnel!=no][location!=overground][indoor!=yes][!bridge] { |
---|
332 | throwWarning: tr("Suspicious tag combination: {0} and {1}", "{2.tag}", "{0.tag}"); |
---|
333 | } |
---|