Changeset 9211 in josm for trunk

Timestamp:

2015-12-29T14:37:40+01:00 (8 years ago)

Author:

Don-vip

Message:

fix #12252 - combine dialog: add minimum size and better initial divider location

File:

• trunk/src/org/openstreetmap/josm/gui/conflict/tags/CombinePrimitiveResolverDialog.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/conflict/tags/CombinePrimitiveResolverDialog.java

@@ -330 +330 @@
         getContentPane().add(pnlButtons, BorderLayout.SOUTH);
         validate();
-        int numTagDecisions = getTagConflictResolverModel().getNumDecisions();
-        int numRelationDecisions = getRelationMemberConflictResolverModel().getNumDecisions();
-        if (numTagDecisions > 0 && numRelationDecisions > 0) {
-            spTagConflictTypes.setDividerLocation(0.5);
-        }
+        adjustDividerLocation();
         pnlRelationMemberConflictResolver.prepareForEditing();
     }
@@ -354 +350 @@
         if (visible) {
             prepareGUIBeforeConflictResolutionStarts();
+            setMinimumSize(new Dimension(400, 400));
             new WindowGeometry(getClass().getName() + ".geometry", WindowGeometry.centerInWindow(Main.parent,
                     new Dimension(800, 600))).applySafe(this);
@@ -411 +408 @@
     }
 
+    private void adjustDividerLocation() {
+        int numTagDecisions = getTagConflictResolverModel().getNumDecisions();
+        int numRelationDecisions = getRelationMemberConflictResolverModel().getNumDecisions();
+        if (numTagDecisions > 0 && numRelationDecisions > 0) {
+            double nTop = 1.0 + numTagDecisions;
+            double nBottom = 2.5 + numRelationDecisions;
+            spTagConflictTypes.setDividerLocation(nTop/(nTop+nBottom));
+        }
+    }
+
     class AdjustDividerLocationAction extends WindowAdapter {
         @Override
         public void windowOpened(WindowEvent e) {
-            int numTagDecisions = getTagConflictResolverModel().getNumDecisions();
-            int numRelationDecisions = getRelationMemberConflictResolverModel().getNumDecisions();
-            if (numTagDecisions > 0 && numRelationDecisions > 0) {
-                spTagConflictTypes.setDividerLocation(0.5);
-            }
+            adjustDividerLocation();
         }
     }