Changeset 9006 in josm for trunk/src/org

Timestamp:

2015-11-15T01:43:19+01:00 (8 years ago)

Author:

Don-vip

Message:

fix #12084 - allow to hide main toolbar

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/DialogsToggleAction.java (modified) (1 diff)
• gui/MainMenu.java (modified) (1 diff)
• gui/preferences/ToolbarPreferences.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/actions/DialogsToggleAction.java

@@ -57 +57 @@
             Main.map.setDialogsPanelVisible(selected);
             Main.map.statusLine.setVisible(selected || Main.pref.getBoolean("statusbar.always-visible", true));
-            Main.toolbar.control.setVisible(selected || Main.pref.getBoolean("toolbar.always-visible", true));
             Main.main.menu.setVisible(selected || Main.pref.getBoolean("menu.always-visible", true));
-            // sideToolBar listens to preference changes, use it here
+            // Toolbars listen to preference changes, use it here
+            if (!Main.pref.getBoolean("toolbar.always-visible", true)) {
+                Main.pref.put("toolbar.visible", selected);
+            }
             if (!Main.pref.getBoolean("sidetoolbar.always-visible", true)) {
                 Main.pref.put("sidetoolbar.visible", selected);

trunk/src/org/openstreetmap/josm/gui/MainMenu.java

@@ -741 +741 @@
         add(viewMenu, historyinfoweb);
         viewMenu.addSeparator();
+        viewMenu.add(new PreferenceToggleAction(tr("Main toolbar"),
+                tr("Toggles the visibility of the main toolbar (i.e., the horizontal toolbar)"),
+                "toolbar.visible", true).getCheckbox());
         viewMenu.add(new PreferenceToggleAction(tr("Edit toolbar"),
                 tr("Toggles the visibility of the edit toolbar (i.e., the vertical tool)"),

trunk/src/org/openstreetmap/josm/gui/preferences/ToolbarPreferences.java

@@ -69 +69 @@
 import org.openstreetmap.josm.actions.ParameterizedAction;
 import org.openstreetmap.josm.actions.ParameterizedActionDecorator;
+import org.openstreetmap.josm.data.Preferences.PreferenceChangeEvent;
+import org.openstreetmap.josm.data.Preferences.PreferenceChangedListener;
 import org.openstreetmap.josm.gui.tagging.presets.TaggingPreset;
 import org.openstreetmap.josm.tools.GBC;
@@ -483 +485 @@
     private final DefaultMutableTreeNode rootActionsNode = new DefaultMutableTreeNode(tr("Actions"));
 
-    public JToolBar control = new JToolBar();
+    public final JToolBar control = new JToolBar();
     private final Map<Object, ActionDefinition> buttonActions = new ConcurrentHashMap<>(30);
 
@@ -900 +902 @@
         control.setFloatable(false);
         control.setComponentPopupMenu(popupMenu);
+        Main.pref.addPreferenceChangeListener(new PreferenceChangedListener() {
+            @Override
+            public void preferenceChanged(PreferenceChangeEvent e) {
+                if ("toolbar.visible".equals(e.getKey())) {
+                    refreshToolbarControl();
+                }
+            }
+        });
     }
 
@@ -1065 +1075 @@
             }
         }
+
+        boolean visible = Main.pref.getBoolean("toolbar.visible", true);
+
         control.setFocusTraversalKeysEnabled(!unregisterTab);
-        control.setVisible(control.getComponentCount() != 0);
+        control.setVisible(visible && control.getComponentCount() != 0);
         control.repaint();
     }