Changeset 8978 in josm for trunk/src

Timestamp:

2015-11-02T21:04:09+01:00 (8 years ago)

Author:

simon04

Message:

fix #12028 - Hide/disable way splitting dialog

This drops preference key splitway.segment-selection-dialog and uses
"Do not show again" boxes instead.

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/SplitWayAction.java (modified) (5 diffs)
• gui/ExtendedDialog.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/SplitWayAction.java

@@ -199 +199 @@
             final Way wayToKeep = Strategy.keepLongestChunk().determineWayToKeep(newWays);
 
-            if (ExpertToggleAction.isExpert() && !selectedWay.isNew() && Main.pref.getBoolean("splitway.segment-selection-dialog", true)) {
+            if (ExpertToggleAction.isExpert() && !selectedWay.isNew()) {
                 final ExtendedDialog dialog = new SegmentToKeepSelectionDialog(selectedWay, newWays, wayToKeep, sel);
-                dialog.setModal(false);
-                dialog.showDialog();
-            } else {
-                final SplitWayResult result = doSplitWay(getEditLayer(), selectedWay, wayToKeep, newWays, sel);
-                Main.main.undoRedo.add(result.getCommand());
-                getCurrentDataSet().setSelected(result.getNewSelection());
-            }
+                dialog.toggleEnable("way.split.segment-selection-dialog");
+                if (!dialog.toggleCheckState()) {
+                    dialog.setModal(false);
+                    dialog.showDialog();
+                    return; // splitting is performed in SegmentToKeepSelectionDialog.buttonAction()
+                }
+            }
+            final SplitWayResult result = doSplitWay(getEditLayer(), selectedWay, wayToKeep, newWays, sel);
+            Main.main.undoRedo.add(result.getCommand());
+            getCurrentDataSet().setSelected(result.getNewSelection());
         }
     }
@@ -228 +231 @@
             this.selection = selection;
             this.list = new JList<>(newWays.toArray(new Way[newWays.size()]));
-            buildList();
             this.list.setSelectedValue(wayToKeep, true);
 
@@ -238 +240 @@
         }
 
-        private void buildList() {
+        private void configureList() {
             list.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
             list.addListSelectionListener(new ListSelectionListener() {
@@ -280 +282 @@
             super.setVisible(visible);
             if (visible) {
+                configureList(); // not in constructor to not highlight segments unless dialog is shown
                 list.setSelectedIndex(list.getSelectedIndex()); // highlight way segments
             } else {
@@ -289 +292 @@
         protected void buttonAction(int buttonIndex, ActionEvent evt) {
             super.buttonAction(buttonIndex, evt);
+            toggleSaveState(); // necessary since #showDialog() does not handle it due to the non-modal dialog
             if (getValue() == 1) {
                 final Way wayToKeep = list.getSelectedValue();

trunk/src/org/openstreetmap/josm/gui/ExtendedDialog.java

@@ -609 +609 @@
      * writes the corresponding pref.
      */
-    private void toggleSaveState() {
+    protected void toggleSaveState() {
         if (!toggleable ||
                 togglePanel == null ||