Changeset 8870 in josm for trunk/src/org/openstreetmap/josm/tools

Timestamp:

2015-10-13T23:50:14+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - squid:S2325 - "private" methods that don't access instance data should be "static"

Location:

trunk/src/org/openstreetmap/josm/tools

Files:

• AlphanumComparator.java (modified) (1 diff)
• MultikeyActionsHandler.java (modified) (1 diff)
• WikiReader.java (modified) (1 diff)
• date/PrimaryDateParser.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/tools/AlphanumComparator.java

@@ -64 +64 @@
      * calculate it once) *
      */
-    private String getChunk(String s, int slength, int marker) {
+    private static String getChunk(String s, int slength, int marker) {
         StringBuilder chunk = new StringBuilder();
         char c = s.charAt(marker);

trunk/src/org/openstreetmap/josm/tools/MultikeyActionsHandler.java

@@ -208 +208 @@
     }
 
-    private String formatMenuText(KeyStroke keyStroke, String index, String description) {
+    private static String formatMenuText(KeyStroke keyStroke, String index, String description) {
         String shortcutText = KeyEvent.getKeyModifiersText(keyStroke.getModifiers()) + '+'
                 + KeyEvent.getKeyText(keyStroke.getKeyCode()) + ',' + index;

trunk/src/org/openstreetmap/josm/tools/WikiReader.java

@@ -106 +106 @@
     }
 
-    private String readNormal(BufferedReader in, boolean html) throws IOException {
+    private static String readNormal(BufferedReader in, boolean html) throws IOException {
         StringBuilder b = new StringBuilder();
         for (String line = in.readLine(); line != null; line = in.readLine()) {

trunk/src/org/openstreetmap/josm/tools/date/PrimaryDateParser.java

@@ -40 +40 @@
     }
 
-    private boolean isDateInShortStandardFormat(String date) {
+    private static boolean isDateInShortStandardFormat(String date) {
         char[] dateChars;
         // We can only parse the date if it is in a very specific format.
@@ -107 +107 @@
     }
 
-    private boolean isDateInLongStandardFormat(String date) {
+    private static boolean isDateInLongStandardFormat(String date) {
         char[] dateChars;
         // We can only parse the date if it is in a very specific format.