Changeset 8870 in josm

Timestamp:

2015-10-13T23:50:14+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - squid:S2325 - "private" methods that don't access instance data should be "static"

Location:

trunk/src/org/openstreetmap/josm

Files:

• Main.java (modified) (1 diff)
• actions/AboutAction.java (modified) (1 diff)
• actions/AlignInCircleAction.java (modified) (3 diffs)
• actions/AlignInLineAction.java (modified) (6 diffs)
• actions/CopyAction.java (modified) (1 diff)
• actions/CreateCircleAction.java (modified) (2 diffs)
• actions/CreateMultipolygonAction.java (modified) (1 diff)
• actions/DistributeAction.java (modified) (4 diffs)
• actions/JoinAreasAction.java (modified) (1 diff)
• actions/MapRectifierWMSmenuAction.java (modified) (1 diff)
• actions/PurgeAction.java (modified) (1 diff)
• actions/UnGlueAction.java (modified) (2 diffs)
• actions/mapmode/DeleteAction.java (modified) (1 diff)
• actions/mapmode/DrawAction.java (modified) (1 diff)
• actions/mapmode/ExtrudeAction.java (modified) (1 diff)
• actions/mapmode/ModifiersSpec.java (modified) (1 diff)
• actions/mapmode/ParallelWayAction.java (modified) (2 diffs)
• actions/mapmode/SelectAction.java (modified) (2 diffs)
• actions/upload/ApiPreconditionCheckerHook.java (modified) (1 diff)
• actions/upload/ValidateUploadHook.java (modified) (1 diff)
• data/AutosaveTask.java (modified) (1 diff)
• data/CustomConfigurator.java (modified) (2 diffs)
• data/Preferences.java (modified) (3 diffs)
• data/imagery/ImageryLayerInfo.java (modified) (1 diff)
• data/osm/DataSet.java (modified) (2 diffs)
• data/osm/DataSetMerger.java (modified) (1 diff)
• data/osm/FilterMatcher.java (modified) (7 diffs)
• data/osm/NoteData.java (modified) (1 diff)
• data/osm/Storage.java (modified) (1 diff)
• data/osm/Way.java (modified) (1 diff)
• data/osm/visitor/paint/StyledMapRenderer.java (modified) (2 diffs)
• data/osm/visitor/paint/WireframeMapRenderer.java (modified) (1 diff)
• data/osm/visitor/paint/relations/Multipolygon.java (modified) (1 diff)
• data/osm/visitor/paint/relations/MultipolygonCache.java (modified) (2 diffs)
• data/projection/datum/NTV2GridShiftFile.java (modified) (2 diffs)
• data/projection/datum/NTV2SubGrid.java (modified) (2 diffs)
• data/validation/OsmValidator.java (modified) (2 diffs)
• data/validation/routines/DomainValidator.java (modified) (1 diff)
• data/validation/tests/MultipolygonTest.java (modified) (3 diffs)
• data/validation/tests/TagChecker.java (modified) (3 diffs)
• data/validation/tests/WayConnectedToArea.java (modified) (1 diff)
• gui/DefaultNameFormatter.java (modified) (3 diffs)
• gui/FileDrop.java (modified) (2 diffs)
• gui/MainApplication.java (modified) (1 diff)
• gui/MainMenu.java (modified) (1 diff)
• gui/NavigatableComponent.java (modified) (1 diff)
• gui/SelectionManager.java (modified) (2 diffs)
• gui/dialogs/FilterDialog.java (modified) (1 diff)
• gui/dialogs/InspectPrimitiveDialog.java (modified) (1 diff)
• gui/dialogs/properties/TagEditHelper.java (modified) (1 diff)
• gui/dialogs/relation/MemberTableLinkedCellRenderer.java (modified) (2 diffs)
• gui/history/HistoryBrowserModel.java (modified) (1 diff)
• gui/io/UploadDialog.java (modified) (1 diff)
• gui/layer/geoimage/CorrelateGpxWithImages.java (modified) (4 diffs)
• gui/layer/geoimage/GeoImageLayer.java (modified) (1 diff)
• gui/layer/geoimage/ImageDisplay.java (modified) (3 diffs)
• gui/layer/gpx/ImportAudioAction.java (modified) (1 diff)
• gui/layer/gpx/ImportImagesAction.java (modified) (2 diffs)
• gui/mappaint/MapPaintMenu.java (modified) (1 diff)
• gui/mappaint/mapcss/MapCSSStyleSource.java (modified) (1 diff)
• gui/mappaint/xml/XmlStyleSource.java (modified) (1 diff)
• gui/preferences/SourceEditor.java (modified) (2 diffs)
• gui/preferences/advanced/AdvancedPreference.java (modified) (1 diff)
• gui/preferences/display/ColorPreference.java (modified) (2 diffs)
• gui/preferences/imagery/CacheContentsPanel.java (modified) (2 diffs)
• gui/preferences/imagery/ImageryPreference.java (modified) (1 diff)
• gui/preferences/projection/CustomProjectionChoice.java (modified) (1 diff)
• gui/preferences/projection/ProjectionPreference.java (modified) (1 diff)
• gui/preferences/validator/ValidatorTagCheckerRulesPreference.java (modified) (1 diff)
• gui/progress/PleaseWaitProgressMonitor.java (modified) (1 diff)
• gui/tagging/presets/TaggingPresetMenu.java (modified) (1 diff)
• gui/tagging/presets/TaggingPresetSelector.java (modified) (1 diff)
• gui/util/AdvancedKeyPressDetector.java (modified) (1 diff)
• gui/widgets/MultiSplitLayout.java (modified) (3 diffs)
• io/GpxExporter.java (modified) (3 diffs)
• io/InvalidXmlCharacterFilter.java (modified) (1 diff)
• io/JpgImporter.java (modified) (1 diff)
• io/NmeaReader.java (modified) (1 diff)
• io/OsmServerReader.java (modified) (1 diff)
• io/OverpassDownloadReader.java (modified) (1 diff)
• io/imagery/WMSImagery.java (modified) (1 diff)
• io/remotecontrol/RequestProcessor.java (modified) (1 diff)
• io/session/GeoImageSessionExporter.java (modified) (1 diff)
• tools/AlphanumComparator.java (modified) (1 diff)
• tools/MultikeyActionsHandler.java (modified) (1 diff)
• tools/WikiReader.java (modified) (1 diff)
• tools/date/PrimaryDateParser.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/Main.java

@@ -1265 +1265 @@
         }
 
-        private void handleComponentEvent(ComponentEvent e) {
+        private static void handleComponentEvent(ComponentEvent e) {
             Component c = e.getComponent();
             if (c instanceof JFrame && c.isVisible()) {

trunk/src/org/openstreetmap/josm/actions/AboutAction.java

@@ -111 +111 @@
     }
 
-    private JScrollPane createScrollPane(JosmTextArea area) {
+    private static JScrollPane createScrollPane(JosmTextArea area) {
         area.setBorder(BorderFactory.createEmptyBorder(5, 5, 5, 5));
         area.setOpaque(false);

trunk/src/org/openstreetmap/josm/actions/AlignInCircleAction.java

@@ -291 +291 @@
      * @return List of nodes with more than one referrer
      */
-    private List<Node> collectNodesWithExternReferers(List<Way> ways) {
+    private static List<Node> collectNodesWithExternReferers(List<Way> ways) {
         List<Node> withReferrers = new ArrayList<>();
         for (Way w: ways) {
@@ -308 +308 @@
      * @return Nodes anticlockwise ordered
      */
-    private List<Node> collectNodesAnticlockwise(List<Way> ways) {
+    private static List<Node> collectNodesAnticlockwise(List<Way> ways) {
         List<Node> nodes = new ArrayList<>();
         Node firstNode = ways.get(0).firstNode();
@@ -355 +355 @@
      * @return true if action can be done
      */
-    private boolean actionAllowed(Collection<Node> nodes) {
+    private static boolean actionAllowed(Collection<Node> nodes) {
         boolean outside = false;
         for (Node n: nodes) {

trunk/src/org/openstreetmap/josm/actions/AlignInLineAction.java

@@ -82 +82 @@
      * @return A array of two nodes.
      */
-    private Node[] nodePairFurthestApart(List<Node> nodes) {
+    private static Node[] nodePairFurthestApart(List<Node> nodes) {
         // Detect if selected nodes are on the same way.
 
@@ -134 +134 @@
      * @return An array containing the two most distant nodes.
      */
-    private Node[] nodeFurthestAppart(List<Node> nodes) {
+    private static Node[] nodeFurthestAppart(List<Node> nodes) {
         Node node1 = null, node2 = null;
         double minSqDistance = 0;
@@ -214 +214 @@
      * @throws InvalidSelection If the nodes have same coordinates.
      */
-    private Command alignOnlyNodes(List<Node> nodes) throws InvalidSelection {
+    private static Command alignOnlyNodes(List<Node> nodes) throws InvalidSelection {
         // Choose nodes used as anchor points for projection.
         Node[] anchors = nodePairFurthestApart(nodes);
@@ -232 +232 @@
      * @throws InvalidSelection if a polygon is selected, or if a node is used by 3 or more ways
      */
-    private Command alignMultiWay(Collection<Way> ways) throws InvalidSelection {
+    private static Command alignMultiWay(Collection<Way> ways) throws InvalidSelection {
         // Collect all nodes and compute line equation
         Set<Node> nodes = new HashSet<>();
@@ -270 +270 @@
      * @throws InvalidSelection if a node got more than 4 neighbours (self-crossing way)
      */
-    private List<Line> getInvolvedLines(Node node, List<Way> refWays) throws InvalidSelection {
+    private static List<Line> getInvolvedLines(Node node, List<Way> refWays) throws InvalidSelection {
         List<Line> lines = new ArrayList<>();
         List<Node> neighbors = new ArrayList<>();
@@ -327 +327 @@
      * @throws InvalidSelection if more than 2 lines
      */
-    private Command alignSingleNode(Node node, List<Line> lines) throws InvalidSelection {
+    private static Command alignSingleNode(Node node, List<Line> lines) throws InvalidSelection {
         if (lines.size() == 1)
             return lines.get(0).projectionCommand(node);

trunk/src/org/openstreetmap/josm/actions/CopyAction.java

@@ -86 +86 @@
     }
 
-    private boolean isEmptySelection() {
+    private static boolean isEmptySelection() {
         Collection<OsmPrimitive> sel = getCurrentDataSet().getSelected();
         if (sel.isEmpty()) {

trunk/src/org/openstreetmap/josm/actions/CreateCircleAction.java

@@ -248 +248 @@
      * @return Modified nodes list ordered according hand traffic.
      */
-    private List<Node> orderNodesByTrafficHand(List<Node> nodes) {
+    private static List<Node> orderNodesByTrafficHand(List<Node> nodes) {
         boolean rightHandTraffic = true;
         for (Node n: nodes) {
@@ -268 +268 @@
      * @return Modified nodes list with same direction as way.
      */
-    private List<Node> orderNodesByWay(List<Node> nodes, Way way) {
+    private static List<Node> orderNodesByWay(List<Node> nodes, Way way) {
         List<Node> wayNodes = way.getNodes();
         if (!way.isClosed()) {

trunk/src/org/openstreetmap/josm/actions/CreateMultipolygonAction.java

@@ -172 +172 @@
     }
 
-    private Relation getSelectedMultipolygonRelation() {
+    private static Relation getSelectedMultipolygonRelation() {
         return getSelectedMultipolygonRelation(getCurrentDataSet().getSelectedWays(), getCurrentDataSet().getSelectedRelations());
     }

trunk/src/org/openstreetmap/josm/actions/DistributeAction.java

@@ -112 +112 @@
      * @return true in this case
      */
-    private boolean checkDistributeWay(Collection<Way> ways, Collection<Node> nodes) {
+    private static boolean checkDistributeWay(Collection<Way> ways, Collection<Node> nodes) {
         if (ways.size() == 1 && nodes.size() <= 2) {
             Way w = ways.iterator().next();
@@ -137 +137 @@
      * @return Collection of command to be executed.
      */
-    private Collection<Command> distributeWay(Collection<Way> ways,
+    private static Collection<Command> distributeWay(Collection<Way> ways,
                                               Collection<Node> nodes) {
         Way w = ways.iterator().next();
@@ -201 +201 @@
      * @return true in this case
      */
-    private Boolean checkDistributeNodes(Collection<Way> ways, Collection<Node> nodes) {
+    private static Boolean checkDistributeNodes(Collection<Way> ways, Collection<Node> nodes) {
         return ways.isEmpty() && nodes.size() >= 3;
     }
@@ -284 +284 @@
      * @return Set of nodes without coordinates
      */
-    private Set<Node> removeNodesWithoutCoordinates(Collection<Node> col) {
+    private static Set<Node> removeNodesWithoutCoordinates(Collection<Node> col) {
         Set<Node> result = new HashSet<>();
         for (Iterator<Node> it = col.iterator(); it.hasNext();) {

trunk/src/org/openstreetmap/josm/actions/JoinAreasAction.java

@@ -963 +963 @@
      * @return list of node paths to produce.
      */
-    private List<List<Node>> buildNodeChunks(Way way, Collection<Node> splitNodes) {
+    private static List<List<Node>> buildNodeChunks(Way way, Collection<Node> splitNodes) {
         List<List<Node>> result = new ArrayList<>();
         List<Node> curList = new ArrayList<>();

trunk/src/org/openstreetmap/josm/actions/MapRectifierWMSmenuAction.java

@@ -233 +233 @@
      * @see WMSLayer#checkGrabberType
      */
-    private void addWMSLayer(String title, String url) {
+    private static void addWMSLayer(String title, String url) {
         WMSLayer layer = new WMSLayer(new ImageryInfo(title, url));
         Main.main.addLayer(layer);

trunk/src/org/openstreetmap/josm/actions/PurgeAction.java

@@ -310 +310 @@
     }
 
-    private boolean hasOnlyIncompleteMembers(Relation r, Collection<OsmPrimitive> toPurge, Collection<? extends OsmPrimitive> moreToPurge) {
+    private static boolean hasOnlyIncompleteMembers(
+            Relation r, Collection<OsmPrimitive> toPurge, Collection<? extends OsmPrimitive> moreToPurge) {
         for (RelationMember m : r.getMembers()) {
             if (!m.getMember().isIncomplete() && !toPurge.contains(m.getMember()) && !moreToPurge.contains(m.getMember()))

trunk/src/org/openstreetmap/josm/actions/UnGlueAction.java

@@ -303 +303 @@
      * </ul>
      */
-    private Way modifyWay(Node originalNode, Way w, List<Command> cmds, List<Node> newNodes) {
+    private static Way modifyWay(Node originalNode, Way w, List<Command> cmds, List<Node> newNodes) {
         // clone the node for the way
         Node newNode = new Node(originalNode, true /* clear OSM ID */);
@@ -396 +396 @@
      * @param newNodes New created nodes by this set of command
      */
-    private void execCommands(List<Command> cmds, List<Node> newNodes) {
+    private static void execCommands(List<Command> cmds, List<Node> newNodes) {
         Main.main.undoRedo.add(new SequenceCommand(/* for correct i18n of plural forms - see #9110 */
                 trn("Dupe into {0} node", "Dupe into {0} nodes", newNodes.size() + 1, newNodes.size() + 1), cmds));

trunk/src/org/openstreetmap/josm/actions/mapmode/DeleteAction.java

@@ -169 +169 @@
      * removes any highlighting that may have been set beforehand.
      */
-    private void removeHighlighting() {
+    private static void removeHighlighting() {
         highlightHelper.clear();
         DataSet ds = getCurrentDataSet();

trunk/src/org/openstreetmap/josm/actions/mapmode/DrawAction.java

@@ -831 +831 @@
     }
 
-    private void showStatusInfo(double angle, double hdg, double distance, boolean activeFlag) {
+    private static void showStatusInfo(double angle, double hdg, double distance, boolean activeFlag) {
         Main.map.statusLine.setAngle(angle);
         Main.map.statusLine.activateAnglePanel(activeFlag);

trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java

@@ -561 +561 @@
      * @param e current mouse point
      */
-    private void addNewNode(MouseEvent e) {
+    private static void addNewNode(MouseEvent e) {
         // Should maybe do the same as in DrawAction and fetch all nearby segments?
         WaySegment ws = Main.map.mapView.getNearestWaySegment(e.getPoint(), OsmPrimitive.isSelectablePredicate);

trunk/src/org/openstreetmap/josm/actions/mapmode/ModifiersSpec.java

@@ -45 +45 @@
     }
 
-    private boolean match(final int a, final int knownValue) {
+    private static boolean match(final int a, final int knownValue) {
         assert knownValue == ON | knownValue == OFF;
         return a == knownValue || a == UNKNOWN;
     }
 
-    private boolean match(final int a, final boolean knownValue) {
+    private static boolean match(final int a, final boolean knownValue) {
         return a == (knownValue ? ON : OFF) || a == UNKNOWN;
     }

trunk/src/org/openstreetmap/josm/actions/mapmode/ParallelWayAction.java

@@ -362 +362 @@
     }
 
-    private void removeWayHighlighting(Collection<Way> ways) {
+    private static void removeWayHighlighting(Collection<Way> ways) {
         if (ways == null)
             return;
@@ -566 +566 @@
     }
 
-    private String prefKey(String subKey) {
+    private static String prefKey(String subKey) {
         return "edit.make-parallel-way-action." + subKey;
     }
 
-    private String getStringPref(String subKey, String def) {
+    private static String getStringPref(String subKey, String def) {
         return Main.pref.get(prefKey(subKey), def);
     }

trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java

@@ -772 +772 @@
     }
 
-    private boolean doesImpactStatusLine(Collection<Node> affectedNodes, Collection<Way> selectedWays) {
+    private static boolean doesImpactStatusLine(Collection<Node> affectedNodes, Collection<Way> selectedWays) {
         for (Way w : selectedWays) {
             for (Node n : w.getNodes()) {
@@ -798 +798 @@
      * Obtain command in undoRedo stack to "continue" when dragging
      */
-    private Command getLastCommand() {
+    private static Command getLastCommand() {
         Command c = !Main.main.undoRedo.commands.isEmpty()
                 ? Main.main.undoRedo.commands.getLast() : null;

trunk/src/org/openstreetmap/josm/actions/upload/ApiPreconditionCheckerHook.java

@@ -50 +50 @@
     }
 
-    private boolean checkMaxNodes(Collection<OsmPrimitive> primitives, long maxNodes) {
+    private static boolean checkMaxNodes(Collection<OsmPrimitive> primitives, long maxNodes) {
         for (OsmPrimitive osmPrimitive : primitives) {
             for (String key: osmPrimitive.keySet()) {

trunk/src/org/openstreetmap/josm/actions/upload/ValidateUploadHook.java

@@ -109 +109 @@
      *          if the user requested cancel.
      */
-    private boolean displayErrorScreen(List<TestError> errors) {
+    private static boolean displayErrorScreen(List<TestError> errors) {
         JPanel p = new JPanel(new GridBagLayout());
         ValidatorTreePanel errorPanel = new ValidatorTreePanel(errors);

trunk/src/org/openstreetmap/josm/data/AutosaveTask.java

@@ -118 +118 @@
     }
 
-    private String getFileName(String layerName, int index) {
+    private static String getFileName(String layerName, int index) {
         String result = layerName;
         for (char illegalCharacter : ILLEGAL_CHARACTERS) {

trunk/src/org/openstreetmap/josm/data/CustomConfigurator.java

@@ -614 +614 @@
         }
 
-        private void processPluginInstallElement(Element elem) {
+        private static void processPluginInstallElement(Element elem) {
             String install = elem.getAttribute("install");
             String uninstall = elem.getAttribute("remove");
@@ -739 +739 @@
         }
 
-        private String normalizeDirName(String dir) {
+        private static String normalizeDirName(String dir) {
             String s = dir.replace('\\', '/');
             if (s.endsWith("/")) s = s.substring(0, s.length()-1);

trunk/src/org/openstreetmap/josm/data/Preferences.java

@@ -689 +689 @@
     }
 
-    private void addPossibleResourceDir(Set<String> locations, String s) {
+    private static void addPossibleResourceDir(Set<String> locations, String s) {
         if (s != null) {
             if (!s.endsWith(File.separator)) {
@@ -867 +867 @@
     }
 
-    private void setCorrectPermissions(File file) {
+    private static void setCorrectPermissions(File file) {
         if (!file.setReadable(false, false) && Main.isDebugEnabled()) {
             Main.debug(tr("Unable to set file non-readable {0}", file.getAbsolutePath()));
@@ -1337 +1337 @@
     }
 
-    private <T> Collection<Map<String, String>> serializeListOfStructs(Collection<T> l, Class<T> klass) {
+    private static <T> Collection<Map<String, String>> serializeListOfStructs(Collection<T> l, Class<T> klass) {
         if (l == null)
             return null;

trunk/src/org/openstreetmap/josm/data/imagery/ImageryLayerInfo.java

@@ -247 +247 @@
 
     // some additional checks to respect extended URLs in preferences (legacy workaround)
-    private boolean isSimilar(String a, String b) {
+    private static boolean isSimilar(String a, String b) {
         return Objects.equals(a, b) || (a != null && b != null && !a.isEmpty() && !b.isEmpty() && (a.contains(b) || b.contains(a)));
     }

trunk/src/org/openstreetmap/josm/data/osm/DataSet.java

@@ -969 +969 @@
     }
 
-    private void deleteWay(Way way) {
+    private static void deleteWay(Way way) {
         way.setNodes(null);
         way.setDeleted(true);
@@ -1099 +1099 @@
     }
 
-    private void reindexRelation(Relation relation) {
+    private static void reindexRelation(Relation relation) {
         BBox before = relation.getBBox();
         relation.updatePosition();

trunk/src/org/openstreetmap/josm/data/osm/DataSetMerger.java

@@ -218 +218 @@
     }
 
-    private void resetPrimitive(OsmPrimitive osm) {
+    private static void resetPrimitive(OsmPrimitive osm) {
         if (osm instanceof Way) {
             ((Way) osm).setNodes(null);

trunk/src/org/openstreetmap/josm/data/osm/FilterMatcher.java

@@ -136 +136 @@
      * when hidden is false, returns whether the primitive is disabled or hidden
      */
-    private boolean isFiltered(OsmPrimitive primitive, boolean hidden) {
+    private static boolean isFiltered(OsmPrimitive primitive, boolean hidden) {
         return hidden ? primitive.isDisabledAndHidden() : primitive.isDisabled();
     }
@@ -147 +147 @@
      * @return true, if at least one non-inverted filter applies to the primitive
      */
-    private boolean isFilterExplicit(OsmPrimitive primitive, boolean hidden) {
+    private static boolean isFilterExplicit(OsmPrimitive primitive, boolean hidden) {
         return hidden ? primitive.getHiddenType() : primitive.getDisabledType();
     }
@@ -162 +162 @@
      * (c) at least one of the parent ways is explicitly filtered
      */
-    private boolean allParentWaysFiltered(OsmPrimitive primitive, boolean hidden) {
+    private static boolean allParentWaysFiltered(OsmPrimitive primitive, boolean hidden) {
         List<OsmPrimitive> refs = primitive.getReferrers();
         boolean isExplicit = false;
@@ -175 +175 @@
     }
 
-    private boolean oneParentWayNotFiltered(OsmPrimitive primitive, boolean hidden) {
+    private static boolean oneParentWayNotFiltered(OsmPrimitive primitive, boolean hidden) {
         List<OsmPrimitive> refs = primitive.getReferrers();
         for (OsmPrimitive p: refs) {
@@ -185 +185 @@
     }
 
-    private boolean allParentMultipolygonsFiltered(OsmPrimitive primitive, boolean hidden) {
+    private static boolean allParentMultipolygonsFiltered(OsmPrimitive primitive, boolean hidden) {
         boolean isExplicit = false;
         for (Relation r : new SubclassFilteredCollection<OsmPrimitive, Relation>(
@@ -196 +196 @@
     }
 
-    private boolean oneParentMultipolygonNotFiltered(OsmPrimitive primitive, boolean hidden) {
+    private static boolean oneParentMultipolygonNotFiltered(OsmPrimitive primitive, boolean hidden) {
         for (Relation r : new SubclassFilteredCollection<OsmPrimitive, Relation>(
                 primitive.getReferrers(), OsmPrimitive.multipolygonPredicate)) {
@@ -205 +205 @@
     }
 
-    private FilterType test(List<FilterInfo> filters, OsmPrimitive primitive, boolean hidden) {
+    private static FilterType test(List<FilterInfo> filters, OsmPrimitive primitive, boolean hidden) {
 
         if (primitive.isIncomplete())

trunk/src/org/openstreetmap/josm/data/osm/NoteData.java

@@ -279 +279 @@
     }
 
-    private User getCurrentUser() {
+    private static User getCurrentUser() {
         JosmUserIdentityManager userMgr = JosmUserIdentityManager.getInstance();
         return User.createOsmUser(userMgr.getUserId(), userMgr.getUserName());

trunk/src/org/openstreetmap/josm/data/osm/Storage.java

@@ -266 +266 @@
      * Additional mixing of hash
      */
-    private int rehash(int h) {
+    private static int rehash(int h) {
         return 1103515245*h >> 2;
     }

trunk/src/org/openstreetmap/josm/data/osm/Way.java

@@ -81 +81 @@
      * Prevent directly following identical nodes in ways.
      */
-    private List<Node> removeDouble(List<Node> nodes) {
+    private static List<Node> removeDouble(List<Node> nodes) {
         Node last = null;
         int count = nodes.size();

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/StyledMapRenderer.java

@@ -363 +363 @@
     }
 
-    private Polygon buildPolygon(Point center, int radius, int sides, double rotation) {
+    private static Polygon buildPolygon(Point center, int radius, int sides, double rotation) {
         Polygon polygon = new Polygon();
         for (int i = 0; i < sides; i++) {
@@ -1500 +1500 @@
     }
 
-    private double[] pointAt(double t, Polygon poly, double pathLength) {
+    private static double[] pointAt(double t, Polygon poly, double pathLength) {
         double totalLen = t * pathLength;
         double curLen = 0;

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/WireframeMapRenderer.java

@@ -276 +276 @@
     }
 
-    private boolean isNodeTagged(Node n) {
+    private static boolean isNodeTagged(Node n) {
         return n.isTagged() || n.isAnnotated();
     }

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/relations/Multipolygon.java

@@ -77 +77 @@
         }
 
-        private void setNormalized(Collection<String> literals, List<String> target) {
+        private static void setNormalized(Collection<String> literals, List<String> target) {
             target.clear();
             for (String l: literals) {

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/relations/MultipolygonCache.java

@@ -202 +202 @@
     }
 
-    private void dispatchEvent(AbstractDatasetChangedEvent event, Relation r, Collection<Map<Relation, Multipolygon>> maps) {
+    private static void dispatchEvent(AbstractDatasetChangedEvent event, Relation r, Collection<Map<Relation, Multipolygon>> maps) {
         for (Map<Relation, Multipolygon> map : maps) {
             Multipolygon m = map.get(r);
@@ -217 +217 @@
     }
 
-    private void removeMultipolygonFrom(Relation r, Collection<Map<Relation, Multipolygon>> maps) {
+    private static void removeMultipolygonFrom(Relation r, Collection<Map<Relation, Multipolygon>> maps) {
         for (Map<Relation, Multipolygon> map : maps) {
             map.remove(r);

trunk/src/org/openstreetmap/josm/data/projection/datum/NTV2GridShiftFile.java

@@ -83 +83 @@
     private NTV2SubGrid lastSubGrid;
 
-    private void readBytes(InputStream in, byte[] b) throws IOException {
+    private static void readBytes(InputStream in, byte[] b) throws IOException {
         if (in.read(b) < b.length) {
             Main.error("Failed to read expected amount of bytes ("+ b.length +") from stream");
@@ -167 +167 @@
      * @return an array of top level Sub Grids with lower level Sub Grids set.
      */
-    private NTV2SubGrid[] createSubGridTree(NTV2SubGrid[] subGrid) {
+    private static NTV2SubGrid[] createSubGridTree(NTV2SubGrid[] subGrid) {
         int topLevelCount = 0;
         Map<String, List<NTV2SubGrid>> subGridMap = new HashMap<>();

trunk/src/org/openstreetmap/josm/data/projection/datum/NTV2SubGrid.java

@@ -149 +149 @@
     }
 
-    private void readBytes(InputStream in, byte[] b) throws IOException {
+    private static void readBytes(InputStream in, byte[] b) throws IOException {
         if (in.read(b) < b.length) {
             Main.error("Failed to read expected amount of bytes ("+ b.length +") from stream");
@@ -209 +209 @@
      * @return interpolated value
      */
-    private double interpolate(float a, float b, float c, float d, double x, double y) {
+    private static double interpolate(float a, float b, float c, float d, double x, double y) {
         return a + (((double) b - (double) a) * x) + (((double) c - (double) a) * y) +
         (((double) a + (double) d - b - c) * x * y);

trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java

@@ -162 +162 @@
      * Check if plugin directory exists (store ignored errors file)
      */
-    private void checkValidatorDir() {
+    private static void checkValidatorDir() {
         try {
             File pathDir = new File(getValidatorDir());
@@ -173 +173 @@
     }
 
-    private void loadIgnoredErrors() {
+    private static void loadIgnoredErrors() {
         ignoredErrors.clear();
         if (Main.pref.getBoolean(ValidatorPreference.PREF_USE_IGNORE, true)) {

trunk/src/org/openstreetmap/josm/data/validation/routines/DomainValidator.java

@@ -218 +218 @@
     }
 
-    private String chompLeadingDot(String str) {
+    private static String chompLeadingDot(String str) {
         if (str.startsWith(".")) {
             return str.substring(1);

trunk/src/org/openstreetmap/josm/data/validation/tests/MultipolygonTest.java

@@ -91 +91 @@
     }
 
-    private GeneralPath createPath(List<Node> nodes) {
+    private static GeneralPath createPath(List<Node> nodes) {
         GeneralPath result = new GeneralPath();
         result.moveTo((float) nodes.get(0).getCoor().lat(), (float) nodes.get(0).getCoor().lon());
@@ -109 +109 @@
     }
 
-    private Intersection getPolygonIntersection(GeneralPath outer, List<Node> inner) {
+    private static Intersection getPolygonIntersection(GeneralPath outer, List<Node> inner) {
         boolean inside = false;
         boolean outside = false;
@@ -292 +292 @@
     }
 
-    private void addRelationIfNeeded(TestError error, Relation r) {
+    private static void addRelationIfNeeded(TestError error, Relation r) {
         // Fix #8212 : if the error references only incomplete primitives,
         // add multipolygon in order to let user select something and fix the error

trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java

@@ -297 +297 @@
      * @param s string to check
      */
-    private boolean containsLow(String s) {
+    private static boolean containsLow(String s) {
         if (s == null)
             return false;
@@ -454 +454 @@
     }
 
-    private Map<String, String> getPossibleValues(Set<String> values) {
+    private static Map<String, String> getPossibleValues(Set<String> values) {
         // generate a map with common typos
         Map<String, String> map = new HashMap<>();
@@ -666 +666 @@
             public boolean valueBool;
 
-            private Pattern getPattern(String str) throws PatternSyntaxException {
+            private static Pattern getPattern(String str) throws PatternSyntaxException {
                 if (str.endsWith("/i"))
                     return Pattern.compile(str.substring(1, str.length()-2), Pattern.CASE_INSENSITIVE);

trunk/src/org/openstreetmap/josm/data/validation/tests/WayConnectedToArea.java

@@ -84 +84 @@
     }
 
-    private boolean isArea(OsmPrimitive p) {
+    private static boolean isArea(OsmPrimitive p) {
         return (p.hasKey("landuse") || p.hasKey("natural"))
                 && ElemStyles.hasAreaElemStyle(p, false);

trunk/src/org/openstreetmap/josm/gui/DefaultNameFormatter.java

@@ -422 +422 @@
     }
 
-    private String getRelationTypeName(IRelation relation) {
+    private static String getRelationTypeName(IRelation relation) {
         String name = trc("Relation type", relation.get("type"));
         if (name == null) {
@@ -455 +455 @@
     }
 
-    private String getNameTagValue(IRelation relation, String nameTag) {
+    private static String getNameTagValue(IRelation relation, String nameTag) {
         if ("name".equals(nameTag)) {
             if (Main.pref.getBoolean("osm-primitives.localize-name", true))
@@ -509 +509 @@
     }
 
-    private String buildDefaultToolTip(long id, Map<String, String> tags) {
+    private static String buildDefaultToolTip(long id, Map<String, String> tags) {
         StringBuilder sb = new StringBuilder();
         sb.append("<html><strong>id</strong>=")

trunk/src/org/openstreetmap/josm/gui/FileDrop.java

@@ -34 +34 @@
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.actions.OpenFileAction;
+import org.openstreetmap.josm.gui.FileDrop.TransferableObject;
 
 // CHECKSTYLE.OFF: HideUtilityClassConstructor
@@ -227 +228 @@
 
     /** Determine if the dragged data is a file list. */
-    private boolean isDragOk(final DropTargetDragEvent evt) {
+    private static boolean isDragOk(final DropTargetDragEvent evt) {
         boolean ok = false;
 

trunk/src/org/openstreetmap/josm/gui/MainApplication.java

@@ -617 +617 @@
         }
 
-        private void handleAutosave() {
+        private static void handleAutosave() {
             if (AutosaveTask.PROP_AUTOSAVE_ENABLED.get()) {
                 AutosaveTask autosaveTask = new AutosaveTask();

trunk/src/org/openstreetmap/josm/gui/MainMenu.java

@@ -909 +909 @@
      * @param result resulting list ofmenu items
      */
-    private void findMenuItems(final JMenu menu, final String textToFind, final List<JMenuItem> result) {
+    private static void findMenuItems(final JMenu menu, final String textToFind, final List<JMenuItem> result) {
         for (int i = 0; i < menu.getItemCount(); i++) {
             JMenuItem menuItem = menu.getItem(i);

trunk/src/org/openstreetmap/josm/gui/NavigatableComponent.java

@@ -207 +207 @@
     }
 
-    private EastNorth calculateDefaultCenter() {
+    private static EastNorth calculateDefaultCenter() {
         Bounds b = DownloadDialog.getSavedDownloadBounds();
         if (b == null) {

trunk/src/org/openstreetmap/josm/gui/SelectionManager.java

@@ -368 +368 @@
     }
 
-    private void selectionAreaChanged() {
+    private static void selectionAreaChanged() {
         // Trigger a redraw of the map view.
         // A nicer way would be to provide change events for the temporary layer.
@@ -436 +436 @@
     }
 
-    private Polygon rectToPolygon(Rectangle r) {
+    private static Polygon rectToPolygon(Rectangle r) {
         Polygon poly = new Polygon();
 

trunk/src/org/openstreetmap/josm/gui/dialogs/FilterDialog.java

@@ -288 +288 @@
      * @return List of primitives whose filtering can be affected by change in source primitives
      */
-    private Collection<OsmPrimitive> getAffectedPrimitives(Collection<? extends OsmPrimitive> primitives) {
+    private static Collection<OsmPrimitive> getAffectedPrimitives(Collection<? extends OsmPrimitive> primitives) {
         // Filters can use nested parent/child expression so complete tree is necessary
         Set<OsmPrimitive> result = new HashSet<>();

trunk/src/org/openstreetmap/josm/gui/dialogs/InspectPrimitiveDialog.java

@@ -422 +422 @@
     }
 
-    private String getSort(StyleSource s) {
+    private static String getSort(StyleSource s) {
         if (s instanceof XmlStyleSource) {
             return tr("xml");

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java

@@ -226 +226 @@
      * @return {@code true} if the user accepts to overwrite key, {@code false} otherwise
      */
-    private boolean warnOverwriteKey(String action, String togglePref) {
+    private static boolean warnOverwriteKey(String action, String togglePref) {
         ExtendedDialog ed = new ExtendedDialog(
                 Main.parent,

trunk/src/org/openstreetmap/josm/gui/dialogs/relation/MemberTableLinkedCellRenderer.java

@@ -191 +191 @@
     }
 
-    private void setDotted(Graphics g) {
+    private static void setDotted(Graphics g) {
         ((Graphics2D) g).setStroke(new BasicStroke(
                 1f,
@@ -201 +201 @@
     }
 
-    private void unsetDotted(Graphics g) {
+    private static void unsetDotted(Graphics g) {
         ((Graphics2D) g).setStroke(new BasicStroke());
     }

trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowserModel.java

@@ -788 +788 @@
         }
 
-        private User getCurrentUser() {
+        private static User getCurrentUser() {
             UserInfo info = JosmUserIdentityManager.getInstance().getUserInfo();
             return info == null ? User.getAnonymous() : User.createOsmUser(info.getId(), info.getDisplayName());

trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java

@@ -568 +568 @@
     }
 
-    private String getLastChangesetTagFromHistory(String historyKey, List<String> def) {
+    private static String getLastChangesetTagFromHistory(String historyKey, List<String> def) {
         Collection<String> history = Main.pref.getCollection(historyKey, def);
         int age = (int) (System.currentTimeMillis() / 1000 - Main.pref.getInteger(BasicUploadSettingsPanel.HISTORY_LAST_USED_KEY, 0));

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/CorrelateGpxWithImages.java

@@ -1273 +1273 @@
     }
 
-    private int getLastIndexOfListBefore(List<ImageEntry> images, long searchedTime) {
+    private static int getLastIndexOfListBefore(List<ImageEntry> images, long searchedTime) {
         int lstSize = images.size();
 
@@ -1307 +1307 @@
     }
 
-    private String formatTimezone(double timezone) {
+    private static String formatTimezone(double timezone) {
         StringBuilder ret = new StringBuilder();
 
@@ -1326 +1326 @@
     }
 
-    private double parseTimezone(String timezone) throws ParseException {
+    private static double parseTimezone(String timezone) throws ParseException {
 
         if (timezone.isEmpty())
@@ -1397 +1397 @@
     }
 
-    private long parseOffset(String offset) throws ParseException {
+    private static long parseOffset(String offset) throws ParseException {
         String error = tr("Error while parsing offset.\nExpected format: {0}", "number");
 

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/GeoImageLayer.java

@@ -444 +444 @@
     }
 
-    private Dimension scaledDimension(Image thumb) {
+    private static Dimension scaledDimension(Image thumb) {
         final double d = Main.map.mapView.getDist100Pixel();
         final double size = 10 /*meter*/;     /* size of the photo on the map */

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageDisplay.java

@@ -559 +559 @@
     }
 
-    private Point getCenterImgCoord(Rectangle visibleRect) {
+    private static Point getCenterImgCoord(Rectangle visibleRect) {
         return new Point(visibleRect.x + visibleRect.width / 2,
                 visibleRect.y + visibleRect.height / 2);
@@ -630 +630 @@
     }
 
-    private void checkVisibleRectPos(Image image, Rectangle visibleRect) {
+    private static void checkVisibleRectPos(Image image, Rectangle visibleRect) {
         if (visibleRect.x < 0) {
             visibleRect.x = 0;
@@ -645 +645 @@
     }
 
-    private void checkVisibleRectSize(Image image, Rectangle visibleRect) {
+    private static void checkVisibleRectSize(Image image, Rectangle visibleRect) {
         if (visibleRect.width > image.getWidth(null)) {
             visibleRect.width = image.getWidth(null);

trunk/src/org/openstreetmap/josm/gui/layer/gpx/ImportAudioAction.java

@@ -57 +57 @@
     }
 
-    private void warnCantImportIntoServerLayer(GpxLayer layer) {
+    private static void warnCantImportIntoServerLayer(GpxLayer layer) {
         String msg = tr("<html>The data in the GPX layer ''{0}'' has been downloaded from the server.<br>" +
                 "Because its way points do not include a timestamp we cannot correlate them with audio data.</html>",

trunk/src/org/openstreetmap/josm/gui/layer/gpx/ImportImagesAction.java

@@ -33 +33 @@
     }
 
-    private void warnCantImportIntoServerLayer(GpxLayer layer) {
+    private static void warnCantImportIntoServerLayer(GpxLayer layer) {
         String msg = tr("<html>The data in the GPX layer ''{0}'' has been downloaded from the server.<br>"+
                 "Because its way points do not include a timestamp we cannot correlate them with images.</html>",
@@ -41 +41 @@
     }
 
-    private void addRecursiveFiles(List<File> files, File[] sel) {
+    private static void addRecursiveFiles(List<File> files, File[] sel) {
         for (File f : sel) {
             if (f.isDirectory()) {

trunk/src/org/openstreetmap/josm/gui/mappaint/MapPaintMenu.java

@@ -69 +69 @@
         }
 
-        private boolean mapHasGpxorMarkerLayer() {
+        private static boolean mapHasGpxorMarkerLayer() {
             for (Layer layer : Main.map.mapView.getAllLayers()) {
                 if (layer instanceof GpxLayer || layer instanceof MarkerLayer) {

trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/MapCSSStyleSource.java

@@ -309 +309 @@
         }
 
-        private boolean conditionRequiresKeyPresence(KeyMatchType matchType) {
+        private static boolean conditionRequiresKeyPresence(KeyMatchType matchType) {
             return matchType != KeyMatchType.REGEX;
         }

trunk/src/org/openstreetmap/josm/gui/mappaint/xml/XmlStyleSource.java

@@ -141 +141 @@
      * @param mc side effect: update the valid region for the current MultiCascade
      */
-    private boolean requiresUpdate(Prototype current, Prototype candidate, Double scale, MultiCascade mc) {
+    private static boolean requiresUpdate(Prototype current, Prototype candidate, Double scale, MultiCascade mc) {
         if (current == null || candidate.priority >= current.priority) {
             if (scale == null)

trunk/src/org/openstreetmap/josm/gui/preferences/SourceEditor.java

@@ -684 +684 @@
         }
 
-        private void appendRow(StringBuilder s, String th, String td) {
+        private static void appendRow(StringBuilder s, String th, String td) {
             s.append("<tr><th>").append(th).append("</th><td>").append(td).append("</td</tr>");
         }
@@ -1426 +1426 @@
         }
 
-        private String fromSourceEntry(SourceEntry entry) {
+        private static String fromSourceEntry(SourceEntry entry) {
             if (entry == null)
                 return null;

trunk/src/org/openstreetmap/josm/gui/preferences/advanced/AdvancedPreference.java

@@ -195 +195 @@
     }
 
-    private File[] askUserForCustomSettingsFiles(boolean saveFileFlag, String title) {
+    private static File[] askUserForCustomSettingsFiles(boolean saveFileFlag, String title) {
         FileFilter filter = new FileFilter() {
             @Override

trunk/src/org/openstreetmap/josm/gui/preferences/display/ColorPreference.java

@@ -143 +143 @@
     }
 
-    private String getName(String o) {
+    private static String getName(String o) {
         return Main.pref.getColorName(o);
     }
@@ -262 +262 @@
      * Add all missing color entries.
      */
-    private void fixColorPrefixes() {
+    private static void fixColorPrefixes() {
         PaintColors.getColors();
         ConflictColors.getColors();

trunk/src/org/openstreetmap/josm/gui/preferences/imagery/CacheContentsPanel.java

@@ -172 +172 @@
     }
 
-    private Long getCacheSize(CacheAccess<String, BufferedImageCacheEntry> cache) {
+    private static Long getCacheSize(CacheAccess<String, BufferedImageCacheEntry> cache) {
         ICacheStats stats = cache.getStatistics();
         for (IStats cacheStats: stats.getAuxiliaryCacheStats()) {
@@ -242 +242 @@
     }
 
-    private DefaultTableModel getTableModel(final CacheAccess<String, BufferedImageCacheEntry> cache) {
+    private static DefaultTableModel getTableModel(final CacheAccess<String, BufferedImageCacheEntry> cache) {
         final DefaultTableModel tableModel = new DefaultTableModel(
                 getCacheStats(cache),

trunk/src/org/openstreetmap/josm/gui/preferences/imagery/ImageryPreference.java

@@ -99 +99 @@
     }
 
-    private void addSettingsSection(final JPanel p, String name, JPanel section, GBC gbc) {
+    private static void addSettingsSection(final JPanel p, String name, JPanel section, GBC gbc) {
         final JLabel lbl = new JLabel(name);
         lbl.setFont(lbl.getFont().deriveFont(Font.BOLD));

trunk/src/org/openstreetmap/josm/gui/preferences/projection/CustomProjectionChoice.java

@@ -164 +164 @@
         }
 
-        private JComponent build() {
+        private static JComponent build() {
             StringBuilder s = new StringBuilder();
             s.append("<b>+proj=...</b> - <i>").append(tr("Projection name"))

trunk/src/org/openstreetmap/josm/gui/preferences/projection/ProjectionPreference.java

@@ -471 +471 @@
     }
 
-    private Collection<String> getSubprojectionPreference(ProjectionChoice pc) {
+    private static Collection<String> getSubprojectionPreference(ProjectionChoice pc) {
         return Main.pref.getCollection("projection.sub."+pc.getId(), null);
     }

trunk/src/org/openstreetmap/josm/gui/preferences/validator/ValidatorTagCheckerRulesPreference.java

@@ -160 +160 @@
         }
 
-        private void addDefault(List<ExtendedSourceEntry> defaults, String filename, String title, String description) {
+        private static void addDefault(List<ExtendedSourceEntry> defaults, String filename, String title, String description) {
             ExtendedSourceEntry i = new ExtendedSourceEntry(filename+".mapcss", "resource://data/validator/"+filename+".mapcss");
             i.title = title;

trunk/src/org/openstreetmap/josm/gui/progress/PleaseWaitProgressMonitor.java

@@ -53 +53 @@
     private boolean cancelable;
 
-    private void doInEDT(Runnable runnable) {
+    private static void doInEDT(Runnable runnable) {
         // This must be invoke later even if current thread is EDT because inside there is dialog.setVisible
         // which freeze current code flow until modal dialog is closed

trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetMenu.java

@@ -65 +65 @@
     }
 
-    private Component copyMenuComponent(Component menuComponent) {
+    private static Component copyMenuComponent(Component menuComponent) {
         if (menuComponent instanceof JMenu) {
             JMenu menu = (JMenu) menuComponent;

trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetSelector.java

@@ -162 +162 @@
         }
 
-        private int isMatching(Collection<String> values, String[] searchString) {
+        private static int isMatching(Collection<String> values, String[] searchString) {
             int sum = 0;
             for (String word: searchString) {

trunk/src/org/openstreetmap/josm/gui/util/AdvancedKeyPressDetector.java

@@ -198 +198 @@
     }
 
-    private boolean isFocusInMainWindow() {
+    private static boolean isFocusInMainWindow() {
         Component focused = KeyboardFocusManager.getCurrentKeyboardFocusManager().getFocusOwner();
         return focused != null && SwingUtilities.getWindowAncestor(focused) instanceof JFrame;

trunk/src/org/openstreetmap/josm/gui/widgets/MultiSplitLayout.java

@@ -312 +312 @@
     }
 
-    private Dimension sizeWithInsets(Container parent, Dimension size) {
+    private static Dimension sizeWithInsets(Container parent, Dimension size) {
         Insets insets = parent.getInsets();
         int width = size.width + insets.left + insets.right;
@@ -331 +331 @@
     }
 
-    private Rectangle boundsWithYandHeight(Rectangle bounds, double y, double height) {
+    private static Rectangle boundsWithYandHeight(Rectangle bounds, double y, double height) {
         Rectangle r = new Rectangle();
         r.setBounds((int) (bounds.getX()), (int) y, (int) (bounds.getWidth()), (int) height);
@@ -337 +337 @@
     }
 
-    private Rectangle boundsWithXandWidth(Rectangle bounds, double x, double width) {
+    private static Rectangle boundsWithXandWidth(Rectangle bounds, double x, double width) {
         Rectangle r = new Rectangle();
         r.setBounds((int) x, (int) (bounds.getY()), (int) width, (int) (bounds.getHeight()));

trunk/src/org/openstreetmap/josm/io/GpxExporter.java

@@ -27 +27 @@
 import org.openstreetmap.josm.data.gpx.GpxConstants;
 import org.openstreetmap.josm.data.gpx.GpxData;
-import org.openstreetmap.josm.data.osm.DataSet;
 import org.openstreetmap.josm.gui.ExtendedDialog;
 import org.openstreetmap.josm.gui.layer.GpxLayer;
@@ -173 +172 @@
             gpxData = ((GpxLayer) layer).data;
         } else {
-            gpxData = OsmDataLayer.toGpxData(getCurrentDataSet(), file);
+            gpxData = OsmDataLayer.toGpxData(Main.main.getCurrentDataSet(), file);
         }
 
@@ -337 +336 @@
         authorNameListener.keyReleased(null);
     }
-
-    /**
-     * Replies the current dataset
-     *
-     * @return the current dataset. null, if no current dataset exists
-     */
-    private DataSet getCurrentDataSet() {
-        return Main.main.getCurrentDataSet();
-    }
 }

trunk/src/org/openstreetmap/josm/io/InvalidXmlCharacterFilter.java

@@ -61 +61 @@
     }
 
-    private char filter(char in) {
+    private static char filter(char in) {
         if (in < 0x20 && INVALID_CHARS[in]) {
             if (firstWarning) {

trunk/src/org/openstreetmap/josm/io/JpgImporter.java

@@ -88 +88 @@
     }
 
-    private void addRecursiveFiles(List<File> files, Set<String> visitedDirs, List<File> sel, ProgressMonitor progressMonitor)
+    private static void addRecursiveFiles(List<File> files, Set<String> visitedDirs, List<File> sel, ProgressMonitor progressMonitor)
             throws IOException {
 

trunk/src/org/openstreetmap/josm/io/NmeaReader.java

@@ -448 +448 @@
     }
 
-    private LatLon parseLatLon(String ns, String ew, String dlat, String dlon)
+    private static LatLon parseLatLon(String ns, String ew, String dlat, String dlon)
     throws NumberFormatException {
         String widthNorth = dlat.trim();

trunk/src/org/openstreetmap/josm/io/OsmServerReader.java

@@ -210 +210 @@
     }
 
-    private InputStream fixEncoding(InputStream stream, String encoding) throws IOException {
+    private static InputStream fixEncoding(InputStream stream, String encoding) throws IOException {
         if ("gzip".equalsIgnoreCase(encoding)) {
             stream = new GZIPInputStream(stream);

trunk/src/org/openstreetmap/josm/io/OverpassDownloadReader.java

@@ -54 +54 @@
     }
 
-    private String completeOverpassQuery(String query) {
+    private static String completeOverpassQuery(String query) {
         int firstColon = query.indexOf(';');
         if (firstColon == -1) {

trunk/src/org/openstreetmap/josm/io/imagery/WMSImagery.java

@@ -303 +303 @@
     }
 
-    private boolean isProjSupported(String crs) {
+    private static boolean isProjSupported(String crs) {
         for (ProjectionChoice pc : ProjectionPreference.getProjectionChoices()) {
             if (pc.getPreferencesFromCode(crs) != null) return true;

trunk/src/org/openstreetmap/josm/io/remotecontrol/RequestProcessor.java

@@ -354 +354 @@
      *             When error
      */
-    private void sendHeader(Writer out, String status, String contentType,
+    private static void sendHeader(Writer out, String status, String contentType,
             boolean endHeaders) throws IOException {
         out.write("HTTP/1.1 " + status + "\r\n");

trunk/src/org/openstreetmap/josm/io/session/GeoImageSessionExporter.java

@@ -124 +124 @@
     }
 
-    private void addAttr(String name, String value, Element element, SessionWriter.ExportSupport support) {
-            Element attrElem = support.createElement(name);
-            attrElem.appendChild(support.createTextNode(value));
-            element.appendChild(attrElem);
+    private static void addAttr(String name, String value, Element element, SessionWriter.ExportSupport support) {
+        Element attrElem = support.createElement(name);
+        attrElem.appendChild(support.createTextNode(value));
+        element.appendChild(attrElem);
     }
 }

trunk/src/org/openstreetmap/josm/tools/AlphanumComparator.java

@@ -64 +64 @@
      * calculate it once) *
      */
-    private String getChunk(String s, int slength, int marker) {
+    private static String getChunk(String s, int slength, int marker) {
         StringBuilder chunk = new StringBuilder();
         char c = s.charAt(marker);

trunk/src/org/openstreetmap/josm/tools/MultikeyActionsHandler.java

@@ -208 +208 @@
     }
 
-    private String formatMenuText(KeyStroke keyStroke, String index, String description) {
+    private static String formatMenuText(KeyStroke keyStroke, String index, String description) {
         String shortcutText = KeyEvent.getKeyModifiersText(keyStroke.getModifiers()) + '+'
                 + KeyEvent.getKeyText(keyStroke.getKeyCode()) + ',' + index;

trunk/src/org/openstreetmap/josm/tools/WikiReader.java

@@ -106 +106 @@
     }
 
-    private String readNormal(BufferedReader in, boolean html) throws IOException {
+    private static String readNormal(BufferedReader in, boolean html) throws IOException {
         StringBuilder b = new StringBuilder();
         for (String line = in.readLine(); line != null; line = in.readLine()) {

trunk/src/org/openstreetmap/josm/tools/date/PrimaryDateParser.java

@@ -40 +40 @@
     }
 
-    private boolean isDateInShortStandardFormat(String date) {
+    private static boolean isDateInShortStandardFormat(String date) {
         char[] dateChars;
         // We can only parse the date if it is in a very specific format.
@@ -107 +107 @@
     }
 
-    private boolean isDateInLongStandardFormat(String date) {
+    private static boolean isDateInLongStandardFormat(String date) {
         char[] dateChars;
         // We can only parse the date if it is in a very specific format.