Changeset 8848 in josm

Timestamp:

2015-10-10T14:08:30+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - squid:S2131 - Primitives should not be boxed just for "String" conversion

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/imagery/ImageryInfo.java (modified) (1 diff)
• data/validation/tests/TagChecker.java (modified) (3 diffs)
• data/validation/util/Entities.java (modified) (5 diffs)
• gui/FileDrop.java (modified) (1 diff)
• gui/layer/gpx/ImportAudioAction.java (modified) (1 diff)
• io/OsmServerWriter.java (modified) (1 diff)
• tools/PlatformHookOsx.java (modified) (1 diff)
• tools/PlatformHookUnixoid.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/imagery/ImageryInfo.java

@@ -296 +296 @@
         @Override
         public String toString() {
-            String s = "ImageryPreferenceEntry [name=" + name;
+            StringBuilder s = new StringBuilder("ImageryPreferenceEntry [name=").append(name);
             if (id != null) {
-                s += " id=" + id;
-            }
-            s += ']';
-            return s;
+                s.append(" id=").append(id);
+            }
+            s.append(']');
+            return s.toString();
         }
     }

trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java

@@ -131 +131 @@
     protected EditableList sourcesList;
 
-    protected static final Entities entities = new Entities();
-
     private static final List<String> DEFAULT_SOURCES = Arrays.asList(/*DATA_FILE, */IGNORE_FILE, SPELL_FILE);
 
@@ -371 +369 @@
                 withErrors.put(p, "SPACE");
             }
-            if (checkValues && value != null && !value.equals(entities.unescape(value)) && !withErrors.contains(p, "HTML")) {
+            if (checkValues && value != null && !value.equals(Entities.unescape(value)) && !withErrors.contains(p, "HTML")) {
                 errors.add(new TestError(this, Severity.OTHER, tr("Property values contain HTML entity"),
                         tr(s, key), MessageFormat.format(s, key), INVALID_HTML, p));
@@ -620 +618 @@
                         commands.add(new ChangePropertyKeyCommand(p, key, Tag.removeWhiteSpaces(key)));
                     } else {
-                        String evalue = entities.unescape(value);
+                        String evalue = Entities.unescape(value);
                         if (!evalue.equals(value)) {
                             commands.add(new ChangePropertyCommand(p, key, evalue));

trunk/src/org/openstreetmap/josm/data/validation/util/Entities.java

@@ -31 +31 @@
  * @see <a href="http://www.w3.org/TR/html401/charset.html#code-position">HTML 4.01 Code positions</a>
  */
-public class Entities {
+public final class Entities {
     private static final String[][] ARRAY = {
         /* BASIC */
@@ -336 +336 @@
     private static volatile Map<String, String> mapNameToValue;
 
-    public String unescape(String str) {
+    private Entities() {
+        // Private constructor for utilities classes
+    }
+
+    public static String unescape(String str) {
         int firstAmp = str.indexOf('&');
         if (firstAmp < 0)
             return str;
-        String res = str.substring(0, firstAmp);
+        StringBuilder res = new StringBuilder(str.substring(0, firstAmp));
         int len = str.length();
         for (int i = firstAmp; i < len; i++) {
@@ -348 +352 @@
                 int semiColonIdx = str.indexOf(';', nextIdx);
                 if (semiColonIdx == -1) {
-                    res += c;
+                    res.append(c);
                     continue;
                 }
@@ -354 +358 @@
                 if (amphersandIdx != -1 && amphersandIdx < semiColonIdx) {
                     // Then the text looks like &...&...;
-                    res += c;
+                    res.append(c);
                     continue;
                 }
@@ -394 +398 @@
 
                 if (entityValue == -1) {
-                    res += '&' + entityContent + ';';
+                    res.append('&').append(entityContent).append(';');
                 } else {
-                    res += (char) entityValue;
+                    res.append((char) entityValue);
                 }
                 i = semiColonIdx; // move index up to the semi-colon
             } else {
-                res += c;
+                res.append(c);
             }
         }
-        return res;
+        return res.toString();
     }
 }

trunk/src/org/openstreetmap/josm/gui/FileDrop.java

@@ -155 +155 @@
 
     // BEGIN 2007-09-12 Nathan Blomquist -- Linux (KDE/Gnome) support added.
-    private static final String ZERO_CHAR_STRING = "" + (char) 0;
+    private static final String ZERO_CHAR_STRING = Character.toString((char) 0);
 
     private static File[] createFileArray(BufferedReader bReader) {

trunk/src/org/openstreetmap/josm/gui/layer/gpx/ImportAudioAction.java

@@ -96 +96 @@
                 });
             }
-            String names = null;
+            StringBuilder names = new StringBuilder();
             for (File file : sel) {
-                if (names == null) {
-                    names = " (";
+                if (names.length() == 0) {
+                    names.append(" (");
                 } else {
-                    names += ", ";
-                }
-                names += file.getName();
-            }
-            if (names != null) {
-                names += ')';
-            } else {
-                names = "";
+                    names.append(", ");
+                }
+                names.append(file.getName());
+            }
+            if (names.length() > 0) {
+                names.append(')');
             }
             MarkerLayer ml = new MarkerLayer(new GpxData(),

trunk/src/org/openstreetmap/josm/io/OsmServerWriter.java

@@ -71 +71 @@
         long minutes_left = ms_left / MSECS_PER_MINUTE;
         long seconds_left = (ms_left / MSECS_PER_SECOND) % SECONDS_PER_MINUTE;
-        String time_left_str = Long.toString(minutes_left) + ':';
+        StringBuilder time_left_str = new StringBuilder().append(minutes_left).append(':');
         if (seconds_left < 10) {
-            time_left_str += '0';
-        }
-        return time_left_str + Long.toString(seconds_left);
+            time_left_str.append('0');
+        }
+        return time_left_str.append(seconds_left).toString();
     }
 

trunk/src/org/openstreetmap/josm/tools/PlatformHookOsx.java

@@ -289 +289 @@
             canHtml = false;
         }
-        String result = "";
+        StringBuilder result = new StringBuilder();
         if (canHtml) {
-            result += "<html>";
-        }
-        result += name;
+            result.append("<html>");
+        }
+        result.append(name);
         if (sc != null && !sc.getKeyText().isEmpty()) {
-            result += ' ';
+            result.append(' ');
             if (canHtml) {
-                result += "<font size='-2'>";
-            }
-            result += '('+sc.getKeyText()+')';
+                result.append("<font size='-2'>");
+            }
+            result.append('(').append(sc.getKeyText()).append(')');
             if (canHtml) {
-                result += "</font>";
+                result.append("</font>");
             }
         }
         if (canHtml) {
-            result += "&nbsp;</html>";
-        }
-        return result;
+            result.append("&nbsp;</html>");
+        }
+        return result.toString();
     }
 

trunk/src/org/openstreetmap/josm/tools/PlatformHookUnixoid.java

@@ -149 +149 @@
     @Override
     public String makeTooltip(String name, Shortcut sc) {
-        String result = "";
-        result += "<html>";
-        result += name;
+        StringBuilder result = new StringBuilder();
+        result.append("<html>").append(name);
         if (sc != null && !sc.getKeyText().isEmpty()) {
-            result += ' ';
-            result += "<font size='-2'>";
-            result += '('+sc.getKeyText()+')';
-            result += "</font>";
-        }
-        return result + "&nbsp;</html>";
+            result.append(' ')
+                  .append("<font size='-2'>")
+                  .append('(').append(sc.getKeyText()).append(')')
+                  .append("</font>");
+        }
+        return result.append("&nbsp;</html>").toString();
     }