Changeset 8848 in josm for trunk/src/org/openstreetmap/josm/gui/layer/gpx/ImportAudioAction.java

Timestamp:

2015-10-10T14:08:30+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - squid:S2131 - Primitives should not be boxed just for "String" conversion

File:

• trunk/src/org/openstreetmap/josm/gui/layer/gpx/ImportAudioAction.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/layer/gpx/ImportAudioAction.java

@@ -96 +96 @@
                 });
             }
-            String names = null;
+            StringBuilder names = new StringBuilder();
             for (File file : sel) {
-                if (names == null) {
-                    names = " (";
+                if (names.length() == 0) {
+                    names.append(" (");
                 } else {
-                    names += ", ";
-                }
-                names += file.getName();
-            }
-            if (names != null) {
-                names += ')';
-            } else {
-                names = "";
+                    names.append(", ");
+                }
+                names.append(file.getName());
+            }
+            if (names.length() > 0) {
+                names.append(')');
             }
             MarkerLayer ml = new MarkerLayer(new GpxData(),