Changeset 8846 in josm for trunk/src/org/openstreetmap/josm/tools/I18n.java

Timestamp:

2015-10-10T01:40:42+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib - minor performance improvements:

• Method passes constant String of length 1 to character overridden method
• Method needlessly boxes a boolean constant
• Method uses iterator().next() on a List to get the first item
• Method converts String to boxed primitive using excessive boxing
• Method converts String to primitive using excessive boxing
• Method creates array using constants
• Class defines List based fields but uses them like Sets

File:

• trunk/src/org/openstreetmap/josm/tools/I18n.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/tools/I18n.java

@@ -309 +309 @@
         }
         if (strings != null) {
-            String trans = strings.get(ctx == null ? text : "_:"+ctx+"\n"+text);
+            String trans = strings.get(ctx == null ? text : "_:"+ctx+'\n'+text);
             if (trans != null)
                 return trans;
@@ -315 +315 @@
         if (pstrings != null) {
             i = pluralEval(1);
-            String[] trans = pstrings.get(ctx == null ? text : "_:"+ctx+"\n"+text);
+            String[] trans = pstrings.get(ctx == null ? text : "_:"+ctx+'\n'+text);
             if (trans != null && trans.length > i)
                 return trans[i];
@@ -339 +339 @@
         if (pstrings != null) {
             i = pluralEval(num);
-            String[] trans = pstrings.get(ctx == null ? text : "_:"+ctx+"\n"+text);
+            String[] trans = pstrings.get(ctx == null ? text : "_:"+ctx+'\n'+text);
             if (trans != null && trans.length > i)
                 return trans[i];
@@ -353 +353 @@
 
     private static URL getTranslationFile(String lang) {
-        return Main.class.getResource("/data/"+lang.replace("@", "-")+".lang");
+        return Main.class.getResource("/data/"+lang.replace('@', '-')+".lang");
     }