Changeset 8846 in josm for trunk/src/org/openstreetmap/josm/gui/widgets/JosmEditorPane.java

Timestamp:

2015-10-10T01:40:42+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib - minor performance improvements:

• Method passes constant String of length 1 to character overridden method
• Method needlessly boxes a boolean constant
• Method uses iterator().next() on a List to get the first item
• Method converts String to boxed primitive using excessive boxing
• Method converts String to primitive using excessive boxing
• Method creates array using constants
• Class defines List based fields but uses them like Sets

File:

• trunk/src/org/openstreetmap/josm/gui/widgets/JosmEditorPane.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/widgets/JosmEditorPane.java

@@ -99 +99 @@
         final Font f = UIManager.getFont("Label.font");
         final StyleSheet ss = new StyleSheet();
-        ss.addRule((allBold ? "html" : "strong, b") + " {" + getFontRule(f) + "}");
+        ss.addRule((allBold ? "html" : "strong, b") + " {" + getFontRule(f) + '}');
         ss.addRule("a {text-decoration: underline; color: blue}");
-        ss.addRule("h1 {" + getFontRule(GuiHelper.getTitleFont()) + "}");
+        ss.addRule("h1 {" + getFontRule(GuiHelper.getTitleFont()) + '}');
         ss.addRule("ol {margin-left: 1cm; margin-top: 0.1cm; margin-bottom: 0.2cm; list-style-type: decimal}");
         ss.addRule("ul {margin-left: 1cm; margin-top: 0.1cm; margin-bottom: 0.2cm; list-style-type: disc}");
         if ("km".equals(LanguageInfo.getJOSMLocaleCode())) {
             // Fix rendering problem for Khmer script
-            ss.addRule("p {" + getFontRule(UIManager.getFont("Label.font")) + "}");
+            ss.addRule("p {" + getFontRule(UIManager.getFont("Label.font")) + '}');
         }
         kit.setStyleSheet(ss);