Changeset 8840 in josm for trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPresetItems.java

Timestamp:

2015-10-09T02:12:45+02:00 (10 years ago)

Author:

Don-vip

Message:

sonar - squid:S3052 - Fields should not be initialized to default values

File:

• trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPresetItems.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPresetItems.java

@@ -81 +81 @@
     }
 
-    private static int auto_increment_selected = 0;
+    private static int auto_increment_selected;
     /** Translatation of "<different>". Use in combo boxes to display en entry matching several different values. */
     public static final String DIFFERENT = tr("<different>");
@@ -189 +189 @@
         public SearchCompiler.Match memberExpression;
 
-        public boolean required = false;
-        private long count = 0;
+        public boolean required;
+        private long count;
 
         public void setType(String types) throws SAXException {
@@ -307 +307 @@
     public static class Usage {
         private SortedSet<String> values;
-        private boolean hadKeys = false;
-        private boolean hadEmpty = false;
+        private boolean hadKeys;
+        private boolean hadEmpty;
 
         public boolean hasUniqueValue() {
@@ -885 +885 @@
         public String value_off = OsmUtils.falseval;
         /** whether the off value is disabled in the dialog, i.e., only unset or yes are provided */
-        public boolean disable_off = false;
+        public boolean disable_off;
         /** "on" or "off" or unset (default is unset) */
-        public String default_ = null; // only used for tagless objects
+        public String default_; // only used for tagless objects
 
         private QuadStateCheckBox check;
@@ -1010 +1010 @@
         protected JComponent component;
         protected final Map<String, PresetListEntry> lhm = new LinkedHashMap<>();
-        private boolean initialized = false;
+        private boolean initialized;
         protected Usage usage;
         protected Object originalValue;