Changeset 8710 in josm for trunk

Timestamp:

2015-09-01T20:34:28+02:00 (9 years ago)

Author:

simon04

Message:

see #11795 - taginfoextract: avoid "Could not get presets icon" by not loading icons

Location:

trunk

Files:

• scripts/taginfoextract.groovy (modified) (1 diff)
• src/org/openstreetmap/josm/gui/tagging/TaggingPreset.java (modified) (1 diff)
• src/org/openstreetmap/josm/gui/tagging/TaggingPresetItems.java (modified) (1 diff)
• src/org/openstreetmap/josm/gui/tagging/TaggingPresetReader.java (modified) (2 diffs)

trunk/scripts/taginfoextract.groovy

@@ -276 +276 @@
     void run_external_presets() {
         init()
+        TaggingPresetReader.setLoadIcons(false)
         def sources = new TaggingPresetPreference.TaggingPresetSourceEditor().loadAndGetAvailableSources()
         def tags = []

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPreset.java

@@ -153 +153 @@
     /**
      * Called from the XML parser to set the icon.
-     * This task is performed in the background in order to speedup startup.
+     * The loading task is performed in the background in order to speedup startup.
      */
     public void setIcon(final String iconName) {
         this.iconName = iconName;
+        if (!TaggingPresetReader.isLoadIcons()) {
+            return;
+        }
         File arch = TaggingPresetReader.getZipIcons();
         final Collection<String> s = Main.pref.getCollection("taggingpreset.icon.sources", null);

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPresetItems.java

@@ -1465 +1465 @@
 
     public static Set<TaggingPresetType> getType(String types) throws SAXException {
+        if (types == null || types.isEmpty()) {
+            throw new SAXException(tr("Unknown type: {0}", types));
+        }
         if (TYPE_CACHE.containsKey(types))
             return TYPE_CACHE.get(types);

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPresetReader.java

@@ -51 +51 @@
 
     private static volatile File zipIcons = null;
+    private static volatile boolean loadIcons = true;
 
     /**
@@ -388 +389 @@
         return zipIcons;
     }
+
+    /**
+     * Returns true if icon images should be loaded.
+     */
+    public static boolean isLoadIcons() {
+        return loadIcons;
+    }
+
+    /**
+     * Sets whether icon images should be loaded.
+     */
+    public static void setLoadIcons(boolean loadIcons) {
+        TaggingPresetReader.loadIcons = loadIcons;
+    }
 }