Changeset 8600 in josm for trunk/src/org/openstreetmap

Timestamp:

2015-07-13T20:56:12+02:00 (9 years ago)

Author:

wiktorn

Message:

• fix sonar issues
• implement cache clear for "clear" button

Closes: #11327

File:

• trunk/src/org/openstreetmap/josm/gui/preferences/imagery/CacheContentsPanel.java (modified) (6 diffs)

trunk/src/org/openstreetmap/josm/gui/preferences/imagery/CacheContentsPanel.java

@@ -56 +56 @@
 
     private static class ButtonColumn extends AbstractCellEditor implements TableCellRenderer, TableCellEditor, ActionListener {
-        private Action action;
-        private JButton renderButton;
-
-        public ButtonColumn(Action action) {
+        private final Action action;
+        private final JButton renderButton;
+
+        private ButtonColumn(Action action) {
             this.action = action;
             renderButton = new JButton();
@@ -109 +109 @@
     }
 
-    private ExecutorService executor = Executors.newSingleThreadExecutor();
+    private transient ExecutorService executor = Executors.newSingleThreadExecutor();
 
     /**
@@ -141 +141 @@
                 new JScrollPane(getTableForCache(cache)),
                 GBC.eol().fill(GBC.BOTH));
+
+        executor.shutdown();
     }
 
@@ -156 +158 @@
             }
         }
-        return new Long(-1);
-    }
-
-    private Map<String, Integer> getCacheStats(CacheAccess<String, BufferedImageCacheEntry> cache) {
+        return Long.valueOf(-1);
+    }
+
+    private static Map<String, Integer> getCacheStats(CacheAccess<String, BufferedImageCacheEntry> cache) {
         Set<String> keySet = cache.getCacheControl().getKeySet();
         Map<String, int[]> temp = new ConcurrentHashMap<>(); // use int[] as a Object reference to int, gives better performance
@@ -213 +215 @@
     }
 
-    private JTable getTableForCache(CacheAccess<String, BufferedImageCacheEntry> cache) {
+    private JTable getTableForCache(final CacheAccess<String, BufferedImageCacheEntry> cache) {
         final DefaultTableModel tableModel = new DefaultTableModel(
                 new String[][]{{tr("Loading data"), tr("Please wait"), ""}},
@@ -233 +235 @@
                         int row = ret.convertRowIndexToModel(ret.getEditingRow());
                         tableModel.setValueAt("0", row, 1);
+                        cache.remove(ret.getValueAt(row, 0) + ":");
                     }
                 });