Changeset 8566 in josm for trunk

Timestamp:

2015-07-04T18:35:10+02:00 (9 years ago)

Author:

Don-vip

Message:

fix #11653 - AbstractPrimitive.getKeys optimization (patch by shinigami)

File:

• trunk/src/org/openstreetmap/josm/data/osm/AbstractPrimitive.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/osm/AbstractPrimitive.java

@@ -469 +469 @@
     /**
      * The key/value list for this primitive.
-     *
      */
     protected String[] keys;
@@ -481 +480 @@
     @Override
     public Map<String, String> getKeys() {
-        Map<String, String> result = new HashMap<>();
-        String[] keys = this.keys;
-        if (keys != null) {
-            for (int i = 0; i < keys.length; i += 2) {
-                result.put(keys[i], keys[i + 1]);
-            }
-        }
+        final String[] keys = this.keys;
+        if (keys == null || keys.length == 0) {
+            return Collections.emptyMap();
+        } else if (keys.length == 2) {
+            return Collections.singletonMap(keys[0], keys[1]);
+        }
+
+        final Map<String, String> result = new HashMap<>();
+        for (int i = 0; i < keys.length; i += 2) {
+            result.put(keys[i], keys[i + 1]);
+        }
+
         return result;
     }