Changeset 8468 in josm for trunk/src/org/openstreetmap/josm/gui/dialogs/SelectionListDialog.java

Timestamp:

2015-06-06T01:48:41+02:00 (9 years ago)

Author:

Don-vip

Message:

fix some minor sonar/code style issues:

• Avoid Protected Field In Final Class
• Class defines fields that are used only as locals

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/SelectionListDialog.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/SelectionListDialog.java

@@ -767 +767 @@
         }
 
+        /**
+         * Constructs a new {@code SearchPopupMenu}.
+         */
         public SearchPopupMenu() {
             for (SearchSetting ss: org.openstreetmap.josm.actions.search.SearchAction.getSearchHistory()) {
@@ -780 +783 @@
      */
     protected static class SelectionMenuItem extends JMenuItem implements ActionListener {
-        private final transient DefaultNameFormatter df = DefaultNameFormatter.getInstance();
         protected transient Collection<? extends OsmPrimitive> sel;
 
         public SelectionMenuItem(Collection<? extends OsmPrimitive> sel) {
-            super();
             this.sel = sel;
             int ways = 0;
@@ -816 +817 @@
                 this.sel=new ArrayList<>(); // empty selection
             }
+            DefaultNameFormatter df = DefaultNameFormatter.getInstance();
             if (ways + nodes + relations == 1) {
                 text.append(": ");