Changeset 8320 in josm

Timestamp:

2015-05-04T19:05:13+02:00 (10 years ago)

Author:

stoecker

Message:

fix #11405 - warn about very long segments (>15km for now)

Location:

trunk/src/org/openstreetmap/josm/data

Files:

• osm/Way.java (modified) (1 diff)
• validation/OsmValidator.java (modified) (2 diffs)
• validation/tests/LongSegment.java (added)

trunk/src/org/openstreetmap/josm/data/osm/Way.java

@@ -685 +685 @@
 
     /**
+     * Replies the length of the longest segement of the way, in metres, as computed by {@link LatLon#greatCircleDistance}.
+     * @return The length of the segment, in metres
+     * @since 4138
+     */
+    public double getLongestSegmentLength() {
+        double length = 0;
+        Node lastN = null;
+        for (Node n:nodes) {
+            if (lastN != null) {
+                LatLon lastNcoor = lastN.getCoor();
+                LatLon coor = n.getCoor();
+                if (lastNcoor != null && coor != null) {
+                    double l = coor.greatCircleDistance(lastNcoor);
+                    if (l > length) {
+                        length = l;
+                    }
+                }
+            }
+            lastN = n;
+        }
+        return length;
+    }
+
+    /**
      * Tests if this way is a oneway.
      * @return {@code 1} if the way is a oneway,

trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java

@@ -40 +40 @@
 import org.openstreetmap.josm.data.validation.tests.InternetTags;
 import org.openstreetmap.josm.data.validation.tests.Lanes;
+import org.openstreetmap.josm.data.validation.tests.LongSegment;
 import org.openstreetmap.josm.data.validation.tests.MapCSSTagChecker;
 import org.openstreetmap.josm.data.validation.tests.MultipolygonTest;
@@ -125 +126 @@
         InternetTags.class, // 3300 .. 3399
         ApiCapabilitiesTest.class, // 3400 .. 3499
+        LongSegment.class, // 3500 .. 3599
     };