Changeset 8081 in josm

Timestamp:

2015-02-17T23:11:29+01:00 (10 years ago)

Author:

Don-vip

Message:

fix #10882 - fix focus issues properly

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• MainMenu.java (modified) (8 diffs)
• dialogs/ToggleDialog.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/MainMenu.java

@@ -7 +7 @@
 
 import java.awt.Component;
+import java.awt.DefaultFocusTraversalPolicy;
 import java.awt.Dimension;
 import java.awt.GraphicsEnvironment;
@@ -20 +21 @@
 import javax.swing.Box;
 import javax.swing.JCheckBoxMenuItem;
-import javax.swing.JComponent;
 import javax.swing.JMenu;
 import javax.swing.JMenuBar;
@@ -797 +797 @@
         add(helpMenu, about);
         add(Box.createHorizontalGlue());
-        add(createSearchField());
+        final DisableShortcutsOnFocusGainedTextField searchField = createSearchField();
+        add(searchField);
+
+        // Do not let search field take the focus automatically
+        setFocusTraversalPolicyProvider(true);
+        setFocusTraversalPolicy(new DefaultFocusTraversalPolicy() {
+            @Override
+            protected boolean accept(Component aComponent) {
+                return super.accept(aComponent) && !searchField.equals(aComponent);
+            }
+        });
 
         windowMenu.addMenuListener(menuSeparatorHandler);
@@ -818 +828 @@
      * Create search field.
      */
-    private JComponent createSearchField() {
+    private DisableShortcutsOnFocusGainedTextField createSearchField() {
         DisableShortcutsOnFocusGainedTextField searchField = new DisableShortcutsOnFocusGainedTextField() {
             @Override
@@ -996 +1006 @@
             currentSearchText = searchTerm;
             if (searchTerm.length() == 0) {
-                //No text to search
+                // No text to search
                 hideMenu();
                 return;
@@ -1003 +1013 @@
             List<JMenuItem> searchResult = mainMenu.findMenuItems(currentSearchText);
             if(searchResult.size() == 0) {
-                //Nothing found
+                // Nothing found
                 hideMenu();
                 return;
@@ -1009 +1019 @@
 
             if(searchResult.size() > 20) {
-                //Too many items found...
+                // Too many items found...
                 searchResult = searchResult.subList(0, 20);
             }
 
-            //Update Popup menu
+            // Update Popup menu
             searchResultsMenu.removeAll();
             for (JMenuItem foundItem : searchResult) {
                 searchResultsMenu.add(foundItem.getText()).setAction(foundItem.getAction());
             }
+            // Put menu right under search field
             searchResultsMenu.pack();
-            searchResultsMenu.show(mainMenu, searchField.getX(), searchField.getY() + searchField.getHeight()); //Put menu right under search field
-
-            searchField.grabFocus(); //This is tricky. User still is able to edit search text. While Up and Down keys are handled by Popup Menu.
+            searchResultsMenu.show(mainMenu, searchField.getX(), searchField.getY() + searchField.getHeight());
+
+            // This is tricky. User still is able to edit search text. While Up and Down keys are handled by Popup Menu.
+            searchField.requestFocusInWindow();
         }
 
@@ -1027 +1039 @@
             searchResultsMenu.setVisible(false);
         }
-
     }
 }

trunk/src/org/openstreetmap/josm/gui/dialogs/ToggleDialog.java

@@ -587 +587 @@
                             dialogsPanel.reconstruct(Action.ELEMENT_SHRINKS, null);
                             hideNotify();
-                            if (Main.map != null) {
-                                // To avoid menu bar search field from taking focus when a toggle dialog is closed
-                                Main.map.requestFocusInWindow();
-                            }
                         }
                     }