Changeset 7975 in josm

Timestamp:

2015-01-19T22:54:26+01:00 (8 years ago)

Author:

Klumbumbus

Message:

see #10835 - icon unification and geometry consistency for some water related tags. add validator warnings

Location:

trunk

Files:

• data/defaultpresets.xml (modified) (3 diffs)
• data/validator/geometry.mapcss (modified) (3 diffs)
• images_nodist/presets/marina.png (moved) (moved from trunk/images/presets/marina.png)
• styles/standard/elemstyles.mapcss (modified) (4 diffs)

trunk/data/defaultpresets.xml

@@ -1718 +1718 @@
             <reference ref="name_wikipedia" />
         </item> <!-- Dam -->
-        <item name="Groyne" icon="presets/groyne.png" type="node,way,closedway" preset_name_label="true">
+        <item name="Groyne" icon="presets/groyne.png" type="way,closedway" preset_name_label="true">
             <link href="http://wiki.openstreetmap.org/wiki/Tag:man_made=groyne"
                   de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:man_made=groyne"
@@ -1929 +1929 @@
         </item> <!-- Ferry Route -->
         <separator/>
-        <item name="Marina" icon="presets/marina.png" type="node,closedway" preset_name_label="true">
+        <item name="Marina" icon="styles/standard/nautical/marina.png" type="node,closedway" preset_name_label="true">
             <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=marina"
                   de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=marina"
@@ -1941 +1941 @@
             <text key="name" text="Name" />
         </item> <!-- Marina -->
-        <item name="Pier" icon="presets/pier.png" type="way,closedway" preset_name_label="true">
+        <item name="Pier" icon="presets/pier.png" type="node,way,closedway" preset_name_label="true">
             <link href="http://wiki.openstreetmap.org/wiki/Tag:man_made=pier"
                   de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:man_made=pier"

trunk/data/validator/geometry.mapcss

@@ -5 +5 @@
 node[footway],
 node[man_made=embankment],
+node[man_made=groyne],
 node[aerialway=cable_car],
 node[aerialway=gondola],
@@ -17 +18 @@
 node[aerialway=goods],
 node[waterway=river],
-node[waterway=riverbank],
 node[waterway=canal],
 node[waterway=wadi],
 node[waterway=stream],
 node[waterway=ditch],
+node[waterway=drain],
 node[natural=coastline],
 node[natural=ridge],
@@ -49 +50 @@
 node[waterway=riverbank],
 node[man_made=bridge],
+node[man_made=breakwater],
 node[power=plant],
 node[source:outline] {

trunk/styles/standard/elemstyles.mapcss

@@ -1279 +1279 @@
     color: manmade#d8d8d8;
 }
-node[man_made=groyne] {
-    icon-image: "nautical/groyne.png";
-    set icon_z17;
-    text: auto;
-}
 node[man_made=lighthouse] {
     icon-image: "misc/landmark/lighthouse.png";
@@ -1335 +1330 @@
     color: pipeline#660000;
 }
+node[man_made=breakwater],
+node[man_made=groyne],
 node[man_made=embankment],
 node[man_made=pipeline] {
@@ -1495 +1492 @@
     text: auto;
 }
-area[leisure=slipway],
+way[leisure=slipway] {
+    width: 2;
+    color: leisure#c7f1a3;
+}
+node[leisure=slipway] {
+    icon-image: "nautical/slipway.png";
+    set icon_z17;
+    text: auto;
+}
 area[leisure=fishing],
 area[leisure=nature_reserve],
@@ -1504 +1509 @@
 area[leisure=firepit] {
     fill-color: leisure#c7f1a3;
-}
-node[leisure=slipway] {
-    icon-image: "nautical/slipway.png";
-    set icon_z17;
-    text: auto;
 }
 node[leisure=fishing] {