Changeset 7933 in josm for trunk

Timestamp:

2015-01-07T01:45:32+01:00 (10 years ago)

Author:

Don-vip

Message:

fix #10927 - simple UI improvement for History dialog

File:

• trunk/src/org/openstreetmap/josm/gui/history/VersionTable.java (modified) (8 diffs)

trunk/src/org/openstreetmap/josm/gui/history/VersionTable.java

@@ -42 +42 @@
  * VersionTable shows a list of version in a {@link org.openstreetmap.josm.data.osm.history.History}
  * of an {@link org.openstreetmap.josm.data.osm.OsmPrimitive}.
- *
+ * @since 1709
  */
 public class VersionTable extends JTable implements Observer{
@@ -93 +93 @@
     }
 
+    /**
+     * Constructs a new {@code VersionTable}.
+     * @param model model used by the history browser
+     */
     public VersionTable(HistoryBrowserModel model) {
         super(model.getVersionTableModel(), new VersionTableColumnModel());
@@ -117 +121 @@
 
     class MouseListener extends PopupMenuLauncher {
-        public MouseListener() {
+        private MouseListener() {
             super(popupMenu);
         }
@@ -126 +130 @@
                 int row = rowAtPoint(e.getPoint());
                 int col = columnAtPoint(e.getPoint());
-                if (row > 0 && (col == VersionTableColumnModel.COL_DATE || col == VersionTableColumnModel.COL_USER)) {
+                if (row >= 0 && (col == VersionTableColumnModel.COL_DATE || col == VersionTableColumnModel.COL_USER)) {
                     model.getVersionTableModel().setCurrentPointInTime(row);
-                    model.getVersionTableModel().setReferencePointInTime(row - 1);
+                    model.getVersionTableModel().setReferencePointInTime(Math.max(0, row - 1));
                 }
             }
@@ -231 +235 @@
 
         @Override
-        public Component getTableCellRendererComponent(JTable table, Object value, boolean isSelected, boolean hasFocus,int row,int column) {
+        public Component getTableCellRendererComponent(JTable table, Object value, boolean isSelected, boolean hasFocus,
+                int row, int column) {
             setSelected(value != null && (Boolean)value);
             setHorizontalAlignment(SwingConstants.CENTER);
@@ -242 +247 @@
         private JRadioButton btn;
 
+        /**
+         * Constructs a new {@code RadioButtonEditor}.
+         */
         public RadioButtonEditor() {
             super(new JCheckBox());
@@ -270 +278 @@
 
     public static class AlignedRenderer extends JLabel implements TableCellRenderer {
+
+        /**
+         * Constructs a new {@code AlignedRenderer}.
+         * @param hAlignment Horizontal alignement. One of the following constants defined in SwingConstants:
+         *        LEFT, CENTER (the default for image-only labels), RIGHT, LEADING (the default for text-only labels) or TRAILING
+         */
         public AlignedRenderer(int hAlignment) {
             setHorizontalAlignment(hAlignment);
         }
-        @Override
-        public Component getTableCellRendererComponent(JTable table, Object value, boolean isSelected, boolean hasFocus,int row,int column) {
+
+        @Override
+        public Component getTableCellRendererComponent(JTable table, Object value, boolean isSelected, boolean hasFocus,
+                int row, int column) {
             String v = value.toString();
             setText(v);
@@ -298 +314 @@
         tbl.getColumnModel().getColumn(col).setPreferredWidth(maxwidth + spacing);
     }
-
 }