Changeset 6977 in josm for trunk/src/org/openstreetmap/josm/actions

Timestamp:

2014-04-15T00:43:24+02:00 (11 years ago)

Author:

Don-vip

Message:

fix some sonar issues recently introduced

Location:

trunk/src/org/openstreetmap/josm/actions

Files:

• AddNodeAction.java (modified) (1 diff)
• AlignInLineAction.java (modified) (1 diff)
• CreateCircleAction.java (modified) (3 diffs)
• JoinAreasAction.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/AddNodeAction.java

@@ -23 +23 @@
     private String textLatLon, textEastNorth;
 
+    /**
+     * Constructs a new {@code AddNodeAction}.
+     */
     public AddNodeAction() {
         super(tr("Add Node..."), "addnode", tr("Add a node by entering latitude / longitude or easting / northing."),

trunk/src/org/openstreetmap/josm/actions/AlignInLineAction.java

@@ -257 +257 @@
             for(int i = 1; i < nodes.size()-1; i++)
                 if(nodes.get(i) == node) {
-                    System.out.printf("Find 2 neighbors\n");
                     neighbors.add(nodes.get(i-1));
                     neighbors.add(nodes.get(i+1));
-                    //lines.add(new Line(nodes.get(i-1), nodes.get(i+1)));
                 }
             if(neighbors.size() == 0)

trunk/src/org/openstreetmap/josm/actions/CreateCircleAction.java

@@ -97 +97 @@
      * Class designed to create a couple between a node and its angle relative to the center of the circle.
      */
-    private class PolarNode {
+    private static class PolarNode {
         double a;
         Node node;
@@ -111 +111 @@
      * Comparator used to order PolarNode relative to their angle.
      */
-    private class PolarNodeComparator implements Comparator<PolarNode> {
+    private static class PolarNodeComparator implements Comparator<PolarNode> {
 
         @Override
@@ -186 +186 @@
             double yc = 0.5 * (y1 + y2);
             center = new EastNorth(xc, yc);
-        } else if (nodes.size() == 3) {
+        } else {
             // triangle: three single nodes needed or a way with three nodes
             center = Geometry.getCenter(nodes);

trunk/src/org/openstreetmap/josm/actions/JoinAreasAction.java

@@ -54 +54 @@
     private final LinkedList<Command> cmds = new LinkedList<Command>();
     private int cmdsCount = 0;
-    private final LinkedList<Relation> addedRelations = new LinkedList<Relation>();
+    private final List<Relation> addedRelations = new LinkedList<Relation>();
 
     /**