Changeset 6981 in josm for trunk/src/org/openstreetmap/josm/actions

Timestamp:

2014-04-15T13:56:36+02:00 (10 years ago)

Author:

Don-vip

Message:

fix some sonar issues

Location:

trunk/src/org/openstreetmap/josm/actions

Files:

• SessionSaveAsAction.java (modified) (2 diffs)
• ShowStatusReportAction.java (modified) (2 diffs)
• SimplifyWayAction.java (modified) (2 diffs)
• UnGlueAction.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/SessionSaveAsAction.java

@@ -100 +100 @@
         if (zipRequired) {
             zip = true;
-        } else if (ff == joz) {
+        } else if (joz.equals(ff)) {
             zip = true;
-        } else if (ff == jos) {
+        } else if (jos.equals(ff)) {
             zip = false;
         } else {
@@ -231 +231 @@
         }
 
-        protected Component getDisabledExportPanel(Layer layer) {
+        protected final Component getDisabledExportPanel(Layer layer) {
             JPanel p = new JPanel(new GridBagLayout());
             JCheckBox include = new JCheckBox();

trunk/src/org/openstreetmap/josm/actions/ShowStatusReportAction.java

@@ -104 +104 @@
         }
         try {
-            final String env_java_home = System.getenv("JAVA_HOME");
-            final String env_java_home_alt = Main.platform instanceof PlatformHookWindows ? "%JAVA_HOME%" : "${JAVA_HOME}";
-            final String prop_java_home = System.getProperty("java.home");
-            final String prop_java_home_alt = "<java.home>";
+            final String envJavaHome = System.getenv("JAVA_HOME");
+            final String envJavaHomeAlt = Main.platform instanceof PlatformHookWindows ? "%JAVA_HOME%" : "${JAVA_HOME}";
+            final String propJavaHome = System.getProperty("java.home");
+            final String propJavaHomeAlt = "<java.home>";
             // Build a new list of VM parameters to modify it below if needed (default implementation returns an UnmodifiableList instance)
             List<String> vmArguments = new ArrayList<String>(ManagementFactory.getRuntimeMXBean().getInputArguments());
@@ -119 +119 @@
                     // Shorten some parameters for readability concerns
                     } else {
-                        shortenParam(it, param, env_java_home, env_java_home_alt);
-                        shortenParam(it, param, prop_java_home, prop_java_home_alt);
+                        shortenParam(it, param, envJavaHome, envJavaHomeAlt);
+                        shortenParam(it, param, propJavaHome, propJavaHomeAlt);
                     }
                 }

trunk/src/org/openstreetmap/josm/actions/SimplifyWayAction.java

@@ -96 +96 @@
         DataSet ds = getCurrentDataSet();
         ds.beginUpdate();
-        try
-        {
+        try {
             List<Way> ways = OsmPrimitive.getFilteredList(ds.getSelected(), Way.class);
             if (ways.isEmpty()) {
                 alertSelectAtLeastOneWay();
                 return;
-            } else if (!confirmWayWithNodesOutsideBoundingBox(ways))
+            } else if (!confirmWayWithNodesOutsideBoundingBox(ways)) {
                 return;
-            else if (ways.size() > 10) {
-                if (!confirmSimplifyManyWays(ways.size()))
-                    return;
+            } else if (ways.size() > 10 && !confirmSimplifyManyWays(ways.size())) {
+                return;
             }
 
@@ -269 +267 @@
 
     public static double xtd(double lat1, double lon1, double lat2, double lon2, double lat3, double lon3) {
-        double dist_AD = dist(lat1, lon1, lat3, lon3);
-        double crs_AD = course(lat1, lon1, lat3, lon3);
-        double crs_AB = course(lat1, lon1, lat2, lon2);
-        return Math.asin(Math.sin(dist_AD) * Math.sin(crs_AD - crs_AB));
+        double distAD = dist(lat1, lon1, lat3, lon3);
+        double crsAD = course(lat1, lon1, lat3, lon3);
+        double crsAB = course(lat1, lon1, lat2, lon2);
+        return Math.asin(Math.sin(distAD) * Math.sin(crsAD - crsAB));
     }
 

trunk/src/org/openstreetmap/josm/actions/UnGlueAction.java

@@ -334 +334 @@
             rolesToReAdd = null;
             for (RelationMember rm : r.getMembers()) {
-                if (rm.isNode()) {
-                    if (rm.getMember() == originalNode) {
-                        if (newRel == null) {
-                            newRel = new Relation(r);
-                            rolesToReAdd = new HashSet<String>();
-                        }
-                        rolesToReAdd.add(rm.getRole());
+                if (rm.isNode() && rm.getMember() == originalNode) {
+                    if (newRel == null) {
+                        newRel = new Relation(r);
+                        rolesToReAdd = new HashSet<String>();
                     }
+                    rolesToReAdd.add(rm.getRole());
                 }
             }