Changeset 6890 in josm for trunk/src/org/openstreetmap/josm/plugins

Timestamp:

2014-02-27T02:50:12+01:00 (9 years ago)

Author:

Don-vip

Message:

fix some Sonar issues (Constructor Calls Overridable Method)

Location:

trunk/src/org/openstreetmap/josm/plugins

Files:

• PluginHandler.java (modified) (1 diff)
• PluginInformation.java (modified) (2 diffs)
• ReadRemotePluginInformationTask.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java

@@ -1326 +1326 @@
         private JCheckBox cbDontShowAgain;
 
-        protected void build() {
+        protected final void build() {
             setLayout(new GridBagLayout());
             GridBagConstraints gc = new GridBagConstraints();

trunk/src/org/openstreetmap/josm/plugins/PluginInformation.java

@@ -192 +192 @@
     }
 
-    private void scanManifest(Manifest manifest, boolean oldcheck) {
+    private final void scanManifest(Manifest manifest, boolean oldcheck) {
         String lang = LanguageInfo.getLanguageCodeManifest();
         Attributes attr = manifest.getMainAttributes();
@@ -500 +500 @@
 
     @Override
-    public String toString() {
+    public final String toString() {
         return getName();
     }

trunk/src/org/openstreetmap/josm/plugins/ReadRemotePluginInformationTask.java

@@ -59 +59 @@
     protected enum CacheType {PLUGIN_LIST, ICON_LIST}
 
-    protected void init(Collection<String> sites, boolean displayErrMsg){
+    protected final void init(Collection<String> sites, boolean displayErrMsg){
         this.sites = sites;
         if (sites == null) {
@@ -88 +88 @@
         init(sites, displayErrMsg);
     }
-
 
     @Override