Changeset 6890 in josm


Ignore:
Timestamp:
2014-02-27T02:50:12+01:00 (6 years ago)
Author:
Don-vip
Message:

fix some Sonar issues (Constructor Calls Overridable Method)

Location:
trunk/src/org/openstreetmap/josm
Files:
109 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/org/openstreetmap/josm/actions/AutoScaleAction.java

    r6783 r6890  
    284284
    285285    @Override
    286     protected void installAdapters() {
     286    protected final void installAdapters() {
    287287        super.installAdapters();
    288288        // make this action listen to zoom and mapframe change events
  • trunk/src/org/openstreetmap/josm/actions/ExpertToggleAction.java

    r6889 r6890  
    134134
    135135    @Override
    136     protected void notifySelectedState() {
     136    protected final void notifySelectedState() {
    137137        super.notifySelectedState();
    138138        fireExpertModeChanged(isSelected());
  • trunk/src/org/openstreetmap/josm/actions/ImageryAdjustAction.java

    r6792 r6890  
    226226        }
    227227
    228         public void updateOffset() {
     228        public final void updateOffset() {
    229229            ignoreListener = true;
    230230            updateOffsetIntl();
     
    232232        }
    233233
    234         public void updateOffsetIntl() {
     234        public final void updateOffsetIntl() {
    235235            // Support projections with very small numbers (e.g. 4326)
    236236            int precision = Main.getProjection().getDefaultZoomInPPD() >= 1.0 ? 2 : 7;
  • trunk/src/org/openstreetmap/josm/actions/JosmAction.java

    r6889 r6890  
    193193     * @param tooltip The text to display in tooltip. Can be {@code null}
    194194     */
    195     public void setTooltip(String tooltip) {
     195    public final void setTooltip(String tooltip) {
    196196        if (tooltip != null) {
    197197            putValue(SHORT_DESCRIPTION, Main.platform.makeTooltip(tooltip, sc));
  • trunk/src/org/openstreetmap/josm/actions/OpenLocationAction.java

    r6803 r6890  
    205205     * @return <tt>true</tt> (as specified by {@link Collection#add})
    206206     */
    207     public boolean addDownloadTaskClass(Class<? extends DownloadTask> taskClass) {
     207    public final boolean addDownloadTaskClass(Class<? extends DownloadTask> taskClass) {
    208208        return this.downloadTasks.add(taskClass);
    209209    }
  • trunk/src/org/openstreetmap/josm/actions/SessionSaveAsAction.java

    r6643 r6890  
    166166         * Initializes action.
    167167         */
    168         public void initialize() {
     168        public final void initialize() {
    169169            layers = new ArrayList<Layer>(Main.map.mapView.getAllLayersAsList());
    170170            exporters = new HashMap<Layer, SessionLayerExporter>();
     
    205205        }
    206206
    207         protected Component build() {
     207        protected final Component build() {
    208208            JPanel p = new JPanel(new GridBagLayout());
    209209            JPanel ip = new JPanel(new GridBagLayout());
  • trunk/src/org/openstreetmap/josm/actions/ZoomToAction.java

    r6085 r6890  
    7777    }
    7878
    79     protected void updateEnabledState() {
     79    protected final void updateEnabledState() {
    8080        if (Main.main == null || Main.main.getEditLayer() != this.table.getLayer()) {
    8181            setEnabled(false);
  • trunk/src/org/openstreetmap/josm/command/MoveCommand.java

    r6881 r6890  
    153153     * Save curent displacement to restore in case of some problems
    154154     */
    155     public void saveCheckpoint() {
     155    public final void saveCheckpoint() {
    156156        backupX = x;
    157157        backupY = y;
  • trunk/src/org/openstreetmap/josm/command/PurgeCommand.java

    r6883 r6890  
    6767    }
    6868
    69     protected void saveIncomplete(Collection<OsmPrimitive> makeIncomplete) {
     69    protected final void saveIncomplete(Collection<OsmPrimitive> makeIncomplete) {
    7070        makeIncompleteData = new Storage<PrimitiveData>(new Storage.PrimitiveIdHash());
    7171        makeIncompleteData_byPrimId = makeIncompleteData.foreignKey(new Storage.PrimitiveIdHash());
  • trunk/src/org/openstreetmap/josm/command/RotateCommand.java

    r6830 r6890  
    5252     * Get angle between the horizontal axis and the line formed by the pivot and give points.
    5353     **/
    54     protected double getAngle(EastNorth currentEN) {
     54    protected final double getAngle(EastNorth currentEN) {
    5555        if ( pivot == null )
    5656            return 0.0; // should never happen by contract
     
    6262     */
    6363    @Override
    64     public void handleEvent(EastNorth currentEN) {
     64    public final void handleEvent(EastNorth currentEN) {
    6565        double currentAngle = getAngle(currentEN);
    6666        rotationAngle = currentAngle - startAngle;
  • trunk/src/org/openstreetmap/josm/command/ScaleCommand.java

    r6296 r6890  
    5454     */
    5555    @Override
    56     public void handleEvent(EastNorth currentEN) {
     56    public final void handleEvent(EastNorth currentEN) {
    5757        double startAngle = Math.atan2(startEN.east()-pivot.east(), startEN.north()-pivot.north());
    5858        double endAngle = Math.atan2(currentEN.east()-pivot.east(), currentEN.north()-pivot.north());
     
    6262        transformNodes();
    6363    }
    64 
    6564
    6665    /**
  • trunk/src/org/openstreetmap/josm/command/TransformNodesCommand.java

    r6830 r6890  
    3838     * Stores the state of the nodes before the command.
    3939     */
    40     protected void storeOldState() {
     40    protected final void storeOldState() {
    4141        for (Node n : this.nodes) {
    4242            oldStates.put(n, new OldNodeState(n));
  • trunk/src/org/openstreetmap/josm/data/APIDataSet.java

    r6801 r6890  
    5959    }
    6060
    61     public void init(Collection<OsmPrimitive> primitives) {
     61    public final void init(Collection<OsmPrimitive> primitives) {
    6262        toAdd.clear();
    6363        toUpdate.clear();
     
    286286        }
    287287
    288         public void build(Collection<Relation> relations) {
     288        public final void build(Collection<Relation> relations) {
    289289            this.relations = new HashSet<Relation>();
    290290            for(Relation relation: relations) {
  • trunk/src/org/openstreetmap/josm/data/osm/BBox.java

    r6204 r6890  
    107107    }
    108108
    109     public void add(LatLon c) {
     109    public final void add(LatLon c) {
    110110        add(c.lon(), c.lat());
    111111    }
     
    114114     * Extends this bbox to include the point (x, y)
    115115     */
    116     public void add(double x, double y) {
     116    public final void add(double x, double y) {
    117117        xmin = Math.min(xmin, x);
    118118        xmax = Math.max(xmax, x);
     
    122122    }
    123123
    124     public void add(BBox box) {
     124    public final void add(BBox box) {
    125125        xmin = Math.min(xmin, box.xmin);
    126126        xmax = Math.max(xmax, box.xmax);
  • trunk/src/org/openstreetmap/josm/data/osm/NodeData.java

    r6009 r6890  
    3232
    3333    @Override
    34     public void setCoor(LatLon coor) {
     34    public final void setCoor(LatLon coor) {
    3535        if (coor == null) {
    3636            this.lat = Double.NaN;
  • trunk/src/org/openstreetmap/josm/data/osm/OsmPrimitive.java

    r6889 r6890  
    570570
    571571    @Override
    572     protected void setIncomplete(boolean incomplete) {
     572    protected final void setIncomplete(boolean incomplete) {
    573573        boolean locked = writeLock();
    574574        try {
  • trunk/src/org/openstreetmap/josm/data/osm/PrimitiveDeepCopy.java

    r6084 r6890  
    7676            }
    7777
    78             public void visitAll() {
     78            public final void visitAll() {
    7979                for (OsmPrimitive osm : primitives) {
    8080                    firstIteration = true;
  • trunk/src/org/openstreetmap/josm/data/osm/QuadBuckets.java

    r6296 r6890  
    356356         * corner of the box
    357357         */
    358         LatLon coor() {
     358        final LatLon coor() {
    359359            return QuadTiling.tile2LatLon(this.quad);
    360360        }
     
    404404
    405405    @Override
    406     public void clear() {
     406    public final void clear() {
    407407        root = new QBLevel<T>(this);
    408408        search_cache = null;
     
    500500        int iterated_over;
    501501
    502         QBLevel<T> next_content_node(QBLevel<T> q) {
     502        final QBLevel<T> next_content_node(QBLevel<T> q) {
    503503            if (q == null)
    504504                return null;
  • trunk/src/org/openstreetmap/josm/data/osm/TagCollection.java

    r6823 r6890  
    193193     * @param tag the tag to add
    194194     */
    195     public void add(Tag tag){
     195    public final void add(Tag tag){
    196196        if (tag == null) return;
    197197        if (tags.contains(tag)) return;
     
    205205     * @param tags the collection of tags
    206206     */
    207     public void add(Collection<Tag> tags) {
     207    public final void add(Collection<Tag> tags) {
    208208        if (tags == null) return;
    209209        for (Tag tag: tags){
     
    218218     * @param tags the other tag collection
    219219     */
    220     public void add(TagCollection tags) {
     220    public final void add(TagCollection tags) {
    221221        if (tags == null) return;
    222222        this.tags.addAll(tags.tags);
  • trunk/src/org/openstreetmap/josm/data/osm/history/HistoryNode.java

    r6830 r6890  
    7373     * @return the coordinates. May be null.
    7474     */
    75     public LatLon getCoords() {
     75    public final LatLon getCoords() {
    7676        return coords;
    7777    }
     
    8181     * @param coords the coordinates. Can be null.
    8282     */
    83     public void setCoords(LatLon coords) {
     83    public final void setCoords(LatLon coords) {
    8484        this.coords = coords;
    8585    }
  • trunk/src/org/openstreetmap/josm/data/osm/history/HistoryOsmPrimitive.java

    r6830 r6890  
    3838    private Map<String, String> tags;
    3939
    40     protected void ensurePositiveLong(long value, String name) {
     40    protected final void ensurePositiveLong(long value, String name) {
    4141        if (value <= 0) {
    4242            throw new IllegalArgumentException(MessageFormat.format("Parameter ''{0}'' > 0 expected. Got ''{1}''.", name, value));
  • trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/relations/Multipolygon.java

    r6883 r6890  
    359359    }
    360360
    361     private void load(Relation r) {
     361    private final void load(Relation r) {
    362362        MultipolygonRoleMatcher matcher = getMultipolygonRoleMatcher();
    363363
     
    537537    }
    538538
    539     private void addInnerToOuters()  {
     539    private final void addInnerToOuters()  {
    540540
    541541        if (innerPolygons.isEmpty()) {
  • trunk/src/org/openstreetmap/josm/data/preferences/CachedProperty.java

    r6069 r6890  
    1919    }
    2020
    21     protected void updateValue() {
     21    protected final void updateValue() {
    2222        if (!Main.pref.get(key).isEmpty()) {
    2323            this.value = fromString(Main.pref.get(key));
  • trunk/src/org/openstreetmap/josm/data/projection/CustomProjection.java

    r6883 r6890  
    119119    }
    120120
    121     public void update(String pref) throws ProjectionConfigurationException {
     121    public final void update(String pref) throws ProjectionConfigurationException {
    122122        this.pref = pref;
    123123        if (pref == null) {
  • trunk/src/org/openstreetmap/josm/data/projection/datum/NTV2GridShift.java

    r5817 r6890  
    4949    private String subGridName;
    5050
     51    /**
     52     * Constructs a new {@code NTV2GridShift}.
     53     */
    5154    public NTV2GridShift() {
    5255    }
     
    233236     * @param d latitude value in seconds
    234237     */
    235     public void setLatSeconds(double d) {
     238    public final void setLatSeconds(double d) {
    236239        lat = d;
    237240    }
     
    241244     * @param d latitude value in degree
    242245     */
    243     public void setLatDegrees(double d) {
     246    public final void setLatDegrees(double d) {
    244247        lat = d * 3600.0;
    245248    }
     
    249252     * @param b availability of latitude accuracy
    250253     */
    251     public void setLatAccuracyAvailable(boolean b) {
     254    public final void setLatAccuracyAvailable(boolean b) {
    252255        latAccuracyAvailable = b;
    253256    }
     
    257260     * @param d latitude accuracy in seconds
    258261     */
    259     public void setLatAccuracySeconds(double d) {
     262    public final void setLatAccuracySeconds(double d) {
    260263        latAccuracy = d;
    261264    }
     
    265268     * @param d latitude shift in seconds
    266269     */
    267     public void setLatShiftSeconds(double d) {
     270    public final void setLatShiftSeconds(double d) {
    268271        latShift = d;
    269272    }
     
    273276     * @param d latitude value in seconds, west direction is positive
    274277     */
    275     public void setLonPositiveWestSeconds(double d) {
     278    public final void setLonPositiveWestSeconds(double d) {
    276279        lon = d;
    277280    }
     
    281284     * @param d latitude value in degree, est direction is positive
    282285     */
    283     public void setLonPositiveEastDegrees(double d) {
     286    public final void setLonPositiveEastDegrees(double d) {
    284287        lon = d * -3600.0;
    285288    }
     
    289292     * @param b availability of longitude accuracy
    290293     */
    291     public void setLonAccuracyAvailable(boolean b) {
     294    public final void setLonAccuracyAvailable(boolean b) {
    292295        lonAccuracyAvailable = b;
    293296    }
     
    297300     * @param d longitude accuracy in seconds
    298301     */
    299     public void setLonAccuracySeconds(double d) {
     302    public final void setLonAccuracySeconds(double d) {
    300303        lonAccuracy = d;
    301304    }
     
    305308     * @param d longitude shift in seconds, west direction is positive
    306309     */
    307     public void setLonShiftPositiveWestSeconds(double d) {
     310    public final void setLonShiftPositiveWestSeconds(double d) {
    308311        lonShift = d;
    309312    }
  • trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java

    r6852 r6890  
    284284     * until most bugs were discovered while keeping the processing time reasonable)
    285285     */
    286     public void initializeGridDetail() {
     286    public final void initializeGridDetail() {
    287287        String code = Main.getProjection().toCode();
    288288        if (Arrays.asList(ProjectionPreference.wgs84.allCodes()).contains(code)) {
  • trunk/src/org/openstreetmap/josm/gui/actionsupport/DeleteFromRelationConfirmationDialog.java

    r6883 r6890  
    9090    }
    9191
    92     protected void build() {
     92    protected final void build() {
    9393        model = new RelationMemberTableModel();
    9494        model.addTableModelListener(this);
     
    275275    private static class RelationMemberTableColumnModel extends DefaultTableColumnModel{
    276276
    277         protected void createColumns() {
     277        protected final void createColumns() {
    278278            TableColumn col = null;
    279279
  • trunk/src/org/openstreetmap/josm/gui/actionsupport/LogShowDialog.java

    r5927 r6890  
    2929    }
    3030
    31     protected JPanel build(String msg, String log) {
     31    protected final JPanel build(String msg, String log) {
    3232        JPanel p = new JPanel(new GridBagLayout());
    3333        JLabel lbl = new JLabel(msg);
  • trunk/src/org/openstreetmap/josm/gui/bbox/SlippyMapBBoxChooser.java

    r6793 r6890  
    226226    }
    227227
    228     public void setFileCacheEnabled(boolean enabled) {
     228    public final void setFileCacheEnabled(boolean enabled) {
    229229        if (enabled) {
    230230            setTileLoader(cachedLoader);
     
    234234    }
    235235
    236     public void setMaxTilesInMemory(int tiles) {
     236    public final void setMaxTilesInMemory(int tiles) {
    237237        ((MemoryTileCache) getTileCache()).setCacheSize(tiles);
    238238    }
    239 
    240239
    241240    /**
  • trunk/src/org/openstreetmap/josm/gui/bbox/TileSelectionBBoxChooser.java

    r6883 r6890  
    9696     * builds the UI
    9797     */
    98     protected void build() {
     98    protected final void build() {
    9999        setLayout(new GridBagLayout());
    100100
  • trunk/src/org/openstreetmap/josm/gui/conflict/pair/ConflictResolver.java

    r6887 r6890  
    8686     * loads the required icons
    8787     */
    88     protected void loadIcons() {
     88    protected final void loadIcons() {
    8989        mergeComplete = ImageProvider.get("dialogs", "valid.png" );
    9090        mergeIncomplete = ImageProvider.get("dialogs/conflict", "mergeincomplete.png" );
     
    9494     * builds the UI
    9595     */
    96     protected void build() {
     96    protected final void build() {
    9797        tabbedPane = new JTabbedPane();
    9898
  • trunk/src/org/openstreetmap/josm/gui/conflict/pair/ListMergeModel.java

    r6830 r6890  
    227227    }
    228228
    229     public void setFrozen(boolean isFrozen) {
     229    public final void setFrozen(boolean isFrozen) {
    230230        boolean oldValue = this.isFrozen;
    231231        this.isFrozen = isFrozen;
     
    233233    }
    234234
    235     public boolean isFrozen() {
     235    public final boolean isFrozen() {
    236236        return isFrozen;
    237237    }
  • trunk/src/org/openstreetmap/josm/gui/conflict/pair/ListMerger.java

    r6883 r6890  
    260260    }
    261261
    262     protected void build() {
     262    protected final void build() {
    263263        setLayout(new GridBagLayout());
    264264        GridBagConstraints gc = new GridBagConstraints();
  • trunk/src/org/openstreetmap/josm/gui/conflict/pair/nodes/NodeListColumnModel.java

    r5291 r6890  
    1010public class NodeListColumnModel extends DefaultTableColumnModel {
    1111
    12     protected void createColumns(TableCellRenderer renderer) {
     12    protected final void createColumns(TableCellRenderer renderer) {
    1313
    1414        TableColumn col = null;
  • trunk/src/org/openstreetmap/josm/gui/conflict/pair/properties/PropertiesMerger.java

    r6792 r6890  
    269269    }
    270270
    271     protected void build() {
     271    protected final void build() {
    272272        setLayout(new GridBagLayout());
    273273        buildHeaderRow();
     
    277277    }
    278278
     279    /**
     280     * Constructs a new {@code PropertiesMerger}.
     281     */
    279282    public PropertiesMerger() {
    280283        model = new PropertiesMergeModel();
  • trunk/src/org/openstreetmap/josm/gui/conflict/pair/relation/RelationMemberListColumnModel.java

    r5291 r6890  
    99public class RelationMemberListColumnModel extends DefaultTableColumnModel{
    1010
    11     protected void createColumns() {
     11    protected final void createColumns() {
    1212        TableColumn col = null;
    1313        RelationMemberTableCellRenderer renderer = new RelationMemberTableCellRenderer();
  • trunk/src/org/openstreetmap/josm/gui/conflict/pair/tags/TagMergeColumnModel.java

    r3083 r6890  
    1010public class TagMergeColumnModel extends DefaultTableColumnModel {
    1111
    12     protected void createColumns(TableCellRenderer renderer) {
     12    protected final void createColumns(TableCellRenderer renderer) {
    1313
    1414        TableColumn col = null;
  • trunk/src/org/openstreetmap/josm/gui/conflict/pair/tags/TagMerger.java

    r6666 r6890  
    108108     * build the user interface
    109109     */
    110     protected void build() {
     110    protected final void build() {
    111111        GridBagConstraints gc = new GridBagConstraints();
    112112        setLayout(new GridBagLayout());
  • trunk/src/org/openstreetmap/josm/gui/conflict/tags/CombinePrimitiveResolverDialog.java

    r6889 r6890  
    166166    }
    167167
    168     protected void build() {
     168    protected final void build() {
    169169        getContentPane().setLayout(new BorderLayout());
    170170        updateTitle();
     
    412412        }
    413413
    414         protected void updateEnabledState() {
     414        protected final void updateEnabledState() {
    415415            setEnabled(pnlTagConflictResolver.getModel().getNumConflicts() == 0
    416416                    && pnlRelationMemberConflictResolver.getModel().getNumConflicts() == 0);
  • trunk/src/org/openstreetmap/josm/gui/conflict/tags/MultiValueResolutionDecision.java

    r6792 r6890  
    6161     * Tries to find the best decision based on the current values.
    6262     */
    63     protected void autoDecide() {
     63    protected final void autoDecide() {
    6464        this.type = MultiValueDecisionType.UNDECIDED;
    6565        // exactly one empty value ? -> delete the tag
  • trunk/src/org/openstreetmap/josm/gui/conflict/tags/PasteTagsConflictResolverDialog.java

    r6889 r6890  
    7575    }
    7676
    77     protected void build() {
     77    protected final void build() {
    7878        setTitle(tr("Conflicts in pasted tags"));
    7979        allPrimitivesResolver = new TagConflictResolver();
  • trunk/src/org/openstreetmap/josm/gui/conflict/tags/RelationMemberConflictResolver.java

    r6699 r6890  
    4848    private JMultilineLabel lblHeader;
    4949
    50     protected void build() {
     50    protected final void build() {
    5151        setLayout(new GridBagLayout());
    5252        JPanel pnl = new JPanel();
  • trunk/src/org/openstreetmap/josm/gui/conflict/tags/RelationMemberConflictResolverTable.java

    r6524 r6890  
    2323    }
    2424
    25     protected void build() {
     25    protected final void build() {
    2626        setAutoResizeMode(JTable.AUTO_RESIZE_ALL_COLUMNS);
    2727        setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
  • trunk/src/org/openstreetmap/josm/gui/conflict/tags/TagConflictResolver.java

    r6616 r6890  
    8686    }
    8787
    88     protected void build() {
     88    protected final void build() {
    8989        setLayout(new BorderLayout());
    9090        add(buildInfoPanel(), BorderLayout.NORTH);
  • trunk/src/org/openstreetmap/josm/gui/conflict/tags/TagConflictResolverColumnModel.java

    r6616 r6890  
    99public class TagConflictResolverColumnModel extends DefaultTableColumnModel{
    1010
    11     protected void createColumns() {
     11    protected final void createColumns() {
    1212        TableColumn col = null;
    1313        MultiValueCellRenderer renderer = new MultiValueCellRenderer();
  • trunk/src/org/openstreetmap/josm/gui/conflict/tags/TagConflictResolverTable.java

    r6739 r6890  
    2323    }
    2424
    25     protected void build() {
     25    protected final void build() {
    2626        setAutoResizeMode(JTable.AUTO_RESIZE_ALL_COLUMNS);
    2727        setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
  • trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/query/AdvancedChangesetQueryPanel.java

    r6889 r6890  
    151151    }
    152152
    153     protected void build() {
     153    protected final void build() {
    154154        setLayout(new BorderLayout());
    155155        JScrollPane spQueryPanel = GuiHelper.embedInVerticalScrollPane(buildQueryPanel());
  • trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/query/BasicChangesetQueryPanel.java

    r6340 r6890  
    129129    }
    130130
    131     protected void build() {
     131    protected final void build() {
    132132        setLayout(new BorderLayout(0,5));
    133133        setBorder(BorderFactory.createEmptyBorder(5,5,5,5));
     
    136136    }
    137137
     138    /**
     139     * Constructs a new {@code BasicChangesetQueryPanel}.
     140     */
    138141    public BasicChangesetQueryPanel() {
    139142        build();
  • trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/query/ChangesetQueryDialog.java

    r6084 r6890  
    7878    }
    7979
    80 
    81     protected void build() {
     80    protected final void build() {
    8281        setTitle(tr("Query changesets"));
    8382        Container cp = getContentPane();
     
    9594        addWindowListener(new WindowEventHandler());
    9695    }
    97 
    9896
    9997    public ChangesetQueryDialog(Dialog parent) {
  • trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/query/UrlBasedQueryPanel.java

    r6814 r6890  
    9393    }
    9494
    95     protected void build() {
     95    protected final void build() {
    9696        setLayout(new GridBagLayout());
    9797        setBorder(BorderFactory.createEmptyBorder(5,5,5,5));
     
    113113        gc.fill = GridBagConstraints.BOTH;
    114114        add(new JPanel(),gc);
    115 
    116     }
     115    }
     116
     117    /**
     118     * Constructs a new {@code UrlBasedQueryPanel}.
     119     */
    117120    public UrlBasedQueryPanel() {
    118121        build();
  • trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java

    r6794 r6890  
    942942
    943943        @Override
    944         protected void updateEnabledState() {
     944        protected final void updateEnabledState() {
    945945            setEnabled(
    946946                    (tagTable != null && tagTable.getSelectedRowCount() >= 1)
  • trunk/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java

    r6808 r6890  
    742742         * Read tags from comboboxes and add it to all selected objects
    743743         */
    744         public void performTagAdding() {
     744        public final void performTagAdding() {
    745745            String key = Tag.removeWhiteSpaces(keys.getEditor().getItem().toString());
    746746            String value = Tag.removeWhiteSpaces(values.getEditor().getItem().toString());
  • trunk/src/org/openstreetmap/josm/gui/dialogs/validator/ValidatorTreePanel.java

    r6706 r6890  
    292292     * @param errors The error list that is used by a data layer
    293293     */
    294     public void setErrorList(List<TestError> errors) {
     294    public final void setErrorList(List<TestError> errors) {
    295295        this.errors = errors;
    296296        if (isVisible()) {
  • trunk/src/org/openstreetmap/josm/gui/download/BookmarkSelection.java

    r6883 r6890  
    224224            bookmarks.save();
    225225        }
    226         protected void updateEnabledState() {
     226
     227        protected final void updateEnabledState() {
    227228            setEnabled(bookmarks.getSelectedIndices().length > 0);
    228229        }
     
    261262            }
    262263        }
    263         protected void updateEnabledState() {
     264
     265        protected final void updateEnabledState() {
    264266            setEnabled(bookmarks.getSelectedIndices().length == 1);
    265267        }
     268
    266269        @Override
    267270        public void valueChanged(ListSelectionEvent e) {
  • trunk/src/org/openstreetmap/josm/gui/download/DownloadDialog.java

    r6883 r6890  
    8686    }
    8787
    88     protected JPanel buildMainPanel() {
     88    protected final JPanel buildMainPanel() {
    8989        JPanel pnl = new JPanel();
    9090        pnl.setLayout(new GridBagLayout());
     
    163163    }
    164164
    165     protected JPanel buildButtonPanel() {
     165    protected final JPanel buildButtonPanel() {
    166166        JPanel pnl = new JPanel();
    167167        pnl.setLayout(new FlowLayout());
  • trunk/src/org/openstreetmap/josm/gui/download/PlaceSelection.java

    r6883 r6890  
    299299        }
    300300
    301         protected void updateEnabledState() {
     301        protected final void updateEnabledState() {
    302302            setEnabled(cbSearchExpression.getText().trim().length() > 0);
    303303        }
     
    427427        TableColumn col3 = null;
    428428        TableColumn col4 = null;
    429         protected void createColumns() {
     429        protected final void createColumns() {
    430430            TableColumn col = null;
    431431            NamedResultCellRenderer renderer = new NamedResultCellRenderer();
  • trunk/src/org/openstreetmap/josm/gui/download/TileSelection.java

    r6830 r6890  
    2222    private DownloadDialog parent;
    2323
    24     protected void build() {
     24    protected final void build() {
    2525        chooser = new TileSelectionBBoxChooser();
    2626        chooser.addPropertyChangeListener(this);
  • trunk/src/org/openstreetmap/josm/gui/help/HelpBrowser.java

    r6883 r6890  
    170170    }
    171171
    172     protected void build() {
     172    protected final void build() {
    173173        help = new JosmEditorPane();
    174174        JosmHTMLEditorKit kit = new JosmHTMLEditorKit();
  • trunk/src/org/openstreetmap/josm/gui/layer/Layer.java

    r6889 r6890  
    231231     *
    232232     */
    233     public void setName(String name) {
     233    public final void setName(String name) {
    234234        if (name == null) {
    235235            name = "";
  • trunk/src/org/openstreetmap/josm/gui/layer/TMSLayer.java

    r6889 r6890  
    452452    }
    453453
    454     private int getBestZoom() {
     454    private final int getBestZoom() {
    455455        double factor = getScaleFactor(1);
    456456        double result = Math.log(factor)/Math.log(2)/2+1;
     
    15021502
    15031503    @Override
    1504     public boolean isProjectionSupported(Projection proj) {
     1504    public final boolean isProjectionSupported(Projection proj) {
    15051505        return "EPSG:3857".equals(proj.toCode()) || "EPSG:4326".equals(proj.toCode());
    15061506    }
    15071507
    15081508    @Override
    1509     public String nameSupportedProjections() {
     1509    public final String nameSupportedProjections() {
    15101510        return tr("EPSG:4326 and Mercator projection are supported");
    15111511    }
  • trunk/src/org/openstreetmap/josm/gui/layer/WMSLayer.java

    r6830 r6890  
    269269    }
    270270
    271     public void initializeImages() {
     271    public final void initializeImages() {
    272272        GeorefImage[][] old = images;
    273273        images = new GeorefImage[dax][day];
  • trunk/src/org/openstreetmap/josm/gui/layer/gpx/DateFilterPanel.java

    r5926 r6890  
    129129
    130130    @Override
    131     public void setEnabled(boolean enabled) {
     131    public final void setEnabled(boolean enabled) {
    132132        super.setEnabled(enabled);
    133133        for (Component c: getComponents()) {
     
    135135        }
    136136    }
    137    
    138    
    139    
    140  
    141137}
  • trunk/src/org/openstreetmap/josm/gui/mappaint/LabelCompositionStrategy.java

    r6889 r6890  
    246246         * <tt>mappaint.nameOrder</tt> and <tt>mappaint.nameComplementOrder</tt>.
    247247         */
    248         public void initNameTagsFromPreferences() {
     248        public final void initNameTagsFromPreferences() {
    249249            if (Main.pref == null){
    250250                this.nameTags = new ArrayList<String>(Arrays.asList(DEFAULT_NAME_TAGS));
  • trunk/src/org/openstreetmap/josm/gui/mappaint/xml/AreaPrototype.java

    r6561 r6890  
    2020    public AreaPrototype() { init(); }
    2121
    22     public void init()
    23     {
     22    public final void init() {
    2423        priority = 0;
    2524        range = Range.ZERO_TO_INFINITY;
  • trunk/src/org/openstreetmap/josm/gui/mappaint/xml/IconPrototype.java

    r6561 r6890  
    2020    public IconPrototype() { init(); }
    2121
    22     public void init() {
     22    public final void init() {
    2323        priority = 0;
    2424        range = Range.ZERO_TO_INFINITY;
  • trunk/src/org/openstreetmap/josm/gui/mappaint/xml/LinemodPrototype.java

    r3836 r6890  
    2020
    2121    @Override
    22     public void init()
    23     {
     22    public final void init() {
    2423        super.init();
    2524        over = true;
     
    2726    }
    2827
    29     // get width for overlays
    30     public float getWidth(float ref)
    31     {
     28    /** get width for overlays */
     29    public float getWidth(float ref) {
    3230        float res;
    3331        if(widthMode == WidthMode.ABSOLUTE) {
  • trunk/src/org/openstreetmap/josm/gui/mappaint/xml/XmlCondition.java

    r6821 r6890  
    1010    public String boolValue;
    1111
    12     public XmlCondition()
    13     {
     12    public XmlCondition() {
    1413      init();
    1514    }
    16     public XmlCondition(XmlCondition c)
    17     {
     15
     16    public XmlCondition(XmlCondition c) {
    1817      key = c.key;
    1918      value = c.value;
    2019      boolValue = c.boolValue;
    2120    }
    22     public String getKey()
    23     {
     21
     22    public String getKey() {
    2423        if(value != null)
    2524            return "n" + key + "=" + value;
     
    2928            return "x" + key;
    3029    }
    31     public void init()
    32     {
     30
     31    public final void init() {
    3332      key = value = boolValue = null;
    3433    }
    3534
    36     public String toString()
    37     {
     35    public String toString() {
    3836      return "Rule["+key+","+(boolValue != null ? "b="+boolValue:"v="+value)+"]";
    3937    }
    4038
    41     public void appendCode(StringBuilder sb)
    42     {
     39    public void appendCode(StringBuilder sb) {
    4340        sb.append("[k=").append(key);
    4441
  • trunk/src/org/openstreetmap/josm/gui/oauth/AccessTokenInfoPanel.java

    r5886 r6890  
    2626    private JCheckBox cbSaveAccessTokenInPreferences;
    2727
    28     protected void build() {
     28    protected final void build() {
    2929        setLayout(new GridBagLayout());
    3030        GridBagConstraints gc = new GridBagConstraints();
  • trunk/src/org/openstreetmap/josm/gui/oauth/AdvancedOAuthPropertiesPanel.java

    r6883 r6890  
    5151    private String apiUrl;
    5252
    53     protected void build() {
     53    protected final void build() {
    5454        setLayout(new GridBagLayout());
    5555        setBorder(BorderFactory.createEmptyBorder(3,3,3,3));
  • trunk/src/org/openstreetmap/josm/gui/oauth/FullyAutomaticAuthorizationUI.java

    r6883 r6890  
    263263    }
    264264
    265     protected void build() {
     265    protected final void build() {
    266266        setLayout(new BorderLayout());
    267267        pnlPropertiesPanel = buildPropertiesPanel();
     
    345345        }
    346346
    347         protected void updateEnabledState() {
     347        protected final void updateEnabledState() {
    348348            setEnabled(valPassword.isValid() && valUserName.isValid());
    349349        }
  • trunk/src/org/openstreetmap/josm/gui/oauth/FullyAutomaticPropertiesPanel.java

    r6883 r6890  
    2323    private JosmPasswordField tfPassword;
    2424
    25     protected JPanel buildUserNamePasswordPanel() {
     25    protected final JPanel buildUserNamePasswordPanel() {
    2626        JPanel pnl = new JPanel(new GridBagLayout());
    2727        GridBagConstraints gc = new GridBagConstraints();
  • trunk/src/org/openstreetmap/josm/gui/oauth/ManualAuthorizationUI.java

    r6889 r6890  
    153153    }
    154154
    155     protected void build() {
     155    protected final void build() {
    156156        setLayout(new BorderLayout());
    157157        setBorder(BorderFactory.createEmptyBorder(5,5,5,5));
     
    263263        }
    264264
    265         protected void updateEnabledState() {
     265        protected final void updateEnabledState() {
    266266            setEnabled(hasAccessToken());
    267267        }
  • trunk/src/org/openstreetmap/josm/gui/oauth/OAuthAuthorizationWizard.java

    r6845 r6890  
    161161     * builds the UI
    162162     */
    163     protected void build() {
     163    protected final void build() {
    164164        getContentPane().setLayout(new BorderLayout());
    165165        getContentPane().add(buildHeaderInfoPanel(), BorderLayout.NORTH);
     
    348348        }
    349349
    350         public void updateEnabledState(OAuthToken token) {
     350        public final void updateEnabledState(OAuthToken token) {
    351351            setEnabled(token != null);
    352352        }
  • trunk/src/org/openstreetmap/josm/gui/oauth/OsmPrivilegesPanel.java

    r6066 r6890  
    2424    private JCheckBox cbModifyNotes;
    2525
    26     protected void build() {
     26    protected final void build() {
    2727        setLayout(new GridBagLayout());
    2828        GridBagConstraints gc = new GridBagConstraints();
     
    8686    }
    8787
     88    /**
     89     * Constructs a new {@code OsmPrivilegesPanel}.
     90     */
    8891    public OsmPrivilegesPanel() {
    8992        build();
  • trunk/src/org/openstreetmap/josm/gui/oauth/SemiAutomaticAuthorizationUI.java

    r6340 r6890  
    5151     * build the UI
    5252     */
    53     protected void build() {
     53    protected final void build() {
    5454        setLayout(new BorderLayout());
    5555        setBorder(BorderFactory.createEmptyBorder(5,5,5,5));
     
    187187
    188188        }
    189         protected void build() {
     189        protected final void build() {
    190190            setLayout(new BorderLayout(0,5));
    191191            JLabel lbl = new JLabel(tr("<html>Step 1/3: Retrieve an OAuth Request Token</html>"));
     
    261261        }
    262262
    263         protected void build() {
     263        protected final void build() {
    264264            setLayout(new BorderLayout());
    265265            add(buildTitlePanel(), BorderLayout.NORTH);
     
    340340        }
    341341
    342         protected void build() {
     342        protected final void build() {
    343343            setLayout(new BorderLayout());
    344344            add(buildTitlePanel(), BorderLayout.NORTH);
  • trunk/src/org/openstreetmap/josm/gui/preferences/PreferenceDialog.java

    r6426 r6890  
    6363    }
    6464
    65     protected void build() {
     65    protected final void build() {
    6666        Container c = getContentPane();
    6767        c.setLayout(new BorderLayout());
  • trunk/src/org/openstreetmap/josm/gui/preferences/SourceEditor.java

    r6883 r6890  
    871871        }
    872872
    873         protected void updateEnabledState() {
     873        protected final void updateEnabledState() {
    874874            setEnabled(tblActiveSources.getSelectedRowCount() > 0);
    875875        }
     
    894894        }
    895895
    896         protected void updateEnabledState() {
     896        protected final void updateEnabledState() {
    897897            setEnabled(tblActiveSources.getSelectedRowCount() == 1);
    898898        }
     
    942942        }
    943943
    944         public void updateEnabledState() {
     944        public final void updateEnabledState() {
    945945            setEnabled(activeSourcesModel.canMove(increment));
    946946        }
     
    969969        }
    970970
    971         protected void updateEnabledState() {
     971        protected final void updateEnabledState() {
    972972            setEnabled(lstAvailableSources.getSelectedIndices().length > 0);
    973973        }
     
    11711171        }
    11721172
    1173         protected void updateEnabledState() {
     1173        protected final void updateEnabledState() {
    11741174            setEnabled(tblIconPaths.getSelectedRowCount() > 0);
    11751175        }
     
    11941194        }
    11951195
    1196         protected void updateEnabledState() {
     1196        protected final void updateEnabledState() {
    11971197            setEnabled(tblIconPaths.getSelectedRowCount() == 1);
    11981198        }
     
    13941394         * build the GUI
    13951395         */
    1396         protected void build() {
     1396        protected final void build() {
    13971397            setLayout(new GridBagLayout());
    13981398            GridBagConstraints gc = new GridBagConstraints();
  • trunk/src/org/openstreetmap/josm/gui/preferences/advanced/ListEditor.java

    r6767 r6890  
    6464    }
    6565
    66     protected JPanel build() {
     66    protected final JPanel build() {
    6767        JPanel p = new JPanel(new GridBagLayout());
    6868        p.add(new JLabel(tr("Key: {0}", entry.getKey())), GBC.eol().insets(0,0,5,0));
  • trunk/src/org/openstreetmap/josm/gui/preferences/advanced/ListListEditor.java

    r6767 r6890  
    7575    }
    7676
    77     protected JPanel build() {
     77    protected final JPanel build() {
    7878        JPanel p = new JPanel(new GridBagLayout());
    7979        p.add(new JLabel(tr("Key: {0}", entry.getKey())), GBC.std(0,0).span(2).weight(1, 0).insets(0,0,5,10));
     
    158158        }
    159159
    160         protected void updateEnabledState() {
     160        protected final void updateEnabledState() {
    161161            setEnabled(entryList.getSelectedIndices().length == 1);
    162162        }
  • trunk/src/org/openstreetmap/josm/gui/preferences/advanced/MapListEditor.java

    r6792 r6890  
    9393    }
    9494
    95     protected JPanel build() {
     95    protected final JPanel build() {
    9696        JPanel p = new JPanel(new GridBagLayout());
    9797        p.add(new JLabel(tr("Key: {0}", entry.getKey())), GBC.std(0,0).span(2).weight(1, 0).insets(0,0,5,10));
     
    178178        }
    179179
    180         protected void updateEnabledState() {
     180        protected final void updateEnabledState() {
    181181            setEnabled(entryList.getSelectedIndices().length == 1);
    182182        }
  • trunk/src/org/openstreetmap/josm/gui/preferences/advanced/StringEditor.java

    r6767 r6890  
    4242    }
    4343
    44     protected JPanel build(String orig) {
     44    protected final JPanel build(String orig) {
    4545        JPanel p = new JPanel(new GridBagLayout());
    4646        p.add(new JLabel(tr("Key: {0}", entry.getKey())), GBC.eol().insets(0,0,5,0));
  • trunk/src/org/openstreetmap/josm/gui/preferences/display/GPXSettingsPanel.java

    r6764 r6890  
    319319     * Loads preferences to UI controls
    320320     */
    321     public void loadPreferences () {
     321    public final void loadPreferences () {
    322322        makeAutoMarkers.setSelected(Main.pref.getBoolean("marker.makeautomarkers", true));
    323323        if(layerName!=null && Main.pref.get("draw.rawgps.lines."+layerName).isEmpty()
  • trunk/src/org/openstreetmap/josm/gui/preferences/imagery/ImageryPreference.java

    r6733 r6890  
    496496            }
    497497
    498             protected void updateEnabledState() {
     498            protected final void updateEnabledState() {
    499499                setEnabled(activeTable.getSelectedRowCount() > 0);
    500500            }
  • trunk/src/org/openstreetmap/josm/gui/preferences/plugin/PluginUpdatePolicyPanel.java

    r6340 r6890  
    137137    }
    138138
    139     protected void build() {
     139    protected final void build() {
    140140        setLayout(new GridBagLayout());
    141141        GridBagConstraints gc = new GridBagConstraints();
     
    167167     *
    168168     */
    169     public void initFromPreferences() {
     169    public final void initFromPreferences() {
    170170        String pref = Main.pref.get("pluginmanager.version-based-update.policy", "ask");
    171171        Policy p = Policy.fromPreferenceValue(pref);
  • trunk/src/org/openstreetmap/josm/gui/preferences/projection/CodeProjectionChoice.java

    r6792 r6890  
    131131        }
    132132
    133         public void setCode(String code) {
     133        public final void setCode(String code) {
    134134            int idx = filteredData.indexOf(code);
    135135            if (idx != -1) {
  • trunk/src/org/openstreetmap/josm/gui/preferences/projection/CustomProjectionChoice.java

    r6854 r6890  
    5858        }
    5959
    60         private void build(String initialText, final ActionListener listener) {
     60        private final void build(String initialText, final ActionListener listener) {
    6161            input = new JosmTextField(30);
    6262            cbInput = new HistoryComboBox();
     
    9696
    9797                @Override
    98                 public boolean isValid() {
     98                public final boolean isValid() {
    9999                    try {
    100100                        CustomProjection test = new CustomProjection();
  • trunk/src/org/openstreetmap/josm/gui/preferences/server/AuthenticationPreferencesPanel.java

    r6623 r6890  
    4747     * builds the UI
    4848     */
    49     protected void build() {
     49    protected final void build() {
    5050        setLayout(new GridBagLayout());
    5151        GridBagConstraints gc = new GridBagConstraints();
  • trunk/src/org/openstreetmap/josm/gui/preferences/server/BasicAuthenticationPreferencesPanel.java

    r6643 r6890  
    4141     * builds the UI
    4242     */
    43     protected void build() {
     43    protected final void build() {
    4444        setLayout(new GridBagLayout());
    4545        setBorder(BorderFactory.createEmptyBorder(3,3,3,3));
  • trunk/src/org/openstreetmap/josm/gui/preferences/server/OAuthAuthenticationPreferencesPanel.java

    r6847 r6890  
    104104     * builds the UI
    105105     */
    106     protected void build() {
     106    protected final void build() {
    107107        setLayout(new GridBagLayout());
    108108        setBorder(BorderFactory.createEmptyBorder(5,5,5,5));
     
    290290        }
    291291
    292         public void refreshView() {
     292        public final void refreshView() {
    293293            String v = OAuthAccessTokenHolder.getInstance().getAccessTokenKey();
    294294            tfAccessTokenKey.setText(v == null? "" : v);
  • trunk/src/org/openstreetmap/josm/gui/preferences/server/OsmApiUrlInputPanel.java

    r6883 r6890  
    6464    }
    6565
    66     protected void build() {
     66    protected final void build() {
    6767        setLayout(new GridBagLayout());
    6868        GridBagConstraints gc = new GridBagConstraints();
     
    205205        }
    206206
    207         protected void updateEnabledState() {
     207        protected final void updateEnabledState() {
    208208            String url = getStrippedApiUrl();
    209209            boolean enabled = !url.isEmpty() && !url.equals(lastTestedUrl);
  • trunk/src/org/openstreetmap/josm/gui/preferences/server/ProxyPreferencesPanel.java

    r6883 r6890  
    114114     * @return panel with HTTP proxy configuration
    115115     */
    116     protected JPanel buildHttpProxyConfigurationPanel() {
     116    protected final JPanel buildHttpProxyConfigurationPanel() {
    117117        JPanel pnl = new JPanel(new GridBagLayout()) {
    118118            @Override
     
    190190     * @return panel with SOCKS proxy configuration
    191191     */
    192     protected JPanel buildSocksProxyConfigurationPanel() {
     192    protected final JPanel buildSocksProxyConfigurationPanel() {
    193193        JPanel pnl = new JPanel(new GridBagLayout()) {
    194194            @Override
     
    230230    }
    231231
    232     protected JPanel buildProxySettingsPanel() {
     232    protected final JPanel buildProxySettingsPanel() {
    233233        JPanel pnl = new JPanel(new GridBagLayout());
    234234        GridBagConstraints gc = new GridBagConstraints();
     
    314314     * Initializes the panel with the values from the preferences
    315315     */
    316     public void initFromPreferences() {
     316    public final void initFromPreferences() {
    317317        String policy = Main.pref.get(PROXY_POLICY, null);
    318318        ProxyPolicy pp = ProxyPolicy.fromName(policy);
     
    365365    }
    366366
    367     protected void updateEnabledState() {
     367    protected final void updateEnabledState() {
    368368        boolean isHttpProxy = rbProxyPolicy.get(ProxyPolicy.USE_HTTP_PROXY).isSelected();
    369369        for (Component c: pnlHttpProxyConfigurationPanel.getComponents()) {
  • trunk/src/org/openstreetmap/josm/gui/tagging/TagEditorPanel.java

    r6783 r6890  
    9898     * builds the GUI
    9999     */
    100     protected void build() {
     100    protected final void build() {
    101101        setLayout(new GridBagLayout());
    102102        JPanel tablePanel = buildTagTableEditorPanel();
  • trunk/src/org/openstreetmap/josm/gui/tagging/TagModel.java

    r6316 r6890  
    4747     * @param name the tag name
    4848     */
    49     public void setName(String name) {
     49    public final void setName(String name) {
    5050        name = (name == null) ? "" : name;
    5151        this.name = name;
     
    7070     * @param value the value.
    7171     */
    72     public void setValue(String value) {
     72    public final void setValue(String value) {
    7373        value = (value == null) ? "" : value;
    7474        clearValues();
  • trunk/src/org/openstreetmap/josm/gui/tagging/TagTable.java

    r6524 r6890  
    268268        }
    269269
    270         protected void updateEnabledState() {
     270        protected final void updateEnabledState() {
    271271            if (isEditing() && getSelectedColumnCount() == 1 && getSelectedRowCount() == 1) {
    272272                setEnabled(true);
     
    308308        }
    309309
    310         protected void updateEnabledState() {
     310        protected final void updateEnabledState() {
    311311            setEnabled(TagTable.this.isEnabled());
    312312        }
     
    357357        }
    358358       
    359         protected void updateEnabledState() {
     359        protected final void updateEnabledState() {
    360360            setEnabled(TagTable.this.isEnabled());
    361361        }
     
    395395     * initialize the table
    396396     */
    397     protected void init() {
     397    protected final void init() {
    398398        setAutoResizeMode(JTable.AUTO_RESIZE_OFF);
    399399        setRowSelectionAllowed(true);
  • trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPreset.java

    r6883 r6890  
    444444    }
    445445
    446     protected void updateEnabledState() {
     446    protected final void updateEnabledState() {
    447447        setEnabled(Main.main != null && Main.main.getCurrentDataSet() != null);
    448448    }
  • trunk/src/org/openstreetmap/josm/gui/tagging/ac/AutoCompletingTextField.java

    r6087 r6890  
    135135    }
    136136
    137     protected void init() {
     137    protected final void init() {
    138138        addFocusListener(
    139139                new FocusAdapter() {
  • trunk/src/org/openstreetmap/josm/gui/widgets/BoundingBoxSelectionPanel.java

    r6883 r6890  
    4444    }
    4545
    46     protected void build() {
     46    protected final void build() {
    4747        buildInputFields();
    4848        setBorder(BorderFactory.createEmptyBorder(5,5,5,5));
  • trunk/src/org/openstreetmap/josm/gui/widgets/DisableShortcutsOnFocusGainedTextField.java

    r6830 r6890  
    105105    private final Set<JosmAction> disabledMenuActions = new HashSet<JosmAction>();
    106106
    107     protected void init() {
     107    protected final void init() {
    108108        addFocusListener(this);
    109109    }
  • trunk/src/org/openstreetmap/josm/gui/widgets/HtmlPanel.java

    r6040 r6890  
    2323    private JosmEditorPane jepMessage;
    2424
    25     protected void build() {
     25    protected final void build() {
    2626        setLayout(new BorderLayout());
    2727        jepMessage = new JosmEditorPane("text/html", "");
     
    8787     * @param text the text to display
    8888     */
    89     public void setText(String text) {
     89    public final void setText(String text) {
    9090        if (text == null) {
    9191            text = "";
  • trunk/src/org/openstreetmap/josm/gui/widgets/JosmComboBox.java

    r6832 r6890  
    107107     * @since 5558
    108108     */
    109     protected Object findPrototypeDisplayValue(Collection<?> possibleValues) {
     109    protected final Object findPrototypeDisplayValue(Collection<?> possibleValues) {
    110110        Object result = null;
    111111        int maxHeight = -1;
     
    154154    }
    155155
    156     protected void init(Object prototype) {
     156    protected final void init(Object prototype) {
    157157        if (prototype != null) {
    158158            setPrototypeDisplayValue(prototype);
  • trunk/src/org/openstreetmap/josm/gui/widgets/QuadStateCheckBox.java

    r6380 r6890  
    9191
    9292    /** Do not let anyone add mouse listeners */
    93     @Override public void addMouseListener(MouseListener l) { }
     93    @Override
     94    public void addMouseListener(MouseListener l) { }
    9495   
    9596    /**
     
    9798     * @param state The new state
    9899     */
    99     public void setState(State state) {
     100    public final void setState(State state) {
    100101        model.setState(state);
    101102    }
  • trunk/src/org/openstreetmap/josm/io/Capabilities.java

    r6830 r6890  
    103103    }
    104104
    105     public void clear() {
     105    public final void clear() {
    106106        capabilities = new HashMap<String, HashMap<String,String>>();
    107107        imageryBlacklist = new ArrayList<String>();
  • trunk/src/org/openstreetmap/josm/io/ChangesetClosedException.java

    r6889 r6890  
    7272    private Source source;
    7373
    74     protected void parseErrorHeader(String errorHeader) {
     74    protected final void parseErrorHeader(String errorHeader) {
    7575        Pattern p = Pattern.compile(ERROR_HEADER_PATTERN);
    7676        Matcher m = p.matcher(errorHeader);
  • trunk/src/org/openstreetmap/josm/io/DefaultProxySelector.java

    r6714 r6890  
    104104     *
    105105     */
    106     public void initFromPreferences() {
     106    public final void initFromPreferences() {
    107107        String value = Main.pref.get(ProxyPreferencesPanel.PROXY_POLICY);
    108108        if (value.length() == 0) {
  • trunk/src/org/openstreetmap/josm/io/session/OsmDataSessionExporter.java

    r6552 r6890  
    8080        }
    8181
    82         public void updateEnabledState() {
     82        public final void updateEnabledState() {
    8383            setEnabled(layer.requiresSaveToFile());
    8484        }
  • trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java

    r6883 r6890  
    13261326        private JCheckBox cbDontShowAgain;
    13271327
    1328         protected void build() {
     1328        protected final void build() {
    13291329            setLayout(new GridBagLayout());
    13301330            GridBagConstraints gc = new GridBagConstraints();
  • trunk/src/org/openstreetmap/josm/plugins/PluginInformation.java

    r6843 r6890  
    192192    }
    193193
    194     private void scanManifest(Manifest manifest, boolean oldcheck) {
     194    private final void scanManifest(Manifest manifest, boolean oldcheck) {
    195195        String lang = LanguageInfo.getLanguageCodeManifest();
    196196        Attributes attr = manifest.getMainAttributes();
     
    500500
    501501    @Override
    502     public String toString() {
     502    public final String toString() {
    503503        return getName();
    504504    }
  • trunk/src/org/openstreetmap/josm/plugins/ReadRemotePluginInformationTask.java

    r6883 r6890  
    5959    protected enum CacheType {PLUGIN_LIST, ICON_LIST}
    6060
    61     protected void init(Collection<String> sites, boolean displayErrMsg){
     61    protected final void init(Collection<String> sites, boolean displayErrMsg){
    6262        this.sites = sites;
    6363        if (sites == null) {
     
    8888        init(sites, displayErrMsg);
    8989    }
    90 
    9190
    9291    @Override
  • trunk/src/org/openstreetmap/josm/tools/WindowGeometry.java

    r6889 r6890  
    161161    }
    162162
    163     protected void initFromPreferences(String preferenceKey) throws WindowGeometryException {
     163    protected final void initFromPreferences(String preferenceKey) throws WindowGeometryException {
    164164        String value = Main.pref.get(preferenceKey);
    165165        if (value == null || value.isEmpty())
     
    173173    }
    174174
    175     protected void initFromWindowGeometry(WindowGeometry other) {
     175    protected final void initFromWindowGeometry(WindowGeometry other) {
    176176        this.topLeft = other.topLeft;
    177177        this.extent = other.extent;
Note: See TracChangeset for help on using the changeset viewer.