Changeset 6890 in josm for trunk/src/org/openstreetmap/josm/gui/download

Timestamp:

2014-02-27T02:50:12+01:00 (13 years ago)

Author:

Don-vip

Message:

fix some Sonar issues (Constructor Calls Overridable Method)

Location:

trunk/src/org/openstreetmap/josm/gui/download

Files:

• BookmarkSelection.java (modified) (2 diffs)
• DownloadDialog.java (modified) (2 diffs)
• PlaceSelection.java (modified) (2 diffs)
• TileSelection.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/download/BookmarkSelection.java

@@ -224 +224 @@
             bookmarks.save();
         }
-        protected void updateEnabledState() {
+
+        protected final void updateEnabledState() {
             setEnabled(bookmarks.getSelectedIndices().length > 0);
         }
@@ -261 +262 @@
             }
         }
-        protected void updateEnabledState() {
+
+        protected final void updateEnabledState() {
             setEnabled(bookmarks.getSelectedIndices().length == 1);
         }
+
         @Override
         public void valueChanged(ListSelectionEvent e) {

trunk/src/org/openstreetmap/josm/gui/download/DownloadDialog.java

@@ -86 +86 @@
     }
 
-    protected JPanel buildMainPanel() {
+    protected final JPanel buildMainPanel() {
         JPanel pnl = new JPanel();
         pnl.setLayout(new GridBagLayout());
@@ -163 +163 @@
     }
 
-    protected JPanel buildButtonPanel() {
+    protected final JPanel buildButtonPanel() {
         JPanel pnl = new JPanel();
         pnl.setLayout(new FlowLayout());

trunk/src/org/openstreetmap/josm/gui/download/PlaceSelection.java

@@ -299 +299 @@
         }
 
-        protected void updateEnabledState() {
+        protected final void updateEnabledState() {
             setEnabled(cbSearchExpression.getText().trim().length() > 0);
         }
@@ -427 +427 @@
         TableColumn col3 = null;
         TableColumn col4 = null;
-        protected void createColumns() {
+        protected final void createColumns() {
             TableColumn col = null;
             NamedResultCellRenderer renderer = new NamedResultCellRenderer();

trunk/src/org/openstreetmap/josm/gui/download/TileSelection.java

@@ -22 +22 @@
     private DownloadDialog parent;
 
-    protected void build() {
+    protected final void build() {
         chooser = new TileSelectionBBoxChooser();
         chooser.addPropertyChangeListener(this);