Changeset 6889 in josm for trunk/src/org/openstreetmap/josm/gui/preferences/projection/ProjectionPreference.java

Timestamp:

2014-02-27T01:41:49+01:00 (10 years ago)

Author:

Don-vip

Message:

fix some Sonar issues (JLS order)

File:

• trunk/src/org/openstreetmap/josm/gui/preferences/projection/ProjectionPreference.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/gui/preferences/projection/ProjectionPreference.java

@@ -253 +253 @@
      * Combobox with all projections available
      */
-    private JosmComboBox projectionCombo = new JosmComboBox(projectionChoices.toArray());
+    private final JosmComboBox projectionCombo = new JosmComboBox(projectionChoices.toArray());
 
     /**
      * Combobox with all coordinate display possibilities
      */
-    private JosmComboBox coordinatesCombo = new JosmComboBox(CoordinateFormat.values());
-
-    private JosmComboBox unitsCombo = new JosmComboBox(unitsValuesTr);
+    private final JosmComboBox coordinatesCombo = new JosmComboBox(CoordinateFormat.values());
+
+    private final JosmComboBox unitsCombo = new JosmComboBox(unitsValuesTr);
 
     /**
@@ -281 +281 @@
      * This is the panel holding all projection preferences
      */
-    private JPanel projPanel = new JPanel(new GridBagLayout());
+    private final JPanel projPanel = new JPanel(new GridBagLayout());
 
     /**
@@ -288 +288 @@
      * in sync
      */
-    static private GBC projSubPrefPanelGBC = GBC.std().fill(GBC.BOTH).weight(1.0, 1.0);
+    private static final GBC projSubPrefPanelGBC = GBC.std().fill(GBC.BOTH).weight(1.0, 1.0);
 
     @Override
@@ -380 +380 @@
     }
 
-    static public void setProjection() {
+    public static void setProjection() {
         setProjection(PROP_PROJECTION.get(), PROP_SUB_PROJECTION.get());
     }
 
-    static public void setProjection(String id, Collection<String> pref) {
+    public static void setProjection(String id, Collection<String> pref) {
         ProjectionChoice pc = projectionChoicesById.get(id);