Changeset 6623 in josm for trunk/src/org/openstreetmap/josm/gui/preferences/plugin/PluginPreference.java

Timestamp:

2014-01-04T06:39:00+01:00 (10 years ago)

Author:

Don-vip

Message:

fix Sonar issues

File:

• trunk/src/org/openstreetmap/josm/gui/preferences/plugin/PluginPreference.java (modified) (6 diffs)

trunk/src/org/openstreetmap/josm/gui/preferences/plugin/PluginPreference.java

@@ -13 +13 @@
 import java.awt.event.ComponentAdapter;
 import java.awt.event.ComponentEvent;
+import java.lang.reflect.InvocationTargetException;
 import java.util.ArrayList;
 import java.util.Collection;
@@ -138 +139 @@
         gc.gridx = 1;
         gc.weightx = 1.0;
-        pnl.add(tfFilter = new JosmTextField(), gc);
+        tfFilter = new JosmTextField();
+        pnl.add(tfFilter, gc);
         tfFilter.setToolTipText(tr("Enter a search expression"));
         SelectAllOnFocusGainedDecorator.decorate(tfFilter);
@@ -158 +160 @@
         pnl.add(buildSearchFieldPanel(), BorderLayout.NORTH);
         model  = new PluginPreferencesModel();
-        spPluginPreferences = new JScrollPane(pnlPluginPreferences = new PluginListPanel(model));
+        pnlPluginPreferences = new PluginListPanel(model);
+        spPluginPreferences = new JScrollPane(pnlPluginPreferences);
         spPluginPreferences.setHorizontalScrollBarPolicy(JScrollPane.HORIZONTAL_SCROLLBAR_NEVER);
         spPluginPreferences.setVerticalScrollBarPolicy(JScrollPane.VERTICAL_SCROLLBAR_AS_NEEDED);
@@ -181 +184 @@
     protected JTabbedPane buildContentPane() {
         JTabbedPane pane = getTabPane();
+        pnlPluginUpdatePolicy = new PluginUpdatePolicyPanel();
         pane.addTab(tr("Plugins"), buildPluginListPanel());
-        pane.addTab(tr("Plugin update policy"), pnlPluginUpdatePolicy = new PluginUpdatePolicyPanel());
+        pane.addTab(tr("Plugin update policy"), pnlPluginUpdatePolicy);
         return pane;
     }
@@ -363 +367 @@
                     }
                 });
-            } catch (Exception e) {
-                e.printStackTrace();
+            } catch (InterruptedException e) {
+                Main.error(e);
+            } catch (InvocationTargetException e) {
+                Main.error(e);
             }
         }
@@ -482 +488 @@
         private DefaultListModel model;
 
-        protected void build() {
+        protected final void build() {
             setLayout(new GridBagLayout());
             add(new JLabel(tr("Add JOSM Plugin description URL.")), GBC.eol());