Changeset 6246 in josm for trunk/src/org/openstreetmap/josm/data

Timestamp:

2013-09-22T18:36:07+02:00 (12 years ago)

Author:

Don-vip

Message:

Sonar/FindBugs - various bugfixes / violation fixes

Location:

trunk/src/org/openstreetmap/josm/data

Files:

• Version.java (modified) (1 diff)
• gpx/WayPoint.java (modified) (1 diff)
• osm/AbstractPrimitive.java (modified) (1 diff)
• osm/WaySegment.java (modified) (1 diff)
• validation/OsmValidator.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/Version.java

@@ -131 +131 @@
         isLocalBuild = false;
         value = properties.get("Is-Local-Build");
-        if (value != null && value.trim().toLowerCase().equals("true"))  {
+        if (value != null && value.trim().equalsIgnoreCase("true"))  {
             isLocalBuild = true;
         }

trunk/src/org/openstreetmap/josm/data/gpx/WayPoint.java

@@ -1 @@
-//License: GPLv2 or later
-//Copyright 2007 by Raphael Mack and others
-
+// License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.data.gpx;
 

trunk/src/org/openstreetmap/josm/data/osm/AbstractPrimitive.java

@@ -398 +398 @@
     @Override
     public void setVisible(boolean visible) throws IllegalStateException{
-        if (isNew() && visible == false)
+        if (isNew() && !visible)
             throw new IllegalStateException(tr("A primitive with ID = 0 cannot be invisible."));
         updateFlags(FLAG_VISIBLE, visible);

trunk/src/org/openstreetmap/josm/data/osm/WaySegment.java

@@ -50 +50 @@
 
     @Override public boolean equals(Object o) {
-        return o != null && o instanceof WaySegment
+        return o instanceof WaySegment
             && ((WaySegment) o).way == way
             && ((WaySegment) o).lowerIndex == lowerIndex;

trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java

@@ -84 +84 @@
      */
     @SuppressWarnings("unchecked")
-    public static Class<Test>[] allAvailableTests = new Class[] {
+    private static final Class<Test>[] allAvailableTests = new Class[] {
         DuplicateNode.class, // ID    1 ..   99
         OverlappingWays.class, // ID  101 ..  199