Changeset 5550 in josm for trunk

Timestamp:

2012-11-01T21:07:40+01:00 (11 years ago)

Author:

bastiK

Message:

applied #7259 - Validation Enhancements for water features (patch by oldtopos, slightly modified)

Location:

trunk/src/org/openstreetmap/josm/data/validation/tests

Files:

• CrossingWays.java (modified) (2 diffs)
• OverlappingAreas.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/validation/tests/CrossingWays.java

@@ -42 +42 @@
      */
     public CrossingWays() {
-        super(tr("Crossing ways"),
+        super(tr("Crossing ways."),
                 tr("This test checks if two roads, railways, waterways or buildings crosses in the same layer, but are not connected by a node."));
     }
@@ -139 +139 @@
                         if (isBuilding) {
                             message = tr("Crossing buildings");
+                        } else if ((es1.waterway != null && es2.waterway != null)) {
+                            message = tr("Crossing waterways");
                         } else if ((es1.waterway != null && es2.ws.way.get("highway") != null)
                                 || (es2.waterway != null && es1.ws.way.get("highway") != null)) {

trunk/src/org/openstreetmap/josm/data/validation/tests/OverlappingAreas.java

@@ -3 +3 @@
 import static org.openstreetmap.josm.tools.I18n.tr;
 
+import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
@@ -49 +50 @@
                     });
             if (!overlaps.isEmpty()) {
-                errors.add(new TestError(this, Severity.OTHER, tr("Overlapping Areas"),
-                        OVERLAPPING_AREAS, Collections.singletonList(w), overlaps));
+                Collection<Way> overlapsWater = new ArrayList<Way>();
+                Collection<Way> overlapsOther = new ArrayList<Way>();
+
+                String natural1 = w.get("natural");
+                String landuse1 = w.get("landuse");
+                boolean isWaterArea = "water".equals(natural1) || "wetland".equals(natural1) || "coastline".equals(natural1) || "reservoir".equals(landuse1);
+                boolean isWaterArea2 = false;
+
+                for (Way wayOther : overlaps) {
+                    String natural2 = wayOther.get("natural");
+                    String landuse2 = wayOther.get("landuse");
+                    boolean isWaterAreaTest = "water".equals(natural2) || "wetland".equals(natural2) || "coastline".equals(natural2) || "reservoir".equals(landuse2);
+
+                    if (!isWaterArea2) {
+                        isWaterArea2 = isWaterAreaTest;
+                    }
+
+                    if (isWaterArea && isWaterAreaTest) {
+                        overlapsWater.add(wayOther);
+                    } else {
+                        overlapsOther.add(wayOther);
+                    }
+                }
+
+                if (!overlapsWater.isEmpty()) {
+                    errors.add(new TestError(this, Severity.WARNING, tr("Overlapping Water Areas"),
+                            OVERLAPPING_AREAS, Collections.singletonList(w), overlapsWater));
+                }
+
+                if (!overlapsOther.isEmpty()) {
+                    errors.add(new TestError(this, Severity.OTHER, tr("Overlapping Areas"),
+                            OVERLAPPING_AREAS, Collections.singletonList(w), overlapsOther));
+                }
             }
         }