Changeset 29272 in osm for applications/editors/josm/plugins/smed2/src/seamap/SeaMap.java

Timestamp:

2013-02-21T21:01:44+01:00 (12 years ago)

Author:

malcolmh

Message:

save

File:

• applications/editors/josm/plugins/smed2/src/seamap/SeaMap.java (modified) (8 diffs)

applications/editors/josm/plugins/smed2/src/seamap/SeaMap.java

@@ -201 +201 @@
 
                 public boolean hasNext() {
-                        return (edge != null) && ((it == null) || (forward && it.hasNext()) || (!forward && it.hasPrevious()));
+                        return (edge != null) && ((it == null) || (edge.nodes.isEmpty()) || (forward && it.hasNext()) || (!forward && it.hasPrevious()));
                 }
 
@@ -371 +371 @@
 
         public void tagsDone(long id) {
-                if ((feature.type != Obj.UNKOBJ) && !((edge != null) && (edge.last == 0))) {
-                        index.put(id, feature);
-                        if (features.get(feature.type) == null) {
-                                features.put(feature.type, new ArrayList<Feature>());
-                        }
-                        features.get(feature.type).add(feature);
-                }
                 switch (feature.flag) {
                 case POINT:
@@ -432 +425 @@
                         break;
                 }
-                feature.centre = findCentroid(feature);
+                if ((feature.type != Obj.UNKOBJ) && !((edge != null) && (edge.last == 0))) {
+                        index.put(id, feature);
+                        if (features.get(feature.type) == null) {
+                                features.put(feature.type, new ArrayList<Feature>());
+                        }
+                        feature.centre = findCentroid(feature);
+                        features.get(feature.type).add(feature);
+                }
         }
 
@@ -461 +461 @@
 
         public Snode findCentroid(Feature feature) {
-                double lat, lon, slat, slon, sarc, llat, llon;
-                lat = lon = slat = slon = sarc = llat = llon = 0;
+                double lat, lon, slat, slon, llat, llon;
+                llat = llon = lat = lon = slat = slon = 0;
+                double sarc = 0;
+                boolean first = true;
                 switch (feature.flag) {
                 case POINT:
@@ -473 +475 @@
                                 lat = node.lat;
                                 lon = node.lon;
-                                sarc += (Math.acos(Math.cos(lon - llon) * Math.cos(lat - llat)));
+                                if (first) {
+                                        first = false;
+                                } else {
+                                        sarc += (Math.acos(Math.cos(lon - llon) * Math.cos(lat - llat)));
+                                }
                                 llat = lat;
                                 llon = lon;
@@ -479 +485 @@
                         double harc = sarc / 2;
                         sarc = 0;
+                        first = true;
                         eit = new EdgeIterator(edge, true);
                         while (eit.hasNext()) {
@@ -484 +491 @@
                                 lat = node.lat;
                                 lon = node.lon;
-                                sarc = (Math.acos(Math.cos(lon - llon) * Math.cos(lat - llat)));
-                                if (sarc > harc)
-                                        break;
+                                if (first) {
+                                        first = false;
+                                } else {
+                                        sarc = (Math.acos(Math.cos(lon - llon) * Math.cos(lat - llat)));
+                                        if (sarc > harc)
+                                                break;
+                                }
                                 harc -= sarc;
                                 llat = lat;
@@ -497 +508 @@
                         BoundIterator bit = new BoundIterator(bound);
                         while (bit.hasNext()) {
-                                llon = lon;
-                                llat = lat;
                                 Snode node = bit.next();
                                 lat = node.lat;
                                 lon = node.lon;
-                                double arc = (Math.acos(Math.cos(lon - llon) * Math.cos(lat - llat)));
-                                slat += (lat * arc);
-                                slon += (lon * arc);
-                                sarc += arc;
+                                if (first) {
+                                        first = false;
+                                } else {
+                                        double arc = (Math.acos(Math.cos(lon - llon) * Math.cos(lat - llat)));
+                                        slat += (lat * arc);
+                                        slon += (lon * arc);
+                                        sarc += arc;
+                                }
+                                llon = lon;
+                                llat = lat;
                         }
                         return new Snode((sarc > 0.0 ? slat / sarc : 0.0), (sarc > 0.0 ? slon / sarc : 0.0));