Changeset 2855 in josm

Timestamp:

2010-01-14T10:26:13+01:00 (15 years ago)

Author:

Gubaer

Message:

fixed #4364: editing an "advanced preference" will disable all plugins
fixed #4351: Button sizes in plugin preferences different (last button is smaller)

Location:

trunk/src/org/openstreetmap/josm

Files:

• gui/preferences/PluginPreference.java (modified) (5 diffs)
• plugins/PluginHandler.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/preferences/PluginPreference.java

@@ -96 +96 @@
     private PluginPreferencesModel model;
     private JScrollPane spPluginPreferences;
+    /**
+     * is set to true if this preference pane has been selected
+     * by the user
+     */
+    private boolean pluginPreferencesActivated = false;
 
     protected JPanel buildSearchFieldPanel() {
@@ -247 +252 @@
 
     public boolean ok() {
+        if (! pluginPreferencesActivated)
+            return false;
         if (model.isActivePluginsChanged()) {
             Main.pref.putCollection("plugins", model.getSelectedPluginNames());
@@ -254 +261 @@
     }
 
+    /**
+     * Reads locally available information about plugins from the local file system.
+     * Scans cached plugin lists from plugin download sites and locally available
+     * plugin jar files.
+     * 
+     */
     public void readLocalPluginInformation() {
         final ReadLocalPluginInformationTask task = new ReadLocalPluginInformationTask();
@@ -363 +376 @@
             putValue(NAME,tr("Configure sites..."));
             putValue(SHORT_DESCRIPTION, tr("Configure the list of sites where plugins are downloaded from"));
+            putValue(SMALL_ICON, ImageProvider.get("dialogs", "propertiesdialog"));
         }
 
@@ -385 +399 @@
             if (tp.getSelectedComponent() == pane) {
                 readLocalPluginInformation();
+                pluginPreferencesActivated = true;
             }
         }

trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java

@@ -657 +657 @@
         }
 
-        if (plugin == null)
-        {
+        if (plugin == null) {
             /**
              * Analyze the stack of the argument and find a name of a plugin, if
              * some known problem pattern has been found.
              */
-            for (PluginProxy p : pluginList)
-            {
+            for (PluginProxy p : pluginList) {
                 String baseClass = p.getPluginInformation().className;
                 int i = baseClass.lastIndexOf(".");
                 baseClass = baseClass.substring(0, i);
-                for (StackTraceElement element : e.getStackTrace())
-                {
+                for (StackTraceElement element : e.getStackTrace()) {
                     String c = element.getClassName();
-                    if(c.startsWith(baseClass))
-                    {
+                    if (c.startsWith(baseClass)) {
                         plugin = p;
                         break;
                     }
                 }
-                if(plugin != null) {
+                if (plugin != null) {
                     break;
                 }