Changeset 2389 in josm

Timestamp:

2009-11-03T05:32:40+01:00 (15 years ago)

Author:

Gubaer

Message:

see #3834: added context sensitive help

Location:

trunk/src/org/openstreetmap/josm

Files:

• gui/help/HelpUtil.java (modified) (4 diffs)
• plugins/PluginHandler.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/gui/help/HelpUtil.java

@@ -12 +12 @@
 
 import org.openstreetmap.josm.Main;
+import org.openstreetmap.josm.actions.HelpAction;
 import org.openstreetmap.josm.tools.LanguageInfo;
 
@@ -205 +206 @@
 
     /**
+     * Replies the global help action, if available. Otherwise, creates an instance
+     * of {@see HelpAction}.
+     * 
+     * @return
+     */
+    static private Action getHelpAction() {
+        try {
+            return Main.main.menu.help;
+        } catch(NullPointerException e) {
+            return new HelpAction();
+        }
+    }
+
+    /**
      * Makes a component aware of context sensitive help.
      * 
@@ -210 +225 @@
      * code. Example: /Dialog/RelationEditor is a relative help topic, /De:Help/Dialog/RelationEditor
      * is not.
-     *  
+     * 
      * @param component the component  the component
      * @param topic the help topic. Set to the default help topic if null.
@@ -219 +234 @@
         }
         component.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(KeyStroke.getKeyStroke("F1"), "help");
-        component.getActionMap().put("help", Main.main.menu.help);
+        component.getActionMap().put("help", getHelpAction());
         component.putClientProperty("help", relativeHelpTopic);
     }

trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java

@@ -2 +2 @@
 package org.openstreetmap.josm.plugins;
 
+import static org.openstreetmap.josm.gui.help.HelpUtil.ht;
 import static org.openstreetmap.josm.tools.I18n.tr;
 
@@ -13 +14 @@
 import java.util.Collection;
 import java.util.Collections;
-import java.util.HashMap;
 import java.util.LinkedList;
 import java.util.List;
-import java.util.Map;
 import java.util.SortedMap;
 import java.util.TreeMap;
@@ -33 +32 @@
 
 import org.openstreetmap.josm.Main;
-import org.openstreetmap.josm.actions.AboutAction;
 import org.openstreetmap.josm.data.Version;
 import org.openstreetmap.josm.gui.ExtendedDialog;
@@ -101 +99 @@
             if(Main.pref.getInteger("pluginmanager.version", 0) < v)
             {
-                doUpdate = tr("You updated your JOSM software\nTo prevent problems the plugins should be updated as well.\n"
+                doUpdate = tr("You updated your JOSM software.\nTo prevent problems the plugins should be updated as well.\n"
                         + "Update plugins now?");
                 check = "pluginmanger.version";
@@ -128 +126 @@
                 dialog.toggleEnable(check);
                 dialog.setButtonIcons( new String[] {"dialogs/refresh.png", "cancel.png"});
+                dialog.configureContextsensitiveHelp(ht("/Plugin/AutomaticUpdate"), true /* show help button */);
                 dialog.showDialog();
-                if(dialog.getValue() == 1)
+                if(dialog.getValue() == 1) {
                     new PluginSelection().update();
+                }
             }
         }