Changeset 2281 in josm

Timestamp:

2009-10-12T20:59:00+02:00 (15 years ago)

Author:

Gubaer

Message:

see #3668: Upload dialog: comment textbox buggy

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• io/UploadDialog.java (modified) (2 diffs)
• widgets/AutoCompleteComboBox.java (modified) (4 diffs)
• widgets/HistoryComboBox.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java

@@ -362 +362 @@
     protected String getUploadComment() {
         switch(southTabbedPane.getSelectedIndex()) {
-        case 0:
-            return pnlChangesetSelection.getUploadComment();
-        case 1:
-            TagModel tm = tagEditorPanel.getModel().get("comment");
-            return tm == null? "" : tm.getValue();
+            case 0:
+                return pnlChangesetSelection.getUploadComment();
+            case 1:
+                TagModel tm = tagEditorPanel.getModel().get("comment");
+                return tm == null? "" : tm.getValue();
         }
         return "";
@@ -802 +802 @@
             setUploadComment(comment);
             cmt.getEditor().selectAll();
-            cmt.requestFocus();
+            cmt.requestFocusInWindow();
         }
 

trunk/src/org/openstreetmap/josm/gui/widgets/AutoCompleteComboBox.java

@@ -19 +19 @@
 public class AutoCompleteComboBox extends JComboBox {
 
+
+    private boolean autocompleteEnabled = true;
+
     /**
      * Auto-complete a JComboBox.
@@ -24 +27 @@
      * Inspired by http://www.orbital-computer.de/JComboBox/
      */
-    private class AutoCompleteComboBoxDocument extends PlainDocument {
+    class AutoCompleteComboBoxDocument extends PlainDocument {
         private JComboBox comboBox;
         private boolean selecting = false;
@@ -48 +51 @@
             // ActionListener informed
             if (selecting)
+                return;
+            if (!autocompleteEnabled)
                 return;
 
@@ -117 +122 @@
         this.getEditor().setItem(oldValue);
     }
+
+    protected boolean isAutocompleteEnabled() {
+        return autocompleteEnabled;
+    }
+
+    protected void setAutocompleteEnabled(boolean autocompleteEnabled) {
+        this.autocompleteEnabled = autocompleteEnabled;
+    }
 }

trunk/src/org/openstreetmap/josm/gui/widgets/HistoryComboBox.java

@@ -19 +19 @@
 
     public void setText(String value) {
+        setAutocompleteEnabled(false);
         ((JTextComponent)getEditor().getEditorComponent()).setText(value);
+        setAutocompleteEnabled(true);
     }