Changeset 19629 in josm for trunk/test

Timestamp:

2026-10-01T17:54:30+02:00 (6 days ago)

Author:

gaben

Message:

see #24635 - fix PMD violations

• use String.isBlank() instead of trim().isEmpty(),
• method references,
• EnumMap for enum keys
• drop redundant initializers/toString() calls and unused annotations,
• remove unused private getDefensiveDate()
• use an explicit charset for Content-length

Location:

trunk/test/unit/org/openstreetmap/josm

Files:

• data/projection/ProjectionRefTest.java (modified) (1 diff)
• gui/help/HelpContentReaderTest.java (modified) (1 diff)

trunk/test/unit/org/openstreetmap/josm/data/projection/ProjectionRefTest.java

@@ -123 +123 @@
             RefEntry curEntry = null;
             while ((line = in.readLine()) != null) {
-                if (line.startsWith("#") || line.trim().isEmpty()) {
+                if (line.startsWith("#") || line.isBlank()) {
                     continue;
                 }

trunk/test/unit/org/openstreetmap/josm/gui/help/HelpContentReaderTest.java

@@ -28 +28 @@
     void testFetchHelpTopicContentNominal() throws HelpContentReaderException {
         String res = new HelpContentReader(HelpUtil.getWikiBaseUrl()).fetchHelpTopicContent(HelpBrowserTest.URL_1, false);
-        assertFalse(res.trim().isEmpty());
+        assertFalse(res.isBlank());
     }
 }