Changeset 19629 in josm for trunk/src/org/openstreetmap/josm/data/validation/tests

Timestamp:

2026-10-01T17:54:30+02:00 (4 weeks ago)

Author:

gaben

Message:

see #24635 - fix PMD violations

• use String.isBlank() instead of trim().isEmpty(),
• method references,
• EnumMap for enum keys
• drop redundant initializers/toString() calls and unused annotations,
• remove unused private getDefensiveDate()
• use an explicit charset for Content-length

Location:

trunk/src/org/openstreetmap/josm/data/validation/tests

Files:

• MapCSSTagChecker.java (modified) (1 diff)
• PowerLines.java (modified) (1 diff)
• TagChecker.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/validation/tests/MapCSSTagChecker.java

@@ -287 +287 @@
      * @since 18365 (public, primarily for ValidatorCLI)
      */
+    @SuppressWarnings("PMD.UseTryWithResources") // zip.a is closed via Utils.close(), which swallows IOException
     public synchronized ParseResult addMapCSS(String url, Consumer<String> assertionConsumer) throws ParseException, IOException {
         CheckParameterUtil.ensureParameterNotNull(url, "url");

trunk/src/org/openstreetmap/josm/data/validation/tests/PowerLines.java

@@ -102 +102 @@
     @Override
     public void visit(Node n) {
-        if (!n.isConnectionNode() || n.referrers(Way.class).noneMatch(w -> isPowerLineOrCable(w)))
+        if (!n.isConnectionNode() || n.referrers(Way.class).noneMatch(PowerLines::isPowerLineOrCable))
             return;
 

trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java

@@ -1024 +1024 @@
             withErrors.put(p, "LV");
         }
-        if (value.trim().isEmpty() && !withErrors.contains(p, "EV")) {
+        if (value.isBlank() && !withErrors.contains(p, "EV")) {
             errors.add(TestError.builder(this, Severity.WARNING, EMPTY_VALUES)
                     .message(tr("Tags with empty values"), s, key)