Changeset 19432 in josm for trunk/src/org

Timestamp:

2025-08-05T07:47:47+02:00 (5 months ago)

Author:

GerdP

Message:

fix #24423: Relationeditor map sync broken

• with #21840 some actions automatically update an open relation editor window if the relation is in sync with the dataset, else a notification about a pending conflict is shown. This logic was broken with r19402. This patch simplifies the logic in isDirtyRelation(): don't return false just because field relationSnapshot has no dataset.

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/relation/RelationEditor.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/dialogs/relation/RelationEditor.java

@@ -153 +153 @@
     @Override
     public final boolean isDirtyRelation(boolean ignoreUninterestingTags) {
-        if (relation == null || relation.getDataSet() == null ||
-            relationSnapshot == null || relationSnapshot.getDataSet() == null) {
-            return false;
-        }
-
-        return !relation.hasEqualSemanticAttributes(relationSnapshot, ignoreUninterestingTags);
+        return relation != null && !relation.hasEqualSemanticAttributes(relationSnapshot, ignoreUninterestingTags);
     }