Changeset 18853 in josm for trunk/test/unit/org/openstreetmap/josm/io/audio/AudioPlayerTest.java

Timestamp:

2023-10-04T00:03:40+02:00 (19 months ago)

Author:

taylor.smock

Message:

See #16567: Update to JUnit 5

This removes new JOSMTestRules() with no additional setup and most
JOSMFixture calls.

Removing the bare JOSMTestRules speeds up the test suite since there are two
fewer System.gc() calls per test.

File:

• trunk/test/unit/org/openstreetmap/josm/io/audio/AudioPlayerTest.java (modified) (2 diffs)

trunk/test/unit/org/openstreetmap/josm/io/audio/AudioPlayerTest.java

@@ -3 +3 @@
 
 import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTimeout;
 import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.junit.jupiter.api.Assertions.assertTimeout;
 
 import java.io.File;
-import java.net.MalformedURLException;
 import java.net.URL;
 import java.time.Duration;
 
-import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
-import org.openstreetmap.josm.JOSMFixture;
 import org.openstreetmap.josm.TestUtils;
 import org.openstreetmap.josm.tools.Stopwatch;
@@ -28 +25 @@
 
     /**
-     * Setup test.
-     */
-    @BeforeAll
-    public static void setUp() {
-        JOSMFixture.createUnitTestFixture().init();
-    }
-
-    /**
      * Test method for {@code AudioPlayer#play(URL)}
-     * @throws Exception audio fault exception, e.g. can't open stream, unhandleable audio format
-     * @throws MalformedURLException wrong URL
      */
     @Test
-    void testPlay() throws MalformedURLException, Exception {
+    void testPlay() {
         assertTimeout(Duration.ofMillis(4*MAX_DURATION), () -> {
             File wav1 = new File(TestUtils.getRegressionDataFile(6851, "20111003_121226.wav"));