Changeset 18652 in josm for trunk/src/org/openstreetmap/josm/tools/HttpClient.java

Timestamp:

2023-02-09T09:47:37+01:00 (2 years ago)

Author:

stoecker

Message:

unify stripUrl() handling

File:

• trunk/src/org/openstreetmap/josm/tools/HttpClient.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/tools/HttpClient.java

@@ -34 +34 @@
 import org.openstreetmap.josm.io.auth.DefaultAuthenticator;
 import org.openstreetmap.josm.spi.preferences.Config;
+import org.openstreetmap.josm.tools.TextUtils;
 
 /**
@@ -126 +127 @@
 
     /**
-     * Removed privacy related parts form output URL
-     * @param url Unmodified URL
-     * @return Stripped URL (privacy related issues removed)
-     */
-    private String stripUrl(URL url) {
-        return url.toString().replaceAll("(token|key|connectId)=[^&]+", "$1=...stripped...");
-    }
-
-    /**
      * Opens the HTTP connection.
      * @param progressMonitor progress monitor
@@ -158 +150 @@
                 final boolean hasReason = !Utils.isEmpty(reasonForRequest);
                 logRequest("{0} {1}{2} -> {3} {4} ({5}{6})",
-                        getRequestMethod(), stripUrl(getURL()), hasReason ? (" (" + reasonForRequest + ')') : "",
+                        getRequestMethod(), TextUtils.stripUrl(getURL().toString()), hasReason ? (" (" + reasonForRequest + ')') : "",
                         cr.getResponseVersion(), cr.getResponseCode(),
                         stopwatch,
@@ -176 +168 @@
                 }
             } catch (IOException | RuntimeException e) {
-                logRequest("{0} {1} -> !!! ({2})", requestMethod, stripUrl(url), stopwatch);
+                logRequest("{0} {1} -> !!! ({2})", requestMethod, TextUtils.stripUrl(url.toString()), stopwatch);
                 Logging.warn(e);
                 //noinspection ThrowableResultOfMethodCallIgnored