Changeset 18601 in josm for trunk/src

Timestamp:

2022-11-21T22:49:28+01:00 (17 months ago)

Author:

taylor.smock

Message:

Fix #20528: Copy does not work from the welcome screen

This was caused by setting the TransferHandler to null in order to get
drag and drop working. Instead of setting the TransferHandler to null, we
just set the DropTarget to null, which is what prevents the parent
DropTarget from being triggered.

The DropTarget could also have it's setActive method called with false,
but this will hopefully be less surprising.

File:

• trunk/src/org/openstreetmap/josm/gui/GettingStarted.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/GettingStarted.java

@@ -62 +62 @@
             + "</style>\n";
 
+    /**
+     * A subclass of {@link JosmEditorPane} which replaces links with something clickable (uses {@link OpenBrowser})
+     * @since 623
+     */
     public static class LinkGeneral extends JosmEditorPane implements HyperlinkListener {
 
@@ -144 +148 @@
         lg.getInputMap(JComponent.WHEN_FOCUSED).put(MenuItemSearchDialog.Action.SHORTCUT.getKeyStroke(), "none");
         lg.getInputMap(JComponent.WHEN_FOCUSED).put(HistoryInfoAction.SHORTCUT.getKeyStroke(), "none");
-        lg.setTransferHandler(null);
+        // Don't use the text handler drag and drop behavior. See #13196/#20528.
+        lg.setDropTarget(null);
 
         JScrollPane scroller = new JScrollPane(lg);