Changeset 18199 in josm for trunk/resources

Timestamp:

2021-09-08T00:58:22+02:00 (3 years ago)

Author:

Don-vip

Message:

fix #21285 - Some more warnings on relations (patch by skyper):

• adds warnings for type=destination_sign without destination=* and type=building without building=*
• adds TRANSPORT_MODE=private to no and use_side as problematic values for ways member of route=bicycle/mtb
• adds route=hiking/running/walking/fitness_trail and route=horse with inappropriate foot=* respectively horse=* to the warning above.

File:

• trunk/resources/data/validator/relation.mapcss (modified) (2 diffs)

trunk/resources/data/validator/relation.mapcss

@@ -9 +9 @@
 /* from http://wiki.openstreetmap.org/wiki/Types_of_relation */
 /* see also #9071 */
+relation[type=boundary][!boundary][!disused:boundary],
+relation[type=building][!building],
+relation[type=destination_sign][!destination],
+relation[type=enforcement][!enforcement],
+relation[type=public_transport][!public_transport],
 relation[type=route][!route],
 relation[type=route_master][!route_master],
-relation[type=boundary][!boundary][!disused:boundary],
-relation[type=public_transport][!public_transport],
-relation[type=waterway][!waterway],
-relation[type=enforcement][!enforcement] {
+relation[type=waterway][!waterway] {
   throwWarning: tr("{0} relation without {0} tag", "{1.key}");
   group: tr("missing tag");
@@ -44 +46 @@
 relation[type=route][route=mtb    ] > way[bicycle=no],
 relation[type=route][route=bicycle] > way[bicycle=no],
+relation[type=route][route=mtb    ] > way[bicycle=private],
+relation[type=route][route=bicycle] > way[bicycle=private],
 relation[type=route][route=mtb    ] > way[bicycle=use_sidepath],
-relation[type=route][route=bicycle] > way[bicycle=use_sidepath] { 
-  throwWarning: tr("way with {0} is part of a bicycle route relation", "{0.tag}");
+relation[type=route][route=bicycle] > way[bicycle=use_sidepath], 
+relation[type=route][route=fitness_trail] > way[foot=no],
+relation[type=route][route=hiking       ] > way[foot=no],
+relation[type=route][route=running      ] > way[foot=no],
+relation[type=route][route=walking      ] > way[foot=no],
+relation[type=route][route=fitness_trail] > way[foot=private],
+relation[type=route][route=hiking       ] > way[foot=private],
+relation[type=route][route=running      ] > way[foot=private],
+relation[type=route][route=walking      ] > way[foot=private],
+relation[type=route][route=fitness_trail] > way[foot=use_sidepath],
+relation[type=route][route=hiking       ] > way[foot=use_sidepath],
+relation[type=route][route=running      ] > way[foot=use_sidepath],
+relation[type=route][route=walking      ] > way[foot=use_sidepath], 
+relation[type=route][route=horse] > way[horse=no],
+relation[type=route][route=horse] > way[horse=private],
+relation[type=route][route=horse] > way[horse=use_sidepath] { 
+  throwWarning: tr("way with {0} is part of a {1} route relation", "{0.tag}", "{0.key}");
 }