Changeset 16438 in josm for trunk/test


Ignore:
Timestamp:
2020-05-17T14:18:22+02:00 (4 years ago)
Author:
simon04
Message:

see #19251 - Java 8: use Stream

Location:
trunk/test
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/test/functional/org/openstreetmap/josm/gui/conflict/pair/nodes/NodeListMergerTestFT.java

    r9546 r16438  
    33
    44import java.awt.BorderLayout;
     5import java.util.stream.Collectors;
     6import java.util.stream.IntStream;
    57
    68import javax.swing.JFrame;
     
    2224            n1.put("key" + i, "value" + i);
    2325        }
    24         StringBuilder note = new StringBuilder();
    25         for (int i = 0; i < 50; i++) {
    26             note.append(" A very long text ");
    27         }
    28         n1.put("note", note.toString());
     26        // Java 11: use String.repeat
     27        String note = IntStream.range(0, 50).mapToObj(i -> " A very long text ").collect(Collectors.joining());
     28        n1.put("note", note);
    2929        w1.addNode(new Node(2));
    3030        w1.addNode(new Node(3));
  • trunk/test/unit/org/openstreetmap/josm/actions/CombineWayActionTest.java

    r15576 r16438  
    183183
    184184    private static double getOriginalLength(Collection<Way> ways) {
    185         double len = 0;
    186         for (Way w : ways) {
    187             len += w.getLength();
    188         }
    189         return len;
     185        return ways.stream().mapToDouble(Way::getLength).sum();
    190186    }
    191187
  • trunk/test/unit/org/openstreetmap/josm/actions/JoinAreasActionTest.java

    r16371 r16438  
    234234        Set<RelationMember> matchCandidates = new HashSet<>(r2.getMembers());
    235235        for (RelationMember rm : r1.getMembers()) {
    236             RelationMember matched = null;
    237             for (RelationMember cand : matchCandidates) {
    238                 if (!rm.getRole().equals(cand.getRole())) continue;
    239                 if (!isSemanticallyEqual(rm.getMember(), cand.getMember())) continue;
    240                 matched = cand;
    241                 break;
    242             }
     236            RelationMember matched = matchCandidates.stream()
     237                    .filter(m -> rm.getRole().equals(m.getRole()))
     238                    .filter(m -> isSemanticallyEqual(rm.getMember(), m.getMember()))
     239                    .findFirst().orElse(null);
    243240            if (matched == null) return false;
    244241            matchCandidates.remove(matched);
  • trunk/test/unit/org/openstreetmap/josm/data/coor/conversion/ICoordinateFormatTest.java

    r12746 r16438  
    88import org.junit.Rule;
    99import org.junit.Test;
     10import org.openstreetmap.josm.data.coor.ILatLon;
    1011import org.openstreetmap.josm.data.coor.LatLon;
    1112import org.openstreetmap.josm.testutils.JOSMTestRules;
     
    2526     * Tests {@link ICoordinateFormat#latToString(org.openstreetmap.josm.data.coor.ILatLon)}
    2627     * and {@link ICoordinateFormat#lonToString(org.openstreetmap.josm.data.coor.ILatLon)}
     28     * and {@link ICoordinateFormat#toString(ILatLon, String)}
    2729     * for various implementations.
    2830     */
     
    3234        assertEquals("47.0", DecimalDegreesCoordinateFormat.INSTANCE.latToString(c));
    3335        assertEquals("19.0", DecimalDegreesCoordinateFormat.INSTANCE.lonToString(c));
     36        assertEquals("47.0 19.0", DecimalDegreesCoordinateFormat.INSTANCE.toString(c, " "));
    3437        assertEquals("47°00'00.0\"N", DMSCoordinateFormat.INSTANCE.latToString(c));
    3538        assertEquals("19°00'00.0\"E", DMSCoordinateFormat.INSTANCE.lonToString(c));
     39        assertEquals("47°00'00.0\"N  19°00'00.0\"E", DMSCoordinateFormat.INSTANCE.toString(c, "  "));
    3640        assertEquals("47°00.000'N", NauticalCoordinateFormat.INSTANCE.latToString(c));
    3741        assertEquals("19°00.000'E", NauticalCoordinateFormat.INSTANCE.lonToString(c));
  • trunk/test/unit/org/openstreetmap/josm/gui/dialogs/relation/sort/RelationSorterTest.java

    r16006 r16438  
    5252
    5353    private Relation getRelation(String testType) {
    54         for (Relation r: testDataset.getRelations()) {
    55             if (testType.equals(r.get("test")))
    56                 return r;
    57         }
    58         return null;
     54        return testDataset.getRelations().stream().filter(r -> testType.equals(r.get("test"))).findFirst().orElse(null);
    5955    }
    6056
    6157    private String[] getNames(List<RelationMember> members) {
    62         String[] result = new String[members.size()];
    63         for (int i = 0; i < result.length; i++) {
    64             result[i] = members.get(i).getMember().get("name");
    65         }
    66         return result;
     58        return members.stream().map(member -> member.getMember().get("name")).toArray(String[]::new);
    6759    }
    6860
  • trunk/test/unit/org/openstreetmap/josm/gui/dialogs/relation/sort/WayConnectionTypeCalculatorTest.java

    r16006 r16438  
    5959
    6060    private Relation getRelation(String testType) {
    61         for (Relation r: testDataset.getRelations()) {
    62             if (testType.equals(r.get("test")))
    63                 return r;
    64         }
    65         return null;
     61        return testDataset.getRelations().stream().filter(r -> testType.equals(r.get("test"))).findFirst().orElse(null);
    6662    }
    6763
  • trunk/test/unit/org/openstreetmap/josm/gui/preferences/imagery/ImageryPreferenceTestIT.java

    r16398 r16438  
    2020import java.util.concurrent.TimeUnit;
    2121import java.util.stream.Collectors;
     22import java.util.stream.Stream;
    2223
    2324import javax.imageio.ImageIO;
     
    280281        // |  8  3  7  |
    281282        // +-----------+
    282         for (LatLon candidate : new LatLon[] {
     283        return Stream.of(
    283284                new LatLon(y1, x2),
    284285                new LatLon(y2, x3),
     
    289290                new LatLon(y3, x3),
    290291                new LatLon(y3, x1)
    291         }) {
    292             if (shape.contains(candidate)) {
    293                 return candidate;
    294             }
    295         }
    296         return center;
     292        ).filter(shape::contains).findFirst().orElse(center);
    297293    }
    298294
Note: See TracChangeset for help on using the changeset viewer.