Changeset 16101 in josm for trunk/src

Timestamp:

2020-03-09T00:48:59+01:00 (4 years ago)

Author:

simon04

Message:

see #18896: ImageryInfo: use Utils.toUnmodifiableList and Utils.toUnmodifiableMap

File:

• trunk/src/org/openstreetmap/josm/data/imagery/ImageryInfo.java (modified) (7 diffs)

trunk/src/org/openstreetmap/josm/data/imagery/ImageryInfo.java

@@ -19 +19 @@
 import java.util.Set;
 import java.util.TreeSet;
-import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.TimeUnit;
 import java.util.regex.Matcher;
@@ -305 +304 @@
     private boolean isGeoreferenceValid;
     /** which layers should be activated by default on layer addition. **/
-    private List<DefaultLayer> defaultLayers = new ArrayList<>();
+    private List<DefaultLayer> defaultLayers = Collections.emptyList();
     /** HTTP headers **/
-    private Map<String, String> customHttpHeaders = new ConcurrentHashMap<>();
+    private Map<String, String> customHttpHeaders = Collections.emptyMap();
     /** Should this map be transparent **/
     private boolean transparent = true;
@@ -588 +587 @@
             }
         }
-        customHttpHeaders = e.customHttpHeaders;
+        setCustomHttpHeaders(e.customHttpHeaders);
         transparent = e.transparent;
         minimumTileExpire = e.minimumTileExpire;
@@ -635 +634 @@
         this.icon = intern(i.icon);
         this.isGeoreferenceValid = i.isGeoreferenceValid;
-        this.defaultLayers = i.defaultLayers;
-        this.customHttpHeaders = i.customHttpHeaders;
+        setDefaultLayers(i.defaultLayers);
+        setCustomHttpHeaders(i.customHttpHeaders);
         this.transparent = i.transparent;
         this.minimumTileExpire = i.minimumTileExpire;
@@ -1571 +1570 @@
      */
     public void setDefaultLayers(List<DefaultLayer> layers) {
-        this.defaultLayers = layers;
+        this.defaultLayers = Utils.toUnmodifiableList(layers);
     }
 
@@ -1579 +1578 @@
      */
     public Map<String, String> getCustomHttpHeaders() {
-        if (customHttpHeaders == null) {
-            return Collections.emptyMap();
-        }
         return customHttpHeaders;
     }
@@ -1590 +1586 @@
      */
     public void setCustomHttpHeaders(Map<String, String> customHttpHeaders) {
-        this.customHttpHeaders = customHttpHeaders;
+        this.customHttpHeaders = Utils.toUnmodifiableMap(customHttpHeaders);
     }