Changeset 1608 in josm

Timestamp:

2009-05-23T11:36:04+02:00 (15 years ago)

Author:

stoecker

Message:

close #2633 - patch by Gubaer - better error message for server aborts

Location:

trunk/src/org/openstreetmap/josm/io

Files:

• OsmApi.java (modified) (2 diffs)
• OsmServerReader.java (modified) (2 diffs)
• OsmServerWriter.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/io/OsmApi.java

@@ -129 +129 @@
     /**
      * Initializes this component by negotiating a protocol version with the server.
-     */
-    public void initialize() {
+     * 
+     * @exception UnknownHostException thrown, if the API host is unknown
+     * @exception SocketTimeoutException thrown, if the connection to the API host  times out
+     * @exception ConnectException throw, if the connection to the API host fails 
+     * @exception Exception any other exception 
+     */
+    public void initialize() throws UnknownHostException,SocketTimeoutException, ConnectException,Exception {
         initAuthentication();
         try {
@@ -153 +158 @@
         } catch (Exception ex) {
             initialized = false;
-            ex.printStackTrace();
+            throw ex;
         }
     }

trunk/src/org/openstreetmap/josm/io/OsmServerReader.java

@@ -11 +11 @@
 import java.util.zip.InflaterInputStream;
 import java.util.zip.GZIPInputStream;
+
+import javax.swing.JOptionPane;
 
 import org.openstreetmap.josm.Main;
@@ -38 +40 @@
      */
     protected InputStream getInputStream(String urlStr, PleaseWaitDialog pleaseWaitDlg) throws IOException {
-        api.initialize();
+       
+        // initialize API. Abort download in case of configuration or network
+        // errors
+        //
+        try {
+            api.initialize();
+        } catch(Exception e) {
+            JOptionPane.showMessageDialog(
+                null,
+                tr(   "Failed to initialize communication with the OSM server {0}.\n"
+                    + "Check the server URL in your preferences and your internet connection.",
+                    Main.pref.get("osm-server.url")
+                ),
+                tr("Error"),
+                JOptionPane.ERROR_MESSAGE
+            );
+            e.printStackTrace();
+            return null;
+        }
+
         urlStr = api.getBaseUrl() + urlStr;
         return getInputStreamRaw(urlStr, pleaseWaitDlg);

trunk/src/org/openstreetmap/josm/io/OsmServerWriter.java

@@ -68 +68 @@
     public void uploadOsm(String the_version, Collection<OsmPrimitive> list) {
         processed = new LinkedList<OsmPrimitive>();
-        api.initialize();
+        
+        // initialize API. Abort upload in case of configuration or network
+        // errors
+        //
+        try {
+            api.initialize();
+        } catch(Exception e) {
+            JOptionPane.showMessageDialog(
+                null,
+                tr(   "Failed to initialize communication with the OSM server {0}.\n"
+                    + "Check the server URL in your preferences and your internet connection.",
+                    Main.pref.get("osm-server.url")
+                ),
+                tr("Error"),
+                JOptionPane.ERROR_MESSAGE
+            );
+            e.printStackTrace();
+            return;
+        }
+        
 
         Main.pleaseWaitDlg.progress.setMaximum(list.size());