Changeset 16077 in josm

Timestamp:

2020-03-08T14:31:54+01:00 (4 years ago)

Author:

simon04

Message:

see #18886 - Node.updateDirectionFlags: override to improve performance

Location:

trunk

Files:

• src/org/openstreetmap/josm/data/osm/Node.java (modified) (1 diff)
• src/org/openstreetmap/josm/data/osm/OsmPrimitive.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/data/osm/NodeTest.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/osm/Node.java

@@ -430 +430 @@
         return idGenerator;
     }
+
+    @Override
+    protected void updateDirectionFlags() {
+        // Nodes do not need/have a direction, greatly improves performance, see #18886
+    }
 }

trunk/src/org/openstreetmap/josm/data/osm/OsmPrimitive.java

@@ -607 +607 @@
     }
 
-    private void updateDirectionFlags() {
+    protected void updateDirectionFlags() {
         boolean hasDirections = false;
         boolean directionReversed = false;

trunk/test/unit/org/openstreetmap/josm/data/osm/NodeTest.java

@@ -130 +130 @@
     }
 
+    /**
+     * Test that {@link Node#hasDirectionKeys} is not set.
+     */
+    @Test
+    public void testDirectional() {
+        assertFalse(OsmUtils.createPrimitive("node oneway=yes").hasDirectionKeys());
+    }
 }