Changeset 15526 in josm for trunk

Timestamp:

2019-11-17T20:53:27+01:00 (4 years ago)

Author:

Klumbumbus

Message:

fix #18267 - replace pipeline=marker by marker=* preset and add related validator rules

Location:

trunk

Files:

• data/defaultpresets.xml (modified) (2 diffs)
• data/validator/combinations.mapcss (modified) (1 diff)
• data/validator/deprecated.mapcss (modified) (1 diff)
• styles/standard/elemstyles.mapcss (modified) (1 diff)

trunk/data/defaultpresets.xml

@@ -4873 +4873 @@
             <text key="pressure" text="Pressure (bar)" />
         </item> <!-- Pipeline -->
-        <item name="Pipeline Marker" icon="presets/misc/pipeline_marker.svg" type="node" preset_name_label="true">
-            <link wiki="Tag:pipeline=marker" />
-            <space />
-            <key key="pipeline" value="marker" />
-            <text key="ref" text="Reference" />
-            <reference ref="operator_substance" />
-            <reference ref="support" />
-        </item> <!-- Pipeline Marker -->
         <item name="Pipeline Valve" icon="presets/misc/valve.svg" type="node" preset_name_label="true">
             <link wiki="Tag:pipeline=valve" />
@@ -4892 +4884 @@
             <reference ref="ref_operator" />
         </item> <!-- Pipeline Valve -->
+        <item name="Marker" icon="presets/misc/pipeline_marker.svg" type="node" preset_name_label="true">
+            <link wiki="Key:marker" />
+            <space />
+            <combo key="marker" text="Type" values="aerial,ground,pedestal,plate,post,stone" match="key" />
+            <combo key="utility" text="Utility" values="chemical,gas,heating,hydrant,oil,power,sewerage,street_lighting,telecom,television,waste,water" />
+            <optional>
+                <reference ref="ref_operator" />
+                <combo key="material" text="Material" values="concrete,metal,plastic,steel,stone,wood" values_context="marker />
+                <combo key="colour" text="Color (HTML name or hexadecimal code)" values_context="color" values="black,blue,brown,gray,green,orange,purple,red,silver,white,yellow,#CD853F" />
+                <combo key="location" text="Location" values="underground,overground" values_context="pipeline" />
+            </optional>
+        </item> <!-- Marker -->
         <item name="Manhole" icon="presets/misc/manhole.svg" type="node" preset_name_label="true">
             <link wiki="Key:manhole" />

trunk/data/validator/combinations.mapcss

@@ -288 +288 @@
 }
 
-/* {0.key} together with {1.key}, #17630, #17604 */
+/* {0.key} together with {1.key}, #18267, #17630, #17604 */
+node[marker][cover],
+node[marker][voltage],
+node[marker][pressure],
+node[marker][diameter],
+node[marker][substance],
 *[building:part][building],
 *[addr:street][addr:place][outside("CZ,DK")] {

trunk/data/validator/deprecated.mapcss

@@ -1819 +1819 @@
   group: tr("deprecated tagging");
 }
+
+/* #18267 */
+node[pipeline=marker],
+node[power=marker],
+node[cable=marker] {
+  throwWarning: tr("{0} is deprecated", "{0.tag}");
+  suggestAlternative: "marker=* + utility=*";
+  group: tr("deprecated tagging");
+}

trunk/styles/standard/elemstyles.mapcss

@@ -1504 +1504 @@
     color: pipeline#660000;
 }
-node[pipeline=marker] {
+node[marker] {
     icon-image: "presets/misc/pipeline_marker.svg";
     set icon_z17;