Changeset 14860 in josm

Timestamp:

2019-03-09T17:27:17+01:00 (5 years ago)

Author:

GerdP

Message:

fix some checkstyle and sonar issues, improve readability, no functional change expected

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/validator/ValidatorTreePanel.java (modified) (9 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/validator/ValidatorTreePanel.java

@@ -12 +12 @@
 import java.util.List;
 import java.util.Map;
+import java.util.Map.Entry;
 import java.util.Set;
 import java.util.function.Consumer;
@@ -164 +165 @@
 
         // Remember the currently expanded rows
-        Set<Object> oldSelectedRows = new HashSet<>();
+        Set<Object> oldExpandedRows = new HashSet<>();
         Enumeration<TreePath> expanded = getExpandedDescendants(new TreePath(getRoot()));
         if (expanded != null) {
@@ -172 +173 @@
                 Object userObject = node.getUserObject();
                 if (userObject instanceof Severity) {
-                    oldSelectedRows.add(userObject);
+                    oldExpandedRows.add(userObject);
                 } else if (userObject instanceof String) {
                     String msg = (String) userObject;
@@ -179 +180 @@
                         msg = msg.substring(0, index);
                     }
-                    oldSelectedRows.add(msg);
+                    oldExpandedRows.add(msg);
                 }
             }
@@ -195 +196 @@
 
         final List<TreePath> expandedPaths = new ArrayList<>();
-        errorsBySeverityMessageDescription.forEach((severity, errorsByMessageDescription) -> {
+        for (Entry<Severity, Map<String, Map<String, List<TestError>>>> entry: errorsBySeverityMessageDescription.entrySet()) {
+            Severity severity = entry.getKey();
+            Map<String, Map<String, List<TestError>>> errorsByMessageDescription = entry.getValue();
+
             // Severity node
             final DefaultMutableTreeNode severityNode = new GroupTreeNode(severity);
             rootNode.add(severityNode);
 
-            if (oldSelectedRows.contains(severity)) {
-                expandedPaths.add(new TreePath(new Object[] {rootNode, severityNode}));
-            }
-
             final Map<String, List<TestError>> errorsWithEmptyMessageByDescription = errorsByMessageDescription.get("");
             if (errorsWithEmptyMessageByDescription != null) {
-                errorsWithEmptyMessageByDescription.forEach((description, errors) -> {
-                    final String msg = tr("{0} ({1})", description, errors.size());
+                errorsWithEmptyMessageByDescription.forEach((description, noDescriptionErrors) -> {
+                    final String msg = tr("{0} ({1})", description, noDescriptionErrors.size());
                     final DefaultMutableTreeNode messageNode = new DefaultMutableTreeNode(msg);
                     severityNode.add(messageNode);
 
-                    if (oldSelectedRows.contains(description)) {
-                        expandedPaths.add(new TreePath(new Object[] {rootNode, severityNode, messageNode}));
+                    if (oldExpandedRows.contains(description)) {
+                        expandedPaths.add(new TreePath(new Object[] { rootNode, severityNode, messageNode }));
                     }
-
-                    errors.stream().map(DefaultMutableTreeNode::new).forEach(messageNode::add);
+                    // add the matching errors to the current node
+                    noDescriptionErrors.stream().map(DefaultMutableTreeNode::new).forEach(messageNode::add);
                 });
             }
@@ -228 +228 @@
                     groupNode = new GroupTreeNode(message);
                     severityNode.add(groupNode);
-                    if (oldSelectedRows.contains(message)) {
+                    if (oldExpandedRows.contains(message)) {
                         expandedPaths.add(new TreePath(new Object[] {rootNode, severityNode, groupNode}));
                     }
@@ -235 +235 @@
                 }
 
-                errorsByDescription.forEach((description, errors) -> {
+                errorsByDescription.forEach((description, errorsWithDescription) -> {
                     boolean emptyDescription = description == null || description.isEmpty();
                     // Message node
                     final String msg;
                     if (groupNode != null) {
-                        msg = tr("{0} ({1})", description, errors.size());
+                        msg = tr("{0} ({1})", description, errorsWithDescription.size());
                     } else if (emptyDescription) {
-                        msg = tr("{0} ({1})", message, errors.size());
+                        msg = tr("{0} ({1})", message, errorsWithDescription.size());
                     } else {
-                        msg = tr("{0} - {1} ({2})", message, description, errors.size());
+                        msg = tr("{0} - {1} ({2})", message, description, errorsWithDescription.size());
                     }
                     final DefaultMutableTreeNode messageNode = new DefaultMutableTreeNode(msg);
@@ -253 +253 @@
                     }
 
-                    if (oldSelectedRows.contains(description) || (emptyDescription && oldSelectedRows.contains(message))) {
+                    if (oldExpandedRows.contains(description) || (emptyDescription && oldExpandedRows.contains(message))) {
                         if (groupNode != null) {
                             expandedPaths.add(new TreePath(new Object[] {rootNode, severityNode, groupNode, messageNode}));
@@ -261 +261 @@
                     }
 
-                 // add the matching errors to the current node
-                    errors.stream().map(DefaultMutableTreeNode::new).forEach(messageNode::add);
+                    // add the matching errors to the current node
+                    errorsWithDescription.stream().map(DefaultMutableTreeNode::new).forEach(messageNode::add);
                 });
             });
-        });
+        }
 
         valTreeModel.setRoot(rootNode);